From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69330C433E6 for ; Wed, 15 Jul 2020 21:43:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 11748206F5 for ; Wed, 15 Jul 2020 21:43:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="GnnquYDJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11748206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A3E6A6B0002; Wed, 15 Jul 2020 17:43:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EF456B0005; Wed, 15 Jul 2020 17:43:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908BE8D0001; Wed, 15 Jul 2020 17:43:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 7C8266B0002 for ; Wed, 15 Jul 2020 17:43:20 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 31F5F181AC9BF for ; Wed, 15 Jul 2020 21:43:20 +0000 (UTC) X-FDA: 77041636560.05.shame11_3d0e80626efc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 087ED1801323E for ; Wed, 15 Jul 2020 21:43:20 +0000 (UTC) X-HE-Tag: shame11_3d0e80626efc X-Filterd-Recvd-Size: 8025 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jul 2020 21:43:19 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id h22so4394670lji.9 for ; Wed, 15 Jul 2020 14:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3057EMWaB0Rm7SYQylMTrxjhWYKGDzBcFFBU9TaBwGE=; b=GnnquYDJshFWXxRYjFZehI+GFKvShVAkirzPeulbS97rwl268xDJYKMsd3Gl7eLyHH m9I//bxHzB3mrtl7VR52+jQaPEqCWpg2k5AcyeErele8/RyM5U3eYDEveSZpJxJxDIN/ YRqqKk3QYZe7SUAlAdDXA6eqPB7agwr7jIg5U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3057EMWaB0Rm7SYQylMTrxjhWYKGDzBcFFBU9TaBwGE=; b=C2NM6UEAnnD3F58wwEQJMOs8+ceyFIOx5sjtvap3UqdsMFAscBWkJNxfvk/cai1r9o rJ9rBaQWxkQfymqfE2J4vn0eKukbeb4StqSIA0A8TTgUAqQWhC4nS0bvK6InfSWPM/ev EX2ppO3q1ftfC89nRKf/PsQC38TqTW2uf5c/M31W922WjOd4Wil/RceUSfuyEvTI6IQd P+Z2cxIAw5/2rp8JNwwrb9UQ7tCl4TObqcK1psa366e2Mxb85DP/Sjuf8eWNbBy6e3q6 7J8OKJUwIIuaww32H/76fu/cUQmbqP0a//yoafXoI/X35jlkpamM9Wl0NZZ0Lf8x9mGu WAyw== X-Gm-Message-State: AOAM531tLVfcHqEQMDajMdCUFnM1Any2PNzFr0rmHUOFqf6LEuC5A+C+ E0kr3/i1BZq4fHCkOKFht9FZcPKtYpY= X-Google-Smtp-Source: ABdhPJxcLYuh7UZmZsqp5VsQib8CXpIuuMIg8QR5fXugXG+QoXiyzpQLg2xOz1f2RQGJFs72DkNo3A== X-Received: by 2002:a2e:9cc2:: with SMTP id g2mr449568ljj.442.1594849397795; Wed, 15 Jul 2020 14:43:17 -0700 (PDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id l19sm661871ljb.15.2020.07.15.14.43.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2020 14:43:16 -0700 (PDT) Received: by mail-lf1-f46.google.com with SMTP id k15so1953003lfc.4 for ; Wed, 15 Jul 2020 14:43:16 -0700 (PDT) X-Received: by 2002:a05:6512:241:: with SMTP id b1mr138854lfo.125.1594849396345; Wed, 15 Jul 2020 14:43:16 -0700 (PDT) MIME-Version: 1.0 References: <20200715135011.42743-1-kirill.shutemov@linux.intel.com> <20200715205428.GA201569@google.com> In-Reply-To: From: Linus Torvalds Date: Wed, 15 Jul 2020 14:43:00 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2] mm: Fix warning in move_normal_pmd() To: Joel Fernandes Cc: "Kirill A. Shutemov" , Andrew Morton , Linux-MM , Linux Kernel Mailing List , Naresh Kamboju , William Kucharski Content-Type: multipart/mixed; boundary="000000000000bd913e05aa81cf94" X-Rspamd-Queue-Id: 087ED1801323E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000bd913e05aa81cf94 Content-Type: text/plain; charset="UTF-8" On Wed, Jul 15, 2020 at 2:31 PM Linus Torvalds wrote: > > Naresh - don't test that version. The bugs Joel found just make the > math wrong, so it won't work. Here's a new version with the thing that Joel and Kirill both noticed hopefully fixed. But I probably screwed it up again. I guess I should test it, but I don't have any really relevant environment (the plain mremap() case should have shown the obvious bugs, though, so that's just an excuse for my laziness) Linus --000000000000bd913e05aa81cf94 Content-Type: application/octet-stream; name=patch Content-Disposition: attachment; filename=patch Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kcnw52pb0 ZGlmZiAtLWdpdCBhL21tL21yZW1hcC5jIGIvbW0vbXJlbWFwLmMKaW5kZXggNWRkNTcyZDU3Y2E5 Li42MTRiNGZmZmVkMWQgMTAwNjQ0Ci0tLSBhL21tL21yZW1hcC5jCisrKyBiL21tL21yZW1hcC5j CkBAIC0yMzUsNiArMjM1LDcxIEBAIHN0YXRpYyBib29sIG1vdmVfbm9ybWFsX3BtZChzdHJ1Y3Qg dm1fYXJlYV9zdHJ1Y3QgKnZtYSwgdW5zaWduZWQgbG9uZyBvbGRfYWRkciwKIAogCXJldHVybiB0 cnVlOwogfQorCisjZGVmaW5lIEFERFJfQkVGT1JFX1BSRVYoYWRkciwgdm1hKSBcCisJKCh2bWEp LT52bV9wcmV2ICYmIChhZGRyKSA8ICh2bWEpLT52bV9wcmV2LT52bV9lbmQpCisKK3N0YXRpYyBp bmxpbmUgdm9pZCB0cnlfdG9fYWxpZ25fc3RhcnQodW5zaWduZWQgbG9uZyAqbGVuLAorCXN0cnVj dCB2bV9hcmVhX3N0cnVjdCAqb2xkLCB1bnNpZ25lZCBsb25nICpvbGRfYWRkciwKKwlzdHJ1Y3Qg dm1fYXJlYV9zdHJ1Y3QgKm5ldywgdW5zaWduZWQgbG9uZyAqbmV3X2FkZHIpCit7CisJaWYgKEFE RFJfQkVGT1JFX1BSRVYoKm9sZF9hZGRyICYgUE1EX01BU0ssIG9sZCkpCisJCXJldHVybjsKKwor CWlmIChBRERSX0JFRk9SRV9QUkVWKCpuZXdfYWRkciAmIFBNRF9NQVNLLCBuZXcpKQorCQlyZXR1 cm47CisKKwkvKiBCaW5nbyEgKi8KKwkqbGVuICs9ICpuZXdfYWRkciAmIH5QTURfTUFTSzsKKwkq b2xkX2FkZHIgJj0gUE1EX01BU0s7CisJKm5ld19hZGRyICY9IFBNRF9NQVNLOworfQorCisvKgor ICogV2hlbiBhbGlnbmluZyB0aGUgZW5kLCBhdm9pZCBBTElHTigpICh3aGljaCBjYW4gb3ZlcmZs b3cKKyAqIGlmIHRoZSB1c2VyIHNwYWNlIGlzIHRoZSBmdWxsIGFkZHJlc3Mgc3BhY2UsIGFuZCBv dmVyc2hvb3QKKyAqIHRoZSB2bV9zdGFydCBvZiB0aGUgbmV4dCB2bWEpLgorICoKKyAqIEFsaWdu IHRoZSB1cHBlciBsaW1pdCBkb3duIGluc3RlYWQsIGFuZCBjaGVjayB0aGF0IGl0J3Mgbm90Cisg KiBpbiB0aGUgc2FtZSBQTUQgYXMgdGhlIGVuZC4KKyAqLworI2RlZmluZSBBRERSX0FGVEVSX05F WFQoYWRkciwgdm1hKSBcCisJKCh2bWEpLT52bV9uZXh0ICYmIChhZGRyKSA+IChQTURfTUFTSyAm ICh2bWEpLT52bV9uZXh0LT52bV9zdGFydCkpCisKK3N0YXRpYyBpbmxpbmUgdm9pZCB0cnlfdG9f YWxpZ25fZW5kKHVuc2lnbmVkIGxvbmcgKmxlbiwKKwlzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKm9s ZCwgdW5zaWduZWQgbG9uZyAqb2xkX2FkZHIsCisJc3RydWN0IHZtX2FyZWFfc3RydWN0ICpuZXcs IHVuc2lnbmVkIGxvbmcgKm5ld19hZGRyKQoreworCWlmIChBRERSX0FGVEVSX05FWFQoKm9sZF9h ZGRyICsgKmxlbiwgb2xkKSkKKwkJcmV0dXJuOworCisJaWYgKEFERFJfQUZURVJfTkVYVCgqbmV3 X2FkZHIgKyAqbGVuLCBuZXcpKQorCQlyZXR1cm47CisKKwkvKiBNdXR1YWwgYWxpZ25tZW50IG1l YW5zIHRoaXMgaXMgc2FtZSBmb3IgbmV3L29sZCBhZGRyICovCisJKmxlbiA9IEFMSUdOKCpuZXdf YWRkciArICpsZW4sIFBNRF9TSVpFKSAtICpuZXdfYWRkcjsKK30KKworLyoKKyAqIFRoZSBQTUQg bW92ZSBjYXNlIGlzIG11Y2ggbW9yZSBlZmZpY2llbnQsIHNvIGlmIHdlIGhhdmUgdGhlCisgKiBt dXR1YWxseSBhbGlnbmVkIGNhc2UsIHRyeSB0byBzZWUgaWYgd2UgY2FuIGV4dGVuZCB0aGUKKyAq IGJlZ2lubmluZyBhbmQgZW5kIHRvIGJlIGFsaWduZWQgdG9vLgorICoKKyAqIFRoZSBwb2ludGVy IGRlcmVmZXJlbmNlcyBsb29rIGJhZCwgYnV0IHdpdGggaW5saW5pbmcsIHRoZQorICogY29tcGls ZXIgd2lsbCBzb3J0IGl0IG91dC4KKyAqLworc3RhdGljIGlubGluZSB2b2lkIHRyeV90b19hbGln bl9yYW5nZSh1bnNpZ25lZCBsb25nICpsZW4sCisJc3RydWN0IHZtX2FyZWFfc3RydWN0ICpvbGQs IHVuc2lnbmVkIGxvbmcgKm9sZF9hZGRyLAorCXN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqbmV3LCB1 bnNpZ25lZCBsb25nICpuZXdfYWRkcikKK3sKKwlpZiAoKCpvbGRfYWRkciBeICpuZXdfYWRkcikg JiB+UE1EX01BU0spCisJCXJldHVybjsKKworCXRyeV90b19hbGlnbl9zdGFydChsZW4sIG9sZCwg b2xkX2FkZHIsIG5ldywgbmV3X2FkZHIpOworCXRyeV90b19hbGlnbl9lbmQobGVuLCBvbGQsIG9s ZF9hZGRyLCBuZXcsIG5ld19hZGRyKTsKK30KKyNlbHNlCisjZGVmaW5lIHRyeV90b19hbGlnbl9y YW5nZShsZW4sb2xkLG9sZGEsbmV3LG5ld2EpIGRvIHsgfSB3aGlsZSgwKTsKICNlbmRpZgogCiB1 bnNpZ25lZCBsb25nIG1vdmVfcGFnZV90YWJsZXMoc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEs CkBAIC0yNTMsNiArMzE4LDggQEAgdW5zaWduZWQgbG9uZyBtb3ZlX3BhZ2VfdGFibGVzKHN0cnVj dCB2bV9hcmVhX3N0cnVjdCAqdm1hLAogCQkJCW9sZF9hZGRyLCBvbGRfZW5kKTsKIAltbXVfbm90 aWZpZXJfaW52YWxpZGF0ZV9yYW5nZV9zdGFydCgmcmFuZ2UpOwogCisJdHJ5X3RvX2FsaWduX3Jh bmdlKCZsZW4sIHZtYSwgJm9sZF9hZGRyLCBuZXdfdm1hLCAmbmV3X2FkZHIpOworCiAJZm9yICg7 IG9sZF9hZGRyIDwgb2xkX2VuZDsgb2xkX2FkZHIgKz0gZXh0ZW50LCBuZXdfYWRkciArPSBleHRl bnQpIHsKIAkJY29uZF9yZXNjaGVkKCk7CiAJCW5leHQgPSAob2xkX2FkZHIgKyBQTURfU0laRSkg JiBQTURfTUFTSzsK --000000000000bd913e05aa81cf94--