From: Yi Zhang <yi.zhang@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>, Jens Axboe <axboe@kernel.dk>,
linux-block <linux-block@vger.kernel.org>,
Linux NVDIMM <nvdimm@lists.linux.dev>,
linux-mm@kvack.org
Subject: Re: fix a pmem regression due to drain the block queue in del_gendisk
Date: Wed, 20 Oct 2021 14:38:23 +0800 [thread overview]
Message-ID: <CAHj4cs-osb2QuuCV2PW8xhefc3ATReur=b0tVf6ogTkMFmVi=A@mail.gmail.com> (raw)
In-Reply-To: <20211019073641.2323410-1-hch@lst.de>
Verified the issue was fixed by this patchset.
https://lore.kernel.org/linux-block/CAHj4cs87BapQJcV0a=M6=dc9PrsGH6qzqJEt9fbjLK1aShnMPg@mail.gmail.com/
Tested-by: Yi Zhang <yi.zhang@redhat.com>
On Tue, Oct 19, 2021 at 3:37 PM Christoph Hellwig <hch@lst.de> wrote:
>
> Hi Dan,
>
> this series fixes my recently introduced regression in the pmem driver by
> removing the usage of q_usage_count as the external pgmap refcount in the
> pmem driver and then removes the now unused external refcount
> infrastructure.
>
> Diffstat:
> drivers/nvdimm/pmem.c | 33 +--------------------
> include/linux/memremap.h | 18 +----------
> mm/memremap.c | 59 +++++++-------------------------------
> tools/testing/nvdimm/test/iomap.c | 43 +++++++--------------------
> 4 files changed, 29 insertions(+), 124 deletions(-)
>
--
Best Regards,
Yi Zhang
prev parent reply other threads:[~2021-10-20 6:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 7:36 Christoph Hellwig
2021-10-19 7:36 ` [PATCH 1/2] nvdimm/pmem: stop using q_usage_count as external pgmap refcount Christoph Hellwig
2021-10-19 7:36 ` [PATCH 2/2] memremap: remove support for external pgmap refcounts Christoph Hellwig
[not found] ` <YXFtwcAC0WyxIWIC@angband.pl>
2021-10-22 5:55 ` Christoph Hellwig
2021-10-22 15:43 ` Dan Williams
2021-10-26 1:42 ` Dan Williams
2021-10-26 5:53 ` Christoph Hellwig
2021-10-26 17:34 ` Dan Williams
2021-10-20 6:38 ` Yi Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHj4cs-osb2QuuCV2PW8xhefc3ATReur=b0tVf6ogTkMFmVi=A@mail.gmail.com' \
--to=yi.zhang@redhat.com \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox