From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 023DFD6D239 for ; Wed, 27 Nov 2024 20:49:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C4BA6B0082; Wed, 27 Nov 2024 15:49:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 074CD6B0083; Wed, 27 Nov 2024 15:49:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7E7F6B0085; Wed, 27 Nov 2024 15:49:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CB7106B0082 for ; Wed, 27 Nov 2024 15:49:42 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7467F12187E for ; Wed, 27 Nov 2024 20:49:42 +0000 (UTC) X-FDA: 82833066162.29.00BFDDD Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf18.hostedemail.com (Postfix) with ESMTP id 011FF1C0010 for ; Wed, 27 Nov 2024 20:49:37 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IJaL8Jq9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of ju.orth@gmail.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=ju.orth@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732740575; a=rsa-sha256; cv=none; b=XmBEYNToqSJN0OaJHlpGkv5l4aVF/ddbkH4013EnM81lxZEDv1cmCo1Oo/vIx33bih34Np 4n7y2iIjkgg6Jn9vZWbrmX1ICApRl3sIu3R8uJdbNyJhXdeXc6yo6uQ3e8h73/2+dX+ZEH nQSSKSvMnWbw/MW4R7ya6JlbdVZ6se0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IJaL8Jq9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of ju.orth@gmail.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=ju.orth@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732740575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=2AW5yJ4KIbibtsF5qwJxVbTuffKlNF5I0rKiR3i9vh4=; b=u1oyykSvQN2N4oOT5LAnCsBNqp4LIDh+i9mrOExQEGyPs3bORRcgSUdeDX1CPjXO6+dgkF Ra4iz9QniIzvQh/MPF7375x1b+NKsXz2CxdBc/s+HZK3z1ReWb2tM27oPywiRNRhFIusp0 ktwTX0XbQfWxC+Ibtje3fwbloMDSZOc= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-6e9f8dec3daso1449297b3.0 for ; Wed, 27 Nov 2024 12:49:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732740580; x=1733345380; darn=kvack.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=2AW5yJ4KIbibtsF5qwJxVbTuffKlNF5I0rKiR3i9vh4=; b=IJaL8Jq9xskTXAfU9/SLliSa+sZ8WjBR0gUJln83J7NLEsKpVFqOybgWGYZyxp5Pt3 G2/AfiG9FYljZQS8uowg6h64irPG8QvxOpWckD+s+xZXejiPjnKy8NRCRbc42uJzAdsb W1RiZijflrJvS0dXTIpdq+2TcMYy9s1cfoTLxD+iCtBetnZKqdr9GAQ/3uYoA/jd0/cP ID44M3B2KhetFPXr+tVkJ3qaLRjCUHlisqvGqaDdCqDGTgtfqMDSZoKtZkC1DfyEng7V ABiUWPk+STv1UD/d5p9Esj6j83Q9xPMqtwoKw5R/gwHJJElVzCARodBjcp5Pspn9tuRc cPYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732740580; x=1733345380; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2AW5yJ4KIbibtsF5qwJxVbTuffKlNF5I0rKiR3i9vh4=; b=TTwwHm3yO4CB2q3Hv2HZ1qFORYxAkbFt4WNxb9RJMub1HOJdwbNhtU217Yod3/A0Nc 2ClTG6XyvTaw7dfL8jFaM2tAxZqsctbNfGi6wZBrqDnxXsAL+58CmwfSrRUbZ9DxpAN7 BZlhIJdPZgLqozVBULCDGoli8dR74e4gEFgrcM9gPUrLlytIGpazQd8uawX7kCShHuOc +m5y2SevlZQcLqjiWMnY1Zb3wHz1ZYZ2JL1bgxfI5q4r4ylGOpYcX+EZSQ1h+bNCeiHR 5V3bKLt7mm3WDLA0nKAz7Xj4tG2uliyUg8C7OUowIGT27L60Js0hA9x4/vBHeHx0VGtJ T0Uw== X-Gm-Message-State: AOJu0Yy0rLpArdbjY47pWn4/IaUh23foR44Md6tF12Qbu3bkNQUEAZMG l1D5TelgM/OSJq2o59mmwINV9wfu3p6sHlsqpTheVonENzPiako+OfHWkitGJCtZOfcfn8TnLME 66Wu3Lz268HJNmH4iA1TW89e/IMY= X-Gm-Gg: ASbGnctayq8u6qRO70u0o0wJD0ERAA+iZenrESOSt2z91Y8oi4Sfzfb8VZ09Txa/4Pl vRKkvgz9GdLypzxlBrnQm0/b3NHk2CccXU8E/KSaK X-Google-Smtp-Source: AGHT+IFKuj4PVa/5XiN66xPsvCV4558YJWHCtHUwL7Ht4D06xdTvBnaK+b5Vfbg/DDVh760KzDUfBjIpc0LeZVZXbG4= X-Received: by 2002:a05:690c:4b93:b0:6ef:159c:f8a1 with SMTP id 00721157ae682-6ef37281e23mr53055507b3.37.1732740579723; Wed, 27 Nov 2024 12:49:39 -0800 (PST) MIME-Version: 1.0 From: Julian Orth Date: Wed, 27 Nov 2024 21:49:29 +0100 Message-ID: Subject: Regression: mmap rejects shared, read-only mappings of write-sealed memfds To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 011FF1C0010 X-Stat-Signature: kr5xgadhcdhndcz6qhhpozpfezjuk9zn X-Rspam-User: X-HE-Tag: 1732740577-447425 X-HE-Meta: U2FsdGVkX184DcIJizQSs700CZ4sPI6RIC1C0sGZ9l1Tatz0Z10IuaLi5+0tRpHWuvEgpiPtufxbHwu+4bpcejhZZCcbWHy1JrlWUJs7CadGFTXfJSGhx5+irZRZClAfKNPwv60WKDV+J4awvtBMAJFVbZKMSozGBE6XOgH+Rws/GIENcf08oIgRvYU6ynWntqDJili7aUhfmT3eu3Y8A0CtfXv77arVavZpulZhdKhdAgEnlYwp5mBM6llygbqWNjAIkuzkC9Rygldg+G0GY6Cfzq8T8ybGTIIGkDXqL1aVPo0OB3IEeI3xnbprcbU8TzYr5Q5AGcWvoxkNhpS6poiNA2gRfNGoQ8hIYLV/+ddRPz/tZGWB8JvIjb1Eo8/O547r25NQwiOjuVQ6U6i/P78TK5CQRuL95OdWfxU7mqdgFdgM/sKN1fk/AxIQGQ0W1UqkiqYrYu26kbev0PV+ZcussTH62BONADF4Kml3A8tHWsC+uO43MW7XYSIorkM29OMGmN8X3lczDnaCgK8y7melHioVivpxTD5eooWEoiWN0jpqas7K5IOnT7MD0vZxSSWDgLBtn1d4tWnLs4EXo8sVtdcb9HnrkLcTP/JF3CHSQ7DJLBdCteDET8OTrhVIUQLkvST5/jaRmxiDm6MFC6MwShRzEQbF0n9O73kQBbumRrjG/WlY1ZfpyhFwDY8KQkKprUUINB3wHOnLHyyhgP88tpyB+BP07nSo1QIrCzz/yL2hJf0AVWuAwJ+XMkX7VycgEunRd37OSDVE5wK8UlgrCzKIJonTVEC78PuvZwPSHHS1x1msdJUAdWwuPnZbnRc4cETNACIIjZq+NEUJBOv0JXb0i1EhQzWaN3OZlKuNWCh7o4ckLH7nm1Hf4FI5ffaTTkSK7sIY7THKzF6gWESwwtfQ8QbfJTnXWfr93PO9HtOgGaMLXAn6q9YENL9aCM1gPLZ2RbkPWWy8Kqh N3CD4BAh 1XcyvzmfU0H+SOoPBJMlvYmZ/4dbZRw4k8VxT2kFsyT+uuFvwLsdZP6PzEOK3dhvpLttWjed6ywLjhHKMn2r58BhUWTT2JDJeEDynYPnPO1jO2lhJVRuPEKuEzzOsFG2UoMygx9ZMHneyJcA2LCRSQ/Ex7xNYs5oqxv2/tVInahode50Gdn1QiRrpEX7NqEdfj8Kg6K5ZbVB+1S73PzJjhNqh/uKlXL/vv0NjCUnWKow0Q95jgojlse3o6qMEhy23BoUn2i6XTMGjKXhih1bfz7tqOB0LCTrSMjpdpepE95lPlDaMYfyQSQGbGEyePm9hLP5bCgQWR93g8VltUm0COwfPKIUuhcQ/U3HG X-Bogosity: Ham, tests=bogofilter, spamicity=0.081738, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since around 5de19506 mm: resolve faulty mmap_region() error path behaviour mmap rejects shared, read-only mapping of memfds that have a write-seal applied. Before the commit, the code in mmap_region was if (file) { vma->vm_file = get_file(file); error = mmap_file(file, vma); if (error) goto unmap_and_free_vma; if (vma_is_shared_maywrite(vma)) { error = mapping_map_writable(file->f_mapping); where mmap_file would clear the VM_MAYWRITE flag for write-sealed memfds. After the commit, the code in mmap_region is simply if (file && is_shared_maywrite(vm_flags)) { int error = mapping_map_writable(file->f_mapping); with mmap_file not being called until much later. This regression seems to have been first released in 6.12 and is still present on master.