From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E730BC433E2 for ; Mon, 14 Sep 2020 12:29:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D52F20709 for ; Mon, 14 Sep 2020 12:29:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="J2UK9YNZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D52F20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BFF306B0003; Mon, 14 Sep 2020 08:29:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD6796B0037; Mon, 14 Sep 2020 08:29:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B13816B0055; Mon, 14 Sep 2020 08:29:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id 97BA06B0003 for ; Mon, 14 Sep 2020 08:29:30 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 52A2E18027686 for ; Mon, 14 Sep 2020 12:29:30 +0000 (UTC) X-FDA: 77261597700.22.run33_3f0faa227108 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 1C59A18198DA5 for ; Mon, 14 Sep 2020 12:29:30 +0000 (UTC) X-HE-Tag: run33_3f0faa227108 X-Filterd-Recvd-Size: 4331 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Sep 2020 12:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600086569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fk8zzz6iG+LTm12PI7VouoO/Ytz2Ct1GiEhjBUFwErY=; b=J2UK9YNZ2cgx+JggcwSGVEQlWTm9FWahm5fQxDmCZRKeM3z014KqPykwnz/rx+SfYQHWhQ 8caYTwqwrOiDHjCP4Dc8ClFb/ySTlBY49VQho+ZuYvCHLFaDenypHqko62CdHNF1tdBpFf /8nfU+QPPlFZi6DAElV5cfI0+lP8xOc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-XRieCkAON8CuQ5Z2DfcPPg-1; Mon, 14 Sep 2020 08:29:27 -0400 X-MC-Unique: XRieCkAON8CuQ5Z2DfcPPg-1 Received: by mail-wr1-f70.google.com with SMTP id o6so6831222wrp.1 for ; Mon, 14 Sep 2020 05:29:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fk8zzz6iG+LTm12PI7VouoO/Ytz2Ct1GiEhjBUFwErY=; b=m8s+SOLU2zvCKsxMbDEyPJWxfsfPO6hjiNCD0/79gfm87qgbNjcBbWbCUQibMVVUoB 3B85Y68h90bbMqwE6Wee0R7RqvFZiPoWBbf7jw/NA8c+cHJG2nx4MWPVbwqc1ZRoyKeA OEnWazOaCZnS4XW5ZWsRu/hjY+pc2+70YMHi4WlAA7pGAF8Ypo/88At7PD2DEQHiikSU jwDCbWl5QhijV4DV49c1euwBggbdWRXD7lwmGGQ74e3emk8XUtsxXmWSKlJjTP7Nt8EY r0ZAcstIgXnWTaEQy244devwWQKEJYH2tensY3qaZhoCOJOE+TO3O05NbjlQ4IoFm0KJ 6ASA== X-Gm-Message-State: AOAM5337wiT/TB4d97emKJGw6onPR7JQdKwD9950OgQMm7k9c6q/VokC gWEyE+KcgOqtQZxs8Cf48iu6AfsgoMtEoGLY7gAQC38BWYIQe320Xn1exPNRTz6o7+XgoXUWV8i cz/EnjvYsDVhIRw1Nt9Q8etr0vaQ= X-Received: by 2002:adf:e391:: with SMTP id e17mr15196108wrm.289.1600086566096; Mon, 14 Sep 2020 05:29:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+1/aFCLy9zZXQtB8mFgNA23Rd5h+C192n3Cb5/bsjdvKfJteU4hp00DAohSj/jPGHMiEVc2PHHrciAVdye6k= X-Received: by 2002:adf:e391:: with SMTP id e17mr15196076wrm.289.1600086565833; Mon, 14 Sep 2020 05:29:25 -0700 (PDT) MIME-Version: 1.0 References: <20200623052059.1893966-1-david@fromorbit.com> <20200914113516.GE4863@quack2.suse.cz> In-Reply-To: <20200914113516.GE4863@quack2.suse.cz> From: Andreas Gruenbacher Date: Mon, 14 Sep 2020 14:29:14 +0200 Message-ID: Subject: Re: More filesystem need this fix (xfs: use MMAPLOCK around filemap_map_pages()) To: Dave Chinner , linux-xfs Cc: Jan Kara , Amir Goldstein , Theodore Tso , Martin Brandenburg , Mike Marshall , Damien Le Moal , Jaegeuk Kim , Qiuyang Sun , linux-fsdevel , Linux MM , linux-kernel , Matthew Wilcox , Linus Torvalds , "Kirill A. Shutemov" , Andrew Morton , Al Viro Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=agruenba@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1C59A18198DA5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Could the xfs mmap lock documentation please be cleaned up? For example, the xfs_ilock description says: > * In addition to i_rwsem in the VFS inode, the xfs inode contains 2 > * multi-reader locks: i_mmap_lock and the i_lock. This routine allows > * various combinations of the locks to be obtained. The field in struct xfs_inode is called i_mmaplock though, not i_mmap_lock. In addition, struct inode has an i_mmap_rwsem field which is also referred to as i_mmap_lock. If that isn't irritating enough. Thanks, Andreas