From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17879C6FD18 for ; Wed, 19 Apr 2023 15:19:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76F1E900002; Wed, 19 Apr 2023 11:19:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71EC96B0075; Wed, 19 Apr 2023 11:19:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60E32900002; Wed, 19 Apr 2023 11:19:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4EED56B0074 for ; Wed, 19 Apr 2023 11:19:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D0AF7A0326 for ; Wed, 19 Apr 2023 15:19:52 +0000 (UTC) X-FDA: 80698500624.30.FD2F406 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id AF3B0C0003 for ; Wed, 19 Apr 2023 15:19:49 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SfXCPCmS; spf=pass (imf28.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681917589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tk4ILYUitykXDNv2nAhy0f5ydU+4a31pQqGhvmwhdPk=; b=aD29yk4KL4LbzfZcDSyajV9G1QCenSfoUOCz0o3ayfY8Y6TGHDZ51aqslgyTge+VMlKxf2 psuSm8c+Tiu2tEJdPWbaRsWVPkQIeJlZyji8K5nKJpi/NgFxuNNfTYySWbeA/nQx3CjzBb RmaJkjGGsuFVm/AFOYumjrNd6El5v9o= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SfXCPCmS; spf=pass (imf28.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681917590; a=rsa-sha256; cv=none; b=q+nNb49jYctiusAvJLQPfRLja5/6b7mvT/YM2iWIbIUwz54TQmVPgPcWjWIp9RQHMM6+xz M10TBk8IIjQ4+VTz+se1/gE06cw18v9nWHw83kzNLg4DYhCJoDsRFi8X/TKwk2ESbrnAhG s01s9TsjkLGxPluWH+/TB0SnA8zafbI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681917589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tk4ILYUitykXDNv2nAhy0f5ydU+4a31pQqGhvmwhdPk=; b=SfXCPCmS/qEtgl4HCphy0rtcN0wEu2hDzJxzco1ykIcqr+N9XPfLXHfe3282bh884feTxE cFFVcARYR1w5r7X7CS2To78UaeGPOsdM/MOqUNpfmwn4X/VFLqD2o1ScSsKYkptTN/UjMp 7+JIZmZbYRRwOBuGoVbiMjkv/lGYEOw= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-282-KZNlkS9tNz2nS_YqrPfMhQ-1; Wed, 19 Apr 2023 11:19:45 -0400 X-MC-Unique: KZNlkS9tNz2nS_YqrPfMhQ-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-2476a718feeso2035712a91.2 for ; Wed, 19 Apr 2023 08:19:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681917584; x=1684509584; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tk4ILYUitykXDNv2nAhy0f5ydU+4a31pQqGhvmwhdPk=; b=MI7/xvwqtftsb7SG0pQ3qsw/hspMUGy6Der91Ws46r2NQ1g0NvZWHlInqzUq5ftJSC HDLLwCeKCSVmPa2LRaznyiIXucpI+6i57ua54f9c7aJ/SkCH0pXvgKSR2blBFqYDqOSr CbbGQIURomuDBvu9ww893emj7GJnnxgk2t1MHQhpLyyP1uzMtlXEKCdNqkxyy47fgWsn m08eSPvlhS0/7N6MspN5Z+BnaK630Gnv98cUFhJz4yrQHsEvXHI2+spFFgvvjyqutIvs 5xx69wEGvCwUFP0IP6afFOZSkAMKc7R0RINuntE4h03O+267g34og5LdsPZ3tvJ08PAC yCYA== X-Gm-Message-State: AAQBX9fsnxJdtTxdE4RAWhX6MJt90uJcEV+g8psnsDWXzOsjtH46UDTj PpwjcOpbUx+2s7biW5BoQz/zQCm9Vxg84oup3jARKdPRveYYuvdJd6+iI6oXNeH+eTUV/qL8GL3 SeQgeqRw86TMwOGjO7rFXezMx1PM= X-Received: by 2002:a17:90a:2ca4:b0:247:fec:3cf with SMTP id n33-20020a17090a2ca400b002470fec03cfmr1032479pjd.9.1681917584684; Wed, 19 Apr 2023 08:19:44 -0700 (PDT) X-Google-Smtp-Source: AKy350ZilzTP35l+fCVfSRmyAr7TA2z2HByJ2c77EoLXxjUVlBIE5WaJ/vbFqG27YJf1gGuB7p5La9B7yskBhiQ6yjg= X-Received: by 2002:a17:90a:2ca4:b0:247:fec:3cf with SMTP id n33-20020a17090a2ca400b002470fec03cfmr1032449pjd.9.1681917584368; Wed, 19 Apr 2023 08:19:44 -0700 (PDT) MIME-Version: 1.0 References: <20230419140929.5924-1-jth@kernel.org> <20230419140929.5924-12-jth@kernel.org> In-Reply-To: <20230419140929.5924-12-jth@kernel.org> From: Andreas Gruenbacher Date: Wed, 19 Apr 2023 17:19:31 +0200 Message-ID: Subject: Re: [PATCH v3 11/19] gfs: use __bio_add_page for adding single page to bio To: Johannes Thumshirn Cc: axboe@kernel.dk, johannes.thumshirn@wdc.com, cluster-devel@redhat.com, damien.lemoal@wdc.com, dm-devel@redhat.com, dsterba@suse.com, hare@suse.de, hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-raid@vger.kernel.org, ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org, song@kernel.org, willy@infradead.org, Damien Le Moal X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AF3B0C0003 X-Stat-Signature: scm5ukr43io5byatkjxegfj8fqmkc46n X-Rspam-User: X-HE-Tag: 1681917589-317417 X-HE-Meta: U2FsdGVkX1/PZ5a6OwmCsrrvQ9OlaHRDnNdRpyEzQH8ERNmGAEqqk22JzmsR8DCWRjL85eUhk9q4Vv4z01LUkfnaGv8DA/BF6yf+76ka59pU88dQpT/kDUp+JkfBLApBd9ylOhFm1TTReDfL5LxDAtVrv6e6UNFy7+c+UU8YGbqL90bhCK3in9eW/E8dVNU1iUtOIyvw0n9rhZ0di/P+0z8uGXO3OWTH5rbh0UoWAXCoYyjhPXo3yB/9gVVyl8ge7dgC8luQRg3ro3dBtwbrSDQ/mib0XSvGvqJDQygLN28NE2H/EQmFZDXXIoPCGNLQY5cJqgjkgtHPBURIo2385/A+NyqAm0eneotGEPn6yuanRb+tU7vLKSddy1cJ9Dr141yX0llxx7orKUGv+q7sA/UyQHTVpTmIVFJ2yw++BdaMZq35GK0bGDKJvw+gB8Q+I0+7vTi5WnycUD9VXp+qW3m5PtzyyZqyRv8lyWd6YNyRaD19zht0YZwE9AAXYLAeZx3FKy4+rjCINWw/9P4P07L6EmXHnDTsrxvVXjtXMAO9fFdj8U7pUQVvqB/BY8W/p9LwtmmnxwosAsVbtcWeWzf4oJa+adD3c0hak1FBv3Ij+D7uuEigblkbJ5DP/Nk8cO0ZGXHrMteuEftnr6hkEE8+3l1Q5jyg9ea0l3/15/HNSOB4j7RYzFi5Fiuwnk4tUnoaWveb3FcxtAIfq8+wN9GaHnk4gqDTbSaedT6qRXdkkOgkr5JMg9AnBff4qztE35djWxxgP0KaywSRSZ3BrJSsftTgSTXpbNqDPY5o8ecCkSLsDitbyHwUwlDlr0d1wcSArfzXXxsiUwxxLOF0QP/LYELGYhtCmoG5sU5uveOOS+tMmstrSnxS8OGhWaOp7gZaTz0kyi6C71b0RSeKS+WYRcCFOpqQYXzGroxFahfDm73v6YKCTULD1tbw0buk2Clb3PErmr0kyDauFHZ Y7EDIR+S Qj22LQRKxHcd4L3/egHgoL4b725XpUzFvlW/nOKxYnLLY6IKwVdRuxVPZBnAdY4BgpJvy5NH2mWt+2FdRue1MbkLmm4Zl51V2T3esrEL9qbtvfMjQqJi+AoGleGopcJg6e6rNunTTXO6toc4qsIRBuGB8HDit0T0BqFogO19BlWvdDiXfUBIZ32kHW0teQRHockbHo0gtVr8pHo15fHercnn9nImMTS/CewA1MGtAGlKav/ok1SHQuIaDeODnopkACaJmQ5/rdFcraa0HX5GTfyov+UsqKt8suP2Kpt4ftrXHvO2VgP7VEbR78wY3ts2Paibpfx4CNaSuVPpv3g177r5JXkIJwjW4+usfnQn/jk2edEO+q/t2FZjCDvtqPKUUeXO31UiyF2qZAiVm0d60m9rer+F5Uy87oLmQit85+tXTbpRbXtzfzH2QD0U3MkaLJPi0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 19, 2023 at 4:10=E2=80=AFPM Johannes Thumshirn = wrote: > > From: Johannes Thumshirn > > The GFS superblock reading code uses bio_add_page() to add a page to a > newly created bio. bio_add_page() can fail, but the return value is never > checked. It's GFS2, not GFS, but otherwise this is obviously fine, thanks. > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn > Reviewed-by: Damien Le Moal Reviewed-by: Andreas Gruenbacher > --- > fs/gfs2/ops_fstype.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c > index 6de901c3b89b..e0cd0d43b12f 100644 > --- a/fs/gfs2/ops_fstype.c > +++ b/fs/gfs2/ops_fstype.c > @@ -254,7 +254,7 @@ static int gfs2_read_super(struct gfs2_sbd *sdp, sect= or_t sector, int silent) > > bio =3D bio_alloc(sb->s_bdev, 1, REQ_OP_READ | REQ_META, GFP_NOFS= ); > bio->bi_iter.bi_sector =3D sector * (sb->s_blocksize >> 9); > - bio_add_page(bio, page, PAGE_SIZE, 0); > + __bio_add_page(bio, page, PAGE_SIZE, 0); > > bio->bi_end_io =3D end_bio_io_page; > bio->bi_private =3D page; > -- > 2.39.2 >