From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE7D2C369A2 for ; Thu, 10 Apr 2025 17:48:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58A416B02B7; Thu, 10 Apr 2025 13:48:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 538606B02BA; Thu, 10 Apr 2025 13:48:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 401C96B02B9; Thu, 10 Apr 2025 13:48:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1F4BF6B0364 for ; Thu, 10 Apr 2025 13:48:33 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8CC98121253 for ; Thu, 10 Apr 2025 17:48:33 +0000 (UTC) X-FDA: 83318868906.04.609E5D8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 6469220014 for ; Thu, 10 Apr 2025 17:48:30 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Igoq8XiO; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744307311; a=rsa-sha256; cv=none; b=VqWxZslK/MQ2bt91Ck2aRUBc0ZEpizISbtVFb+6L1oY9iluExpwMuxxN1Y2eSA0+iMStRz 79BTOKWiEzYvC7GYh3jREGp8Olybp66HlRErfKGD2FPcxZYF3qrLaQ7PJS9PAMTqsXDnul BzEgkvZW7QxjuE8PzkuMx+5tEGkibK8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Igoq8XiO; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744307311; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OqvPNxA7jww3BXXOwYN/gaN85wuxZPgfj7tUlo1Pygo=; b=GOB6+2xmpzyJp56ec72tiTYNffSnpOoVWts8YCWfFh7fHRZuy+2V+hHi4QAnc+N3bl6Q1E PFRVR1UBa0Tn8Id08/UKs2BZlNPPixaQYdhEHKZMWQsxAsSsvUgMbAHBqm18T0lDJrIY9l Hsz+FECAADrt11AA1/qxAlq1zc1jI6I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744307309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OqvPNxA7jww3BXXOwYN/gaN85wuxZPgfj7tUlo1Pygo=; b=Igoq8XiOR2jq/FzPAumA9aWR2qErCcMAyz6s3JlB9EEI4xDcCXXp9FEdmEi/q0ByLxeCJ9 ugiRj3jejH0O45K8chmG0RU1PgDuCS6jq0OUWLSShyW2GQVerQADXPh9B7ZVd094OxVD4N mMvEApChBM5BEhJlUHv+cNdLWwbPjvk= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-nXzPFIZVNcioi5FZXQdc8A-1; Thu, 10 Apr 2025 13:48:27 -0400 X-MC-Unique: nXzPFIZVNcioi5FZXQdc8A-1 X-Mimecast-MFC-AGG-ID: nXzPFIZVNcioi5FZXQdc8A_1744307307 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2240a96112fso15554505ad.2 for ; Thu, 10 Apr 2025 10:48:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744307306; x=1744912106; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OqvPNxA7jww3BXXOwYN/gaN85wuxZPgfj7tUlo1Pygo=; b=nfUvlOYjdHcqG9Zea738wpEz0tqiW9hvPGiWlGvc/gPcnc7SYJdCfwXjvBecWDB15U opD9yNdlbmBcrnUfY80rNLq7xL/f1A8FzryIZQtFp7FaZvJNtJmuN6Puzt4RbFNJ+p/D xqyF2Y93WKl+d1yBtH6yJVuEb0K4PazHot4AL558TAgv8SBk9u9f41wBNRiJ5T44HICS SK7Di2Q1umrHBl3tQRO4QYKi7l4U60IqXk7gFGZwM+ooJBVKm7HhzQB4V0C/ZTGVlHtC x1GWObPBOtBq/qLYyxOxp061+VkRk4wrfs3tKNYZIsQdb2mft0HfGZUS4OkIrVje0Qkp yjTg== X-Forwarded-Encrypted: i=1; AJvYcCUQxDaZ8Rsm21aJdJmh+mulb/cHkL5IEGhnk6olQEmy01ohhtzyDOT0ECThd5w2DXCLYst43Lo/wA==@kvack.org X-Gm-Message-State: AOJu0YyQ/LU9DR629Ewdqq8sXdrfXCYJ+wrh9dcZJHznQ5uENPMWaASO CDO2UHes33AbSplqQjoEj7prUCDdIeUh8p6UfMmQI8/tlUwLpwGCaP+FbekmJXEJm4B664FEjUv k4HSvRMLPDqyW/6Opy8n5kD1W+FeYHof3/esTsVX/OZBIi8ncz5HuoPG43ZicfhohbCbk01S4tc EIfK7Rc64j6zQd5M7bko89nX4= X-Gm-Gg: ASbGncv/uq8fLEhv3GVF5qSi1gEDFI9nNG2i/Lzoa8W9xQGws4VHvt/C5w0IPRAjy94 AEjB2nagXmgiC5O94XxOr0E5ElDpQdXXk061iLM/a8hJ0QFRa74qsdbRd0fHNo/9sUpA= X-Received: by 2002:a17:902:dac9:b0:224:1579:5e91 with SMTP id d9443c01a7336-22b42c5ac2amr51880125ad.47.1744307306759; Thu, 10 Apr 2025 10:48:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUo1DbI1h9w9OLlDnjq5RZSX9CGytc55kczInpUMCnGZepk9T1FYX3YU4pw1A+DuQV82ASCx1d3eK2A6PEVwk= X-Received: by 2002:a17:902:dac9:b0:224:1579:5e91 with SMTP id d9443c01a7336-22b42c5ac2amr51879845ad.47.1744307306483; Thu, 10 Apr 2025 10:48:26 -0700 (PDT) MIME-Version: 1.0 References: <20250407182104.716631-1-agruenba@redhat.com> <20250407182104.716631-3-agruenba@redhat.com> In-Reply-To: From: Andreas Gruenbacher Date: Thu, 10 Apr 2025 19:48:14 +0200 X-Gm-Features: ATxdqUF2qSG62wdzI_CXx71qpQw7c7dGZziC1q7bbQkSEqifIFryfqrjJnWzITo Message-ID: Subject: Re: [RFC 2/2] writeback: Fix false warning in inode_to_wb() To: Christoph Hellwig Cc: Jan Kara , cgroups@vger.kernel.org, Tetsuo Handa , Rafael Aquini , gfs2@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: q85lMRG-eY_UGTlNx1wfTQF-JIPxJhoohPGxehrJkPE_1744307307 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6469220014 X-Stat-Signature: encc7rufdu9ijyiphyutxn4j4fepdr7z X-Rspam-User: X-HE-Tag: 1744307310-898955 X-HE-Meta: U2FsdGVkX19pnrGdw4hzo5FiCTxEKKvShS699buuqfmg+rIrmHMvWjPQHft2LB1WJBvV+BddjJg/Q5ClE8ra+z0mn6f29YLmBlknBIhUQLDavIDHKzah7WHJAI02yYp1pnDg6Se2OquwYEn9PCgr7004tKDGPp1v8bz2MIZ6XRB/olDgTHift+U24NNhXUhXt+Q+OL1q9EQAywJQuxUf+Atq9LE+TKwt3yIfUs/27Amc27X73Us05O2lmwyjrThCK+8/g8eV5U0Xf/ybCh3lVs9ZfvN5OFfgpIYjKKxtHS0i+hUONRKti1yq2gRQuvTHBWdck3xcNNFvrYFkt+/7F5G/9/W9t4jLQh7+yHWISQ9P14PrUmdDYueToW0RVMNnGiiMByNcvgX36dkpd8B82V8nJlF1sqPHmbCUB11MF8a2wWuWZxMgGLitWYRApcMNV6GVV5/lvjmrF+WkuOiPGccWqTYIJ4Bnj19vOIckt0DrYaNNBWJQ+NBfAq3hZBEnSMqrH0oJI6rrdLbBjvRYgDRfWF4ao8na0m1nnyOTkj5DGfyNPMKhUh4MHF6OHaIxwopKzB8NGZQ+2+9Zsyfr97f7N03vePvPToLmM7pglGEY3xaAdFVTuSa3IottgftHvLY5W6SGS3uQCPB7v+QQtWEMppXQ3BY2l0QO8Dw7O8z+YXXQ8FxJBnD30HJ1nTd93sKvPPeTDIZ9BVgd239KaKchr5zTIm2BCRhwbuY5OdFIv/BvIooYLbxV7ovYxBB63gdcSZU57y6MQnOU/oDs6iyjPMg/4HFgdcaRATEh7lLF2rh7GezZskXZLJFfyhA+Pm6LNWhJylQJT7wQykpXIngh4hg4zmc0rsDy8G8pTQCqg8YlkN2T4s6AuPaYvj2JYq86BhvyG4VTMml5XRs8xJ5pMNZC1RXH2K5AC1yBlQ7T8a2gAsM/dueVtVA0vY9cTV/KkzrjiyYklYlVhvE NP/glADb w9m10bsKdQFvKXfIpB+HnP2LFQYNgYdWsqRT+ou5Juzk5O/BWvN763giS+HYeAqXzA+Ayuchw9jj7glXUsMDo10Mvw6XTyPTGp7AUuIJUCR8g+VWV7aGJXLjsBfBc+4WmTqNvorEHuEaSerAXac5e2RbNUTT2VKG0q8HUuYwE/svfYfpLxeegyORtN13tNvlXZDDfEwmZxd7VVLD9t3pMthYFWECU3eBMAgL25LAWTqMtmmphh2So2oIBHHNAoA0J33Sqc13mUt1aVjL48Yr9wGg1mXlnEPE8vvUSVbBha15r9BGKPqCROxyoa8vvhQo8Xq96FEyuUK12mQskBGsE5tMVs4zpF4onSmSapjccUysZ5WfSAPLeU+9JS1+k7oTaekdR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 10, 2025 at 10:52=E2=80=AFAM Christoph Hellwig wrote: > On Mon, Apr 07, 2025 at 08:21:02PM +0200, Andreas Gruenbacher wrote: > > -static inline struct bdi_writeback *inode_to_wb(const struct inode *in= ode) > > +static inline struct bdi_writeback *inode_to_wb(struct inode *inode) > > { > > #ifdef CONFIG_LOCKDEP > > WARN_ON_ONCE(debug_locks && > > + inode_cgwb_enabled(inode) && > > (!lockdep_is_held(&inode->i_lock) && > > !lockdep_is_held(&inode->i_mapping->i_pages.xa_lock= ) && > > !lockdep_is_held(&inode->i_wb->list_lock))); > > -- > > This means that even on cgroup aware file systems we now only get > the locking validation if cgroups are actually enabled for the file > system instance and thus hugely reducing coverage, which is rather > unfortunate. Right. Is checking for (inode->i_sb->s_iflags & SB_I_CGROUPWB) instead okay= ? Thanks, Andreas