From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 111BFC3600C for ; Tue, 8 Apr 2025 11:20:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3F046B0006; Tue, 8 Apr 2025 07:20:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC2566B0007; Tue, 8 Apr 2025 07:20:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A61DB6B0008; Tue, 8 Apr 2025 07:20:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 84B276B0006 for ; Tue, 8 Apr 2025 07:20:15 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B934FBA5C6 for ; Tue, 8 Apr 2025 11:20:15 +0000 (UTC) X-FDA: 83310632790.15.BBCF7F4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 5E11F4000E for ; Tue, 8 Apr 2025 11:20:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JW1B0Flz; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744111213; a=rsa-sha256; cv=none; b=lUvSlx4xc5yRAlvKGKK/whxjmaYoiNXVM4HnqjIruCUfC6A2nZscxsXrRKPd62Qlpv3tNU tDMJQMAwL3AwNT2yML0zGE5MUPThDDEWSJuwpcoRqDf2PrECYR0VCZLDSm0FXSN580eve/ UV/2Ol+0ePwtiMXm/yqjjCLGdZEfLg0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JW1B0Flz; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744111213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zxlGUJtYElxMWl8rsjV0NknW3/JmIWt6QA0dt0dS8Gg=; b=XSIYriIKOAtU49sEUDt3drjzS0PzmhtI006XlQL2KsgUpzeGmQrXpP4qxHFLpDnwJtn9AL OrnZ1/PET8bIxWAkIz+ghd8l2A0TJ9pEDoZ0PWEkKKjIBxawpFR9Ac2bNjKAgmK5Owrzv9 oDaEiJtWZS/DE+690bJsNeRk043VnW4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744111212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zxlGUJtYElxMWl8rsjV0NknW3/JmIWt6QA0dt0dS8Gg=; b=JW1B0Flz1OSNpy2Le5EkHFwUS9EKwR4LGUPFS9n092VG3/QYVUMo5txyTkYwLI/h+C8p80 yt48+ic/dgyBXelwB/+qSaabb80oJXUeJkEQPkvY9RMaDGhrFk6QND08fpPzQd6d+D1Ktc cT/1OYdMTmpLb3PIXh+Xl0w/FwwMXDQ= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-fvEhxb2SNmWfp6oJqV85Kw-1; Tue, 08 Apr 2025 07:20:11 -0400 X-MC-Unique: fvEhxb2SNmWfp6oJqV85Kw-1 X-Mimecast-MFC-AGG-ID: fvEhxb2SNmWfp6oJqV85Kw_1744111210 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2242ce15cc3so49639675ad.1 for ; Tue, 08 Apr 2025 04:20:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744111210; x=1744716010; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zxlGUJtYElxMWl8rsjV0NknW3/JmIWt6QA0dt0dS8Gg=; b=j4ynx0HiZCgW9koHMJQ8gKGgpAqlcIr6MWivgNh5dyaaU0CpH9iS/vdrFJNugvKYuX 22swSfHw4beEIyDW4y24aiZ3AGyLH85vSzOdxWdvXFAgI1ehwJlquOhVnMcV95GE0r/L ZxqF1IfIl1A9aQ3Xql6E2EjvfQc8j6JXQGFJNzODpAeoC1pnas0JPzoIk/YIPdRu2XMX I/lwH0raajLYhnUm/1QwbCumYD7Uz9pYoQRJtjiK3ew7vzYePBabcE0w3EaK6wcx+QII biwTN5rJV61I/qpdZriFMyyUcqKi4L7pTfMSaieXsm7r1ofeQ2Gy78jf6rMuNUNBVb56 bzhA== X-Forwarded-Encrypted: i=1; AJvYcCWAygUD238D76r1T+rUUioj5MBKiRFN1sKVENjeezmkpnQWefFZMKJO0qWZOJlgBqJP08MOeeB9NQ==@kvack.org X-Gm-Message-State: AOJu0YzYoD/y4SCtzTnJ2ZutmSiu2Y8XfTfvdSePuxRvF6A67Pj3CRMD AfBdOiEAPX2twwbjlHMSPmDbbydCxyGV3VYxisZOzIqZKVu4G1d2nBTdt3H6xj2qzCTrrHAoMoq BDggqOFGrEuVzXgltSh66sytoeCZUHlf/9ZESz3iuZbpyCI396fb4jHDk699uS+7RQTwgHKWFEy VTRrn1t6OPR84UP7HelzkB+JQ= X-Gm-Gg: ASbGncuzuXqvHcw5m3G9/r+16bqno01QiSrW1slCNosRTTjp02+IBG3fGaQkZaG6w/o stVZMs8KV3TUn3ENtUFhUbED/yv/jij1NVqoTKXA/OrLctXCELtQlgpE3rhFQJIlfLvcPMVU= X-Received: by 2002:a17:902:e809:b0:220:cb1a:da5 with SMTP id d9443c01a7336-22a8a8cec34mr238988835ad.40.1744111210548; Tue, 08 Apr 2025 04:20:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGfj3NzNQEOef+4bFL5S7xAlawV84jImrAOEcndKQ7zZiAPCt7WHwsWtCqW95u4ZSL3aeAqCFB/AGt6ESaJB0M= X-Received: by 2002:a17:902:e809:b0:220:cb1a:da5 with SMTP id d9443c01a7336-22a8a8cec34mr238988485ad.40.1744111210268; Tue, 08 Apr 2025 04:20:10 -0700 (PDT) MIME-Version: 1.0 References: <20250407182104.716631-1-agruenba@redhat.com> <20250407182104.716631-2-agruenba@redhat.com> <77b1b228-3799-43e3-ab30-5aec1d633816@I-love.SAKURA.ne.jp> In-Reply-To: <77b1b228-3799-43e3-ab30-5aec1d633816@I-love.SAKURA.ne.jp> From: Andreas Gruenbacher Date: Tue, 8 Apr 2025 13:19:58 +0200 X-Gm-Features: ATxdqUF091z-QTWG4loZUeytMgFUpudH-__g8f1MG4U6oA2wpIwWgfAYKS_mKk4 Message-ID: Subject: Re: [RFC 1/2] gfs2: replace sd_aspace with sd_inode To: Tetsuo Handa Cc: cgroups@vger.kernel.org, Jan Kara , Rafael Aquini , gfs2@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: H9QsKvmuS-jJ3o5YllathAG7n_BkB-N9aa2eh_PJQIM_1744111210 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5E11F4000E X-Stat-Signature: u1r7jg16r3hkj4ahjzn93i8h61jpb7pb X-HE-Tag: 1744111213-757128 X-HE-Meta: U2FsdGVkX198eb+qZukqj3YXHFe/2yWIrOVeocKs29125LTwv498XCL+DpXanygpni0ZNMlZZKfZRta/DsxTky9s/sj5iV0/7xJrlR3h0kO46wmwD5QWXuHz12soRRa4GpnizI5ViiT++JT2JVZ6qkJ4xgTA1hw5JbY7pa9l1ihfohyGFMEnk61hFVugzYlc6LpGKre7eqKHFqHhEY+ky/gDswgTzBVdSP6GReKUD5SxqdUldRSFdDRhA19dRaNsM1iDATmVkeWCHOgIdyDbWJuYTIOU90qEXImwJOhPQKFcIDIW/+blPAlink1+Yic01qJH8tRoOraET6OUHeqmkpt2q9cMPEof3mD5YtrzEy31nUYZA71CFBGqXRpi8DRZ7TuM9o2A0SH+h/KbvHygnyHSNVznrejK6pFpMYZ0Iw/PovAZkmd3Spn9ysKqULEaIolSUueWAAXbE+3zeTFiRwvCa0K70rEeA8BqSvcDgYFjPb318sSUQSM2WIXOJIA4ftCtVVVjxV7LHLi5LMOH5SrKGnRF6fizJqr7foic3RQbiDfn5t7QchUyzR73kCLNr56eZtNQVGKEbXZpFCQWlZayInCPuc4vyKu6cNM6je6A3XEYiD1ip3GxLnIaa+hqR4y+5IizZHku+a1euNQm5dqUkHu10cpjRApkfYo+aWF9vK4EYR/UZmXSpM9bG3gby2LXwhetM7jSr5HPFsI/DIppJZZoL9XViaBPgq6lAe2+WtYFBt+Hp8HPLQPzY53pgTLBj+YnLaI6C4q3AXJlHuA/thACRKt35UBlcFbvFbc4bKndmEVJ+Hn7r49pSuN+9ST0uhS97inSiiyRHTTUcQbcqmmKWKjBDLHd2sURfkLLzyKWrWJGJ6cmsrLHufuU/k6Hzq5e43qsFV5tfLXf9khXRDPbm/2/r2+fuDDK0/uL2Fo8nI7UZG6KBwWaMDuX4mWcroudNtllO8p2WWv LJQX6Ult eNfDbL3UJd2h+KHC6E2Rej8EVonT7t8YYXEwbPADkMpujWuhqwWyzQSevHECm2p/byOOfNUswF/xxASQJPeAy0RzM5xL0rEpnvufDn+0fCUSjsZKZymWy2GiRf8vw2AJH9zJuuxx64rSlv33knJgF7wIzE8tRyn/+Ocp1Afp8kIPVWQMsWpgn9eKgBx0z4X94LIT+KdZ/jC3mR312wlj2TvHvPZs27PPzlkAE3Bp+a/x9dCrwFjMqe2fKsIVUwISToQH+2jY6LaQGYkRx+h0JeTsRVBcUE4vtR64/FJVV2yADXws= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 8, 2025 at 8:04=E2=80=AFAM Tetsuo Handa wrote: > On 2025/04/08 3:21, Andreas Gruenbacher wrote: > > @@ -1156,6 +1146,18 @@ static int gfs2_fill_super(struct super_block *s= b, struct fs_context *fc) > > sb->s_flags |=3D SB_NOSEC; > > sb->s_magic =3D GFS2_MAGIC; > > sb->s_op =3D &gfs2_super_ops; > > + > > + /* Set up an address space for metadata writes */ > > + sdp->sd_inode =3D new_inode(sb); > > + if (!sdp->sd_inode) > > + goto fail_free; > > + sdp->sd_inode->i_ino =3D GFS2_BAD_INO; > > + sdp->sd_inode->i_size =3D OFFSET_MAX; > > + > > + mapping =3D gfs2_aspace(sdp); > > + mapping->a_ops =3D &gfs2_rgrp_aops; > > + mapping_set_gfp_mask(mapping, GFP_NOFS); > > + > > sb->s_d_op =3D &gfs2_dops; > > sb->s_export_op =3D &gfs2_export_ops; > > sb->s_qcop =3D &gfs2_quotactl_ops; > > This will be an inode leak when hitting e.g. > > error =3D init_names(sdp, silent); > if (error) > goto fail_free; > > path, for what free_sbd() in > > fail_free: > free_sbd(sdp); > sb->s_fs_info =3D NULL; > return error; > > path does is nothing but free_percpu() and kfree(). Indeed, an iput() is indeed needed in that case. Thanks, Andreas