From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E60C369B2 for ; Mon, 14 Apr 2025 23:18:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF7642800F4; Mon, 14 Apr 2025 19:18:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A235C2800B1; Mon, 14 Apr 2025 19:18:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C5552800F4; Mon, 14 Apr 2025 19:18:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6578C2800B1 for ; Mon, 14 Apr 2025 19:18:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C39651C8F7C for ; Mon, 14 Apr 2025 23:18:55 +0000 (UTC) X-FDA: 83334216630.20.C947DCB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 7948040004 for ; Mon, 14 Apr 2025 23:18:53 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aWCYOHIP; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744672733; a=rsa-sha256; cv=none; b=N1Un4YoPsH08RfYUbUNPKI56Mvcnzm7O1UYasycQTBjfaMUIpwOf0a5j/yKbN8uD1vtn/D JtY+xYELlMdky5qhxF6q1nrgLFGIS/salVfqvKKOyaLv/oPuk6BCNwCSvI+6j40HpjOuXp wgtKbKXI/eMPMRuqHJVLmElbR5Ouv4s= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aWCYOHIP; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744672733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qaoK7poL4lFt0zzKd827Q2KBVOP06dQDJUh2ihDBMGA=; b=0MJPv9SABWrqHuq1d/T4NxOS/LMiAz5kk6R1SOTPNhTygab0crZItumry6uJkODxNTJiTe 60cCsfHhzrjuhh5QQavUubHPh235PYlvZLmFdbn0NYCRAcvp3QhlEY0/VzmjrsLIUWjkZL Q9Bjprd1hM4MmsRu3c27UzBKCGS5tSM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744672732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qaoK7poL4lFt0zzKd827Q2KBVOP06dQDJUh2ihDBMGA=; b=aWCYOHIP9idtg8DWBhWhbzaCK/LD/4jQxJoMSdhUtm7dMsy7KfPiqWcrvnC6UHT60eH94D CpBqMSaYG1Xj2kx518kQ4Pf7La4hJ6xM+1ekFgvAEwXsJbv5j0EKWfSwXAJfKkuCYKmVqy Q+ZEc5NwhhBhzzTxb1SQhC9ueT5f1UA= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-164-TSLvSdtdPWmqnBPPYv5jFw-1; Mon, 14 Apr 2025 19:18:51 -0400 X-MC-Unique: TSLvSdtdPWmqnBPPYv5jFw-1 X-Mimecast-MFC-AGG-ID: TSLvSdtdPWmqnBPPYv5jFw_1744672730 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-22410053005so78678995ad.1 for ; Mon, 14 Apr 2025 16:18:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744672730; x=1745277530; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qaoK7poL4lFt0zzKd827Q2KBVOP06dQDJUh2ihDBMGA=; b=lF/UMgLP/56ZTdxX5tFj+uvr9T0yTcoJpvWhnoeUFHwp5Uvwj6AN2K4ZIV4RTsTnZ5 FM88rRAf6ETvrka7CWLX48uwQjGyMKmIQNBI9zujcJxdKRNWNL5tN8yrT5bpeNeZ7rUx IzTcrxmSMyhdjQoI9jOjgG0nzQ5656MHlPOQ5Cln2B9c2fKGhWBv1TrH7qaPhKXg4onr a8KQASJJ980DG81BL3JxfYHWgu+601g1b5wVnNE3FaFNEFGpaHnsUoEN0+dJAhHAarLk fpiw9KujMGEU6vwulmsz7UbYutW7DEK4r6KCe7gk5eBy7AjutSQjhLWvK/3GEDkZRm2+ /kEQ== X-Forwarded-Encrypted: i=1; AJvYcCVXk5jW6wvanBB1GyZ8UNSRc8zZ6jfUs+Xk8N2+4IX2CVQOWgjeaIeRQ1v70A9jex6cDU2i7Bc6Dg==@kvack.org X-Gm-Message-State: AOJu0YzyGbROmjjHdyYV6x7slJaPk3lANV19ecG5Sxgpeb4qtAAvxcTY V3Dh6uKeKkPCxj5ptP8KSmFSYcEKEhaV/OkAm5EZ1d7cwlMbHq4MxB1rRtMaITEBv59UtT8RqFz gOXky8LWFKr2a74qz0yth4co0prFTfZP3lxV3a6/8Vq8NXtbFxwbK+UFwdxgTX4tZ/r2p40KdiY QSobB7U5CUtDOmyGao3UbCMlc= X-Gm-Gg: ASbGncv7x7HrRO2CUgsF7yAWefeLiTauH+mGhsrGKvCKzAVCy97ppnglkJeddiB+MbV s9zi78ZLCeF6hOMhoXH7FzRfH2YlTrY0anLudrDcBaoctkhwDAMCM5E/P5kjcODGkztE= X-Received: by 2002:a17:902:d481:b0:220:f59b:6e6 with SMTP id d9443c01a7336-22bea495687mr151860745ad.8.1744672730487; Mon, 14 Apr 2025 16:18:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTkx4rzJcGUvdjR+8IkBuWXjpb03TgR9MDlGC2OL5q8ZwLfz7AdIcQ7zVCufAPTrl8j8sJhif/5Ghk7BA8IQ8= X-Received: by 2002:a17:902:d481:b0:220:f59b:6e6 with SMTP id d9443c01a7336-22bea495687mr151860555ad.8.1744672730227; Mon, 14 Apr 2025 16:18:50 -0700 (PDT) MIME-Version: 1.0 References: <20250412163914.3773459-1-agruenba@redhat.com> <20250412163914.3773459-3-agruenba@redhat.com> <20250414144741.56f7e4162c5faa9f3fb5c2a6@linux-foundation.org> In-Reply-To: <20250414144741.56f7e4162c5faa9f3fb5c2a6@linux-foundation.org> From: Andreas Gruenbacher Date: Tue, 15 Apr 2025 01:18:38 +0200 X-Gm-Features: ATxdqUHmoD9wBQhxdgcyUd4MlED8R-VRCkPirnQXdbKIxEeeDfOLknsoCdUpMs4 Message-ID: Subject: Re: [PATCH v3 2/2] writeback: Fix false warning in inode_to_wb() To: Andrew Morton Cc: cgroups@vger.kernel.org, Jan Kara , Tetsuo Handa , Rafael Aquini , gfs2 , Linux-MM , linux-fsdevel , LKML X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0twFU-syjLgRDXXTPd06fFYGFd_9K2PS8hOdTKriqDY_1744672730 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7948040004 X-Stat-Signature: kczazinnd5i6cjtbj7xbd684aewzxcmn X-HE-Tag: 1744672733-115622 X-HE-Meta: U2FsdGVkX19IAj97UEo9AFTSI+nP5f4bf/Q88k2yorA3l7PYNtbPno/UdqbGDhoukl9Qvw4RLAkC52ih8B3VMrLw3zjEBSCGANaIpqkdG3l69vHsoApVLHSs4KfexsTs/gGmq+/AUvkFl9k8jc/I7yAfM/SmhngISkIDSJqPge26iy2QPc/ZbdasVndng9lFFRsDzQKb6av/3VPO6d4ixW04H14fIieXy/AIe/EBqhLKeM516bYKs/RcSaKTwAiypnUkE9je29okyrTbT8qAHX7tPqQS1jeh1Z9dWqMxtu48WEpY9RKNBr4vRiR7Mr6wLELGF8m83kpgz2hssPlkKq3mWC86Sp9QQIOSVG6xmXQQ2fbnHipHaDjR8GR9vodAg+EmkiuBlQRPaEwp0lpP8sneYyOa3VMQbIa+W6bIq9WE1VKcRMROVMZaStWw85gzSQjl7XzxamG7xPK24DGQhZxnIqVENVGCdv0ERahm3O1weAjm3Ob41DUChxnwIzLaH6gh/r+5XfBTJXFiGVAsyYpa67vdhbMUJOk02I4D6WZfl2OzYZQLl1WeoTkR4a9wmsa/8yDWAzivsw8u9LOccQujnIgoj8EpXPti+7SkTcRQU6YZ4rtQFzYeLiFmLfaL63Q0JXYQxEKXesXIANRT7PFMzxyDbKs5AyqpHNmSMa7WHi+UwZCwazg03kGcbWC6myUpSF8NHzWnlJMDc8drgqxtH6tjPEO/EgGdOI154kkTY5/+zxm4/lFFeLjarZFVG11WE/4q2RWT5DmzK+Ci3aJOeRYdhaE8kV9fGgAbYBD3baHUS7N+KrLGdoxNMnppjGNWGETmoiqA9x4IJhENXXBpsyYMC7PkdqD0IN9UibVYPWWn0co4VoIztbunszjrTkMwmyuGDIcfXQrTM/jED8k8GNld6BKWTGdWjiR4l2XtqUPcmVz8xRYTOb4JX1K+QoojKyYeFLVfZaLYEYQ x7lGtf6p 4awb3HyiqsW44vEJGuMwHhMOiU4iyWC0WwS61zyywpP4DM6We6yL0RbC/8h69RVQR2FBXn28fc3p47NiFAohmome2CaBl3zmJlVolnHy7Lsg3wtPYNCARki5ktn3XSypAbYEZIb691yJLExRilysMlE9AfOWgJ6tP3FPaNO/osEShRWCygqnUULBaoHK9HT9Pe5j0sulVFOQJ8obzIVVnTEUhLEWzPVoj5wS9EvS5rPXr6LWs7s8/GcaiShNMprCDLvk5v83dByfGXsUjwIcuFDh/5IrleQ/rpBheE0HLuCXS9o6k6ZFz/7zo2SdHRFGbLkNMYdd8dMJu1PEvbXwItIrpGf6VQunxh/bkd0shSV0cY/FSLvLA9yfc2wUnskW0CudToNY7jONXbo25kBsiXJp9Dw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 14, 2025 at 11:47=E2=80=AFPM Andrew Morton wrote: > On Sat, 12 Apr 2025 18:39:12 +0200 Andreas Gruenbacher wrote: > > From: Jan Kara > > > > inode_to_wb() is used also for filesystems that don't support cgroup > > writeback. For these filesystems inode->i_wb is stable during the > > lifetime of the inode (it points to bdi->wb) and there's no need to hol= d > > locks protecting the inode->i_wb dereference. Improve the warning in > > inode_to_wb() to not trigger for these filesystems. > > > > ... > > > > --- a/include/linux/backing-dev.h > > +++ b/include/linux/backing-dev.h > > @@ -249,6 +249,7 @@ static inline struct bdi_writeback *inode_to_wb(con= st struct inode *inode) > > { > > #ifdef CONFIG_LOCKDEP > > WARN_ON_ONCE(debug_locks && > > + (inode->i_sb->s_iflags & SB_I_CGROUPWB) && > > (!lockdep_is_held(&inode->i_lock) && > > !lockdep_is_held(&inode->i_mapping->i_pages.xa_lock= ) && > > !lockdep_is_held(&inode->i_wb->list_lock))); > > Is this a does-nothing now GFS2 has been altered? > > Otherwise, a bogus WARN is something we'll want to eliminate from > -stable kernels also. Are we able to identify a Fixes: for this? The excess warnings started with commit: Fixes: aaa2cacf8184 ("writeback: add lockdep annotation to inode_to_wb()"= ) Getting rid of them requires this change, together with "gfs2: replace sd_aspace with sd_inode" from gfs2 for-next: https://web.git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/c= ommit/?h=3D a5fb828aba730d08aa6dec6bce3839f25e1f7a9d Thanks, Andreas