From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A27F2C369A2 for ; Thu, 10 Apr 2025 19:20:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C779E28012F; Thu, 10 Apr 2025 15:20:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C04CE28012D; Thu, 10 Apr 2025 15:20:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A81D028012F; Thu, 10 Apr 2025 15:20:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 871B428012D for ; Thu, 10 Apr 2025 15:20:19 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A394E140906 for ; Thu, 10 Apr 2025 19:20:20 +0000 (UTC) X-FDA: 83319100200.02.C3588E6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 5E2CD4000A for ; Thu, 10 Apr 2025 19:20:18 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AKl0sbvL; spf=pass (imf12.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744312818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7qyuCy71sNM096ptCCI9TtV8xzN/TLmJLvM6k58//nE=; b=2LXgq8LdIahDtkay8H6dheHdF5vKFy9b1wUow2KS4q5b7WS6bTVBuCHHgFRRj/2QxSze1A 0etA2vtcW+MFzBRl9Ns950eZc6gpH2jYivU7I/JStdWQToNO968xF0MlzsFuSIAt6gPp+9 ZPsTKkX8fcQ/546yuLoTg7cvpTwuHD0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AKl0sbvL; spf=pass (imf12.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744312818; a=rsa-sha256; cv=none; b=sCdR+ZaSFKeu+App5P/U+h7pVAMyt+KAsJTtbpw1oz4k2q4TWpRjHwO4cWTyTW65L1v2ij kvF2HqTY/uL4ruxBZVSo7D4ltHOsEo/fuRR9C40Vdo/LSUqy/TekGshUE5g2nU+QWrQ0vf KnlEFkJUwRPhpwQHKwjdCZxa6hZgZtg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744312817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7qyuCy71sNM096ptCCI9TtV8xzN/TLmJLvM6k58//nE=; b=AKl0sbvLTqSfaHiwBrGFiZXPzgz6TrDW4jFZVydZQfNXV2qFOwbnZnk3NqxSWL0QbzHzZ5 x2YKKyE1jQ2MFR1BQypEqMb08hseDTX/xilnT4vfaLbF5ZlLIpPXSTbcttGfr2tQ9EobS9 3Q8PYtYhSF5RtHgXByyTZ/l6n/6U0DU= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-k-25yQNaOhy8_L_w0Sn_EA-1; Thu, 10 Apr 2025 15:20:16 -0400 X-MC-Unique: k-25yQNaOhy8_L_w0Sn_EA-1 X-Mimecast-MFC-AGG-ID: k-25yQNaOhy8_L_w0Sn_EA_1744312815 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2264e5b2b7cso10704015ad.2 for ; Thu, 10 Apr 2025 12:20:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744312815; x=1744917615; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7qyuCy71sNM096ptCCI9TtV8xzN/TLmJLvM6k58//nE=; b=kR9OGCI43xbMk7dMItq6kZqGvRcjxChIWbENWE8e2FnAHRmDhtvgDBBOwrzhM7Uh3R fRnFm2vhz61irbSGxHxshATCrUs8P9/xtsjx16XEHzJVg9VAIUM1t6uPJ17L3YGMC8hI 974pKNOV4bhCI97GUNlrCjBvFIxRwYsATvAKZDhbntQ7g08HdVz2xwyxDOk3iGFoxf8N 8rOkdoVNoR3Ukuzo5/6Qakcz2WSDPzT63HJGeyZZAl1qX2MoKH9PqEwwBhGSI3fLn0ve T9u4ZXby+Zl+E9PiI97uJTryxF+zrOuTqFfdDGQnj9MqssstPljvGlrSuJskVCqjmDyA ij5w== X-Forwarded-Encrypted: i=1; AJvYcCV/K0d4Dlo/fkKwBtvBu9AO30SXziKhW5+UpJcuai+y2TOuMo0elwpRossu1uDWljHTtx00HlYAbQ==@kvack.org X-Gm-Message-State: AOJu0YzBgIjIGZ5GfdnqAdvha4vjiFrl/AblPjJVC/pbGBFTjDutAOTf rPtlTVAtoHamINFf44vN9dtSJMeYQ5++/LvnEXh3G4Pk6o4oV44np1DOqAqDzfHJl9klGd8htm1 K650B3WHCq/nkGSULJwccnhYEVGqDbdlRpAxxka1l9dI/Myt26HI0Ry0ALe7iHE1fGEhtsNdewz SlMHhk3+qWY/HP8srT66YHpS0= X-Gm-Gg: ASbGncsekK55c5ud2AyCB02f/lz5F5w2zLRMlrgmSx/grfLeFJwSDQld00bx6uDhLxa YpUSw2MfpZUXEv+Y+uldCIgMBKqsCIMnhTsVICOAAXcfsXRgN0nngSCA1KtJHJya+GgE= X-Received: by 2002:a17:902:e88f:b0:223:2aab:462c with SMTP id d9443c01a7336-22bea4ab85fmr71725ad.15.1744312815426; Thu, 10 Apr 2025 12:20:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6DNynR3qAzVJ5oYYe87012HehD64MJOEbZmJ5Zs6nbMEMT14kmxUjgfXc/J/nlg5RXQ5jsTdGAdgJRpiy1tQ= X-Received: by 2002:a17:902:e88f:b0:223:2aab:462c with SMTP id d9443c01a7336-22bea4ab85fmr71525ad.15.1744312815145; Thu, 10 Apr 2025 12:20:15 -0700 (PDT) MIME-Version: 1.0 References: <20250407182104.716631-1-agruenba@redhat.com> <20250407182104.716631-2-agruenba@redhat.com> In-Reply-To: From: Andreas Gruenbacher Date: Thu, 10 Apr 2025 21:20:03 +0200 X-Gm-Features: ATxdqUHNINlL-pUTFVGgFjmH-0Yv2T34SdJ_H6wPly98qpm7VaT0OlGqfhHJNig Message-ID: Subject: Re: [RFC 1/2] gfs2: replace sd_aspace with sd_inode To: Christoph Hellwig Cc: cgroups@vger.kernel.org, Tetsuo Handa , Jan Kara , Rafael Aquini , gfs2@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YBJx1Zb12wloX5wEeFd0F8m2BaLfP9JbHZKwMp621Jg_1744312815 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5E2CD4000A X-Stat-Signature: b94bqopggh8t8y1xejt9h9gojoc63k7t X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1744312818-218062 X-HE-Meta: U2FsdGVkX1+jtAAJXaG5pJkzSU2srjnB/x76xtg1NMiO0wSz/ASAPH827G+WULOMo60McWRwV320XZizbxjsSdp+Ee8DiD33QEzfW7l/uUYiC+kCXjvVLdxEXN4pE2pFlRCR9VIN+qUImQRGPurz0O7uGArLIFtMKziGDxdz+uoyN5dcV7r/A5hu+YyusO+kCIcUiYYWRwPmlXf+e6gcfNAVUYWK0X2+dvYQZshPZKdwwpwwZCtWcxY2u6o1a8VV+HNNrAtUhlZU5exmXQ1IUFRei2Uj/v/HsUDEp7PUKtwg6v5021HQj43K+mqpsBx9jj3yAq2WBs/NXTrP+OGgMp+wIQufmZktYgEYKz1DYOPL7N2m8C/5q6u440eX54pxyMteKdbxbNPgIR0heGpEqD1FiJOOx8zZL5TMZPSJCZcgre6oKwOtvHF7yLbptHAsrK+ZhSFvGGyY8pGPfnEszeSidoxzhKAYNzSMq6283KNwtJSkwBQHMZS0loL4ftfdL8xnxHwYOaXOPZt1RMgHvUWTlV2af/wUpsbZxCsg94i89/WxGFVjAkNJmGxzMuJhrkkcq6xT1nA/jWngXmqSD//300k9sslawTAvzu9xbDHmTA4W8pcPrtm4Lixf0uAxqSoUNBnbzrfBA6qlEGpWf52sVm9bLV7lnEnT1CmnomVrSkehACxw3ZtYtgJP5l+2d1jQaUkHGwGRIuaoVNguJpu5hb0GFUbETJmhvfI/EbPs0q8tM4aZYzKzTTloiSPAYWiNiqt87QewcJ6O+0Js7CbnvQTbxfv+6WRNfXB1yChMhEZqtGg7r5oQvD3wKIUajr1HxIQURTHgfChaLBRzEpcaFZS6kiOzknRD2w6t2b7aqHHoj80d78/W/NE+oyaHBD7RdI6EYXiAd1ZgN0gatbNz3Xd/t+TqsEFWFLf10L8Dr55qDSTLOJMT3qOdCG1ac6wgQk5NYJqeq9/XgxA Ve9Wfj1v FarFdsc+iK1seWaBSJql+LXai9jH15Or6otwxZXlWzjqL03szjzG8nWpXQX2fFPIMzGqvivEEbKz9KtxrohPcSAkP0nSckrx/4H8piefAKU1jFZwYXfizApYJfmm208WpVGR17Ta8BcLov42tL/Jw2m13u6E4nyxKuXe7KQT983gtuFZoT0TBy9xA/UYRCheqf2vqW8RMcwrqeYA7+G0tL8VhJQaD7V/WthZc+yrPi2wY4dlOCFmuNNQfkouaqMz9MqCg9soKj3lc5o7C+UZriOW+nYdaaIUxMXbJZ0UoAFCwH+j9Z52NZBzUKf+eRX+NrV2ZNXuJoCeHWh4dMAbhYJHQ83z5l1duYc+hcDEMcc8JRZ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 10, 2025 at 11:01=E2=80=AFAM Christoph Hellwig wrote: > On Mon, Apr 07, 2025 at 08:21:01PM +0200, Andreas Gruenbacher wrote: > > Use a dummy inode as mapping->host of the address spaces for global as > > well as per-inode metadata. The global metadata address space is now > > accessed as gfs2_aspace(sdp) instead of sdp->sd_aspace. The per-inode > > metadata address spaces are still accessed as > > gfs2_glock2aspace(GFS2_I(inode)->i_gl). > > > > Based on a previous version from Bob Peterson from several years ago. > > Please explain why you are doing this, not just what. Right, I have this description now: Currently, sdp->sd_aspace and the per-inode metadata address spaces use sb->s_bdev->bd_mapping->host as their ->host. Folios in those address spaces will thus appear to be on "bdev" rather than on "gfs2" filesystems. Those "bdev" filesystems will have the SB_I_CGROUPWB flag set to indicate cgroup writeback support. In fact, gfs2 doesn't suppor= t cgroup writeback, though. To fix that, use a "dummy" gfs2 inode as ->host of those address spaces instead. This will then allow functions like inode_to_wb() to determin= e that the folio belongs to a a filesystem without cgroup writeback support. Thanks, Andreas