From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02F02C369B2 for ; Mon, 14 Apr 2025 23:22:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEA53280101; Mon, 14 Apr 2025 19:22:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C72F12800B1; Mon, 14 Apr 2025 19:22:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B112E280101; Mon, 14 Apr 2025 19:22:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 934692800B1 for ; Mon, 14 Apr 2025 19:22:46 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1D7931C973B for ; Mon, 14 Apr 2025 23:22:48 +0000 (UTC) X-FDA: 83334226416.15.FF49CB7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id C80F9140005 for ; Mon, 14 Apr 2025 23:22:45 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JJqBs7PS; spf=pass (imf09.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744672966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fTqOfhVMO3oX7s5hEfhf7N6UJGTux5HLcHvFLo78+oQ=; b=55Z1y1BYkmUKnHhgOJ1OzPiewVjzXnozxNI/KIw6KnT/gH/aghNUw8M9J82gkt9A3UfJRn Sqi4l4jfAKLxIMYyUbLCuOUoNHYtHBb7kMO0KQuzF43+y6Rf/N7NTx9KEgplypm7LHBnHK 0+E0HXZnU/wmomqDn2B28D7ZajYQHPg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JJqBs7PS; spf=pass (imf09.hostedemail.com: domain of agruenba@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=agruenba@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744672966; a=rsa-sha256; cv=none; b=1bcqmulgoPhPjdx5rT3TiPPymmmW5KuWlRfVUKWu76W5oPJOlUj4xO9SfQndOr07Jwsvg0 M4gj1bwPUU2TUy8sM8YOu88xgnIeLZNm1RYF9l9fhl60d0I4zqY6o2ERhiHQ3kqjz1i4ik sCAGX12UTkxiubSaQ4aDXeTSDDVxp2w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744672965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fTqOfhVMO3oX7s5hEfhf7N6UJGTux5HLcHvFLo78+oQ=; b=JJqBs7PSrBmiufQah1P44eStGPSNhhLSorTcTqmPkl5LzyFnPzvX1XvtCwjWEAr1EfIgF7 uUprQ3Pj/CSPRhkybySu5rR0aOukDct0u+ovODA17fX8Jb/jSD86YtkjknRSUbGwOmG5Zg i4J50Hlkj0+d11gB9Xdvor6kAvPTnqE= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-170-JJ2seuQoP0SCLkX1Hcp4eQ-1; Mon, 14 Apr 2025 19:22:42 -0400 X-MC-Unique: JJ2seuQoP0SCLkX1Hcp4eQ-1 X-Mimecast-MFC-AGG-ID: JJ2seuQoP0SCLkX1Hcp4eQ_1744672961 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-225429696a9so62518615ad.1 for ; Mon, 14 Apr 2025 16:22:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744672961; x=1745277761; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fTqOfhVMO3oX7s5hEfhf7N6UJGTux5HLcHvFLo78+oQ=; b=EcNZjUTYqOc//GVDKKxLYASD37lfLPDkKLnDuaLKvu/gpjZrlZpEc1OUDZMl0n9hal ToqSyH/wKbtvTkN1Btirt2sMfU5IjucJ1zAHURwFZy7KZC2oQH+/mcsch5CAbAAUr/mO 1cBYNfUVGnpUbCZUdm+6t/UYW6ornHGQJya4o6Zrv46JQRAXBIfQzsNQUUJ1wKbBZFnp 4hEplI2S72I20ZeTYIlQ6L/rwX8htB/qKoBN18VmfDlWARf5SydLjibvg9PyNOhzeRE+ 0Nn4QVwtreU3mBdh70HiDVvIiL1gkGR+RHK2ZamaoHPn3Zauj/uH7ZtnPPOVBqq7Qh/E umtA== X-Forwarded-Encrypted: i=1; AJvYcCUJxV0TA5OshAeYZJv4+TdUrgK0cqSdJiDqOHnLXs6olLBpZbAxf5G6f9sqDh/q/5apTIXULVeZog==@kvack.org X-Gm-Message-State: AOJu0YyS1CwX9AqYOxtD7bYSCe/P79DMq5oODeqVSi5ULKm+BxRGS/P/ Ce2FQ91tIgFF4ZXR1ivTfO4hEQ5Cr6u5lUEpGlDyXE+6+md/faPq8nRmPKiuLMmk6kbdFzVZnVd jEITRXkMFHlati98bQENCKiVzOWNrbrKBBmId1VVp52gFxeGjYJqwKRB/lubtuyulfpWv69QHRa sUvMQFRorXxapE3obqwWnIjMw= X-Gm-Gg: ASbGncuiwHYqoVpKI9G5y5CMlRkqQoZAFIU2Ahci+Ygcrs4cRf+EH7bnqFR3RVMcvbo rWXy8NlibXuGqzdzyhEp2TplqHYmIOcF87Yr1Zd5vsn+Czt1IqaxDD2ZAvywVw11XhAc= X-Received: by 2002:a17:902:ea10:b0:21f:1202:f2f5 with SMTP id d9443c01a7336-22bea4a1e41mr165046185ad.8.1744672960905; Mon, 14 Apr 2025 16:22:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1AHsKSZHKc3ZG9l2EOP9IVYFBrGDAU7Mxy/wvMCYvA1yfGQ8huWiBkzCVojnxML9vlgqyT86Cp7v0R0BshkY= X-Received: by 2002:a17:902:ea10:b0:21f:1202:f2f5 with SMTP id d9443c01a7336-22bea4a1e41mr165046005ad.8.1744672960646; Mon, 14 Apr 2025 16:22:40 -0700 (PDT) MIME-Version: 1.0 References: <20250412163914.3773459-1-agruenba@redhat.com> <20250412163914.3773459-3-agruenba@redhat.com> <20250414145120.6051e4f77024660b43b72c8a@linux-foundation.org> In-Reply-To: <20250414145120.6051e4f77024660b43b72c8a@linux-foundation.org> From: Andreas Gruenbacher Date: Tue, 15 Apr 2025 01:22:29 +0200 X-Gm-Features: ATxdqUGev3hKkKP_xReo0nZ3C7cPj6MnUdmVFecbVAT6bl5u52ieWp2nkeKtLgg Message-ID: Subject: Re: [PATCH v3 2/2] writeback: Fix false warning in inode_to_wb() To: Andrew Morton Cc: cgroups@vger.kernel.org, Jan Kara , Tetsuo Handa , Rafael Aquini , gfs2@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1RtzkXNXFS8CPruZD12E0rvJmNEJ7X6IzXWrKiRoUzc_1744672961 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C80F9140005 X-Stat-Signature: 577gfqi93jbuqko6skb6668qanj9p3qx X-HE-Tag: 1744672965-369875 X-HE-Meta: U2FsdGVkX18dsOCXVTZrfijBSGbnuSRhrWKVUE+4lZefJIoxnGG+hTTWKHMq+Pyeph9SHKpUzSDl4Gl1rdIKthIiB3qUOeAMwXJ/lBhgh5qN4Cpe/nhJzxisWqeduwRxcQywx4QF6q3QrdsB6twro3e9gKovQAJwUBv8vf9cwHb2VUnZfAQvE7A+2XJkbcj78H6s4VNzjy163qvraHVpu7VEmHP+tUSew1o5iqr7/VQlkTO7DfPA0JPFhI41DRhdGQfgLRfDgj9QNOnVtBolipPFH5+Rdc3tw1qbwDznvdbwTqlQd0KFI/cICKYZfc2NON8h3Pu6t4i1KjBvQrfA6dyuu0an05H+odlEwqd98kKpTy+2WSAYiMuMQdSpcVg6JpiuYd6fpzDyvgETXSnzLmghftLvN9+EdrkJL9toEER0+pY2nmeQBoSB1VoPxnDa5eLfxXfpMr3CyKiYgjnRwHsjKcNrS4M5QgEmBT/OqaB0/nUmgzzWvFfQUmx//akxtjmDmxL7GEdLIcGNR9sexOeUhfNjUiEZJPbrvKrlGg7Bb5lk+cbw7HxGnH1y3K1tgtx/t5CBWvlKK3dw5l2mjTwCrz0YGWbHqzdLyINiwolV3KfekCn/bQ3yEnuYjbKHQtb51IJSHldFuYTlSvHmZLu2QcPwe8npBiZNowAn83cFnS7scLNtUvvAGNHrI2UX2G1PryxCzPaSoB1BTRtx3FjDhU+Cp0mka3Ap74ZGkV37FjqZSIWuOfMK+zM5V9LVz+iIWdHG0WTGDdswDkM5xP20g9vaTBcA7fUoC00g4weSSembAuMqRcOxTZpSRhVk5PpI6X9YGeAstvNX/8/DGWB9BNZtwZxLbVgAkaZsNFTmeLDlgUirZcwgrXqcNjIeIdaXPRDwKsb1KV112MZEfNsFSxTeFAMlq+2SC7NWZ2RnT67xqeAT6+xHSBGukKbiaI6uDmu6M+wgHlkTqRc V2nUvHNg alvJP4U36kQpp/0vkvUKEjQiccUwHrQuthRoRy+fQTQuqmWpTiDsrhWUHeJBqB0YesKVy88VaCOHH5QzoB/33fMxxTbbw2882TtssJm7yHua4o6SOhMUCXbfIsGjcaBeIHnAoWATHUusNrgXzFJsVIfpKL0LGSYdadF9fqDviVGeu8tKo6TH9JOLo+xpGzwiYNWHvDoMnE1dXrYIUCoC1BQqKsqMXLiELdWAn3ZEw2JoM9BvD2k7kCBi0dS1LfG/9CEb1yfWnGpvY5xfUpjNpNKC0Och2UZ+qzWfyuBm22yXcxgLo8HmYEMiQsiIp1zAfU9mPXPiWcUvhPcAxZnptfDBIl7Nmb4aR//t3s9yfGYoGbagpcJI3PMpR6rqjMGGq7VHudEHFq5yZiwkKCMznXHancEu2nbLngEnr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 14, 2025 at 11:51=E2=80=AFPM Andrew Morton wrote: > On Sat, 12 Apr 2025 18:39:12 +0200 Andreas Gruenbacher wrote: > > > inode_to_wb() is used also for filesystems that don't support cgroup > > writeback. For these filesystems inode->i_wb is stable during the > > lifetime of the inode (it points to bdi->wb) and there's no need to hol= d > > locks protecting the inode->i_wb dereference. Improve the warning in > > inode_to_wb() to not trigger for these filesystems. > > > > Signed-off-by: Jan Kara > > Reviewed-by: Andreas Gruenbacher > > Yoo were on the patch delivery path so there should be a > signed-off-by:Andreas somewhere. I made that change to the mm.git copy > of this patch. I guess that's fine as long as Jan is credited as the author. Thanks, Andreas