From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B518C433EF for ; Thu, 7 Oct 2021 18:28:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 078D061040 for ; Thu, 7 Oct 2021 18:28:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 078D061040 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 980546B006C; Thu, 7 Oct 2021 14:28:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92F496B0071; Thu, 7 Oct 2021 14:28:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81DFF900002; Thu, 7 Oct 2021 14:28:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 722B46B006C for ; Thu, 7 Oct 2021 14:28:50 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2BD63180BE209 for ; Thu, 7 Oct 2021 18:28:50 +0000 (UTC) X-FDA: 78670477620.11.11CE01F Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf28.hostedemail.com (Postfix) with ESMTP id EDE99900135D for ; Thu, 7 Oct 2021 18:28:49 +0000 (UTC) Received: by mail-ed1-f45.google.com with SMTP id y12so13282576eda.4 for ; Thu, 07 Oct 2021 11:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l3qN3MfhA2hn5WSk7ueIGscDIBqNVWdM54go8zsGIic=; b=Auj2KFW+kPtGThvhI+koW38dm6Ae65UgyBYLsvi9U0XXo9T/IielNC2jqDw9Hk4S7K fYVtZFT911RTIffZu7LmOnPmTF1KKDtK2U75lQ65ejFcBSpAN+P2HIh0FY/12zbaRHtf Wi1TsUfYqzj+7qGJ/+L+Kd+gCQ3jJk/55WFjJNZqrDjwcDQvgVle/2a4FR1TUgh6zDZ7 Go2uA6U4+bRUdLEs2EPp7ekzffIVKNFEx/jvizl77Fb3J2m5JS4RSQ2Q5cYnnv3fAL9q k1566krTjZnKWC7ueFrkBtcormsgRnk95T32xWXXKca8XQCDePLfHw8N7KNxm/Q7DGby WNYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l3qN3MfhA2hn5WSk7ueIGscDIBqNVWdM54go8zsGIic=; b=Cj+54WPtjpx/xdCfq4xLwGvNoEdkUvGFU7DVLbtJrA7xtWXzGyf8eT8NFHtBt/uksY SE8yoxpZbYnrSkyEsAODimkBTslAV+X/oM6Ry7/Et/ym3yp8s+8fAM+4qqjdYYtuMNAw OEbWEFJnA2x783kDVGU7gf3nR0gvEMpz8TqvjzryHd7utCrUYgKV8KAZQuuwIwe1Gr2p 9bbvAiEbV1t2xGTz0t1Sw1YL9HDV3P7KBQb2tHISNfSdvSUyRJxCu5UYw+3ELz+ePtre UDG8/T99zxXX6dmHr30571ELjuKg3edj/53RscNQb3N92G07eGZkg3VtEu0melZ0NpvM FZNw== X-Gm-Message-State: AOAM532WyXIpBaEMG6GeObWbK7yX/RZEL/s7IVnIfQfJ8GtqN18gENJW nrz/tRuab8qd1a04JHU/i3eVNZcjI4jl2oa1L08= X-Google-Smtp-Source: ABdhPJxgA18qK6hmXeIHMAGh+5TJ2JdQ0I/UDZzyKNqTvy46A6PUHs1z0LiF4dRutRMHydJpjbA4mGjN7IDVUb7O4C8= X-Received: by 2002:a50:8d85:: with SMTP id r5mr8303074edh.312.1633631328877; Thu, 07 Oct 2021 11:28:48 -0700 (PDT) MIME-Version: 1.0 References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-3-shy828301@gmail.com> <20211004140637.qejvenbkmrulqdno@box.shutemov.name> <20211004194130.6hdzanjl2e2np4we@box.shutemov.name> In-Reply-To: From: Yang Shi Date: Thu, 7 Oct 2021 11:28:36 -0700 Message-ID: Subject: Re: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault To: Peter Xu Cc: "Kirill A. Shutemov" , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Oscar Salvador , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EDE99900135D X-Stat-Signature: 5w7h5hgszjbqyxgbnpsfdp758mkcwqbm Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Auj2KFW+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-HE-Tag: 1633631329-116067 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000895, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 7, 2021 at 9:14 AM Peter Xu wrote: > > On Wed, Oct 06, 2021 at 04:41:35PM -0700, Yang Shi wrote: > > > Or maybe we just don't touch it until there's need for a functional change? I > > > feel it a pity to lose the git blame info for reindent-only patches, but no > > > strong opinion, because I know many people don't think the same and I'm fine > > > with either ways. > > > > TBH I really don't think keeping old "git blame" info should be an > > excuse to avoid any coding style cleanup. > > Sure. > > > > > > > > > Another side note: perhaps a comment above pageflags enum on PG_has_hwpoisoned > > > would be nice? I saw that we've got a bunch of those already. > > > > I was thinking about that, but it seems PG_double_map doesn't have > > comment there either so I didn't add. > > IMHO that means we may just need even more documentations? :) > > I won't ask for documenting doublemap bit in this series, but I just don't > think it's a good excuse to not provide documentations if we still can. > Especially to me PageHasHwpoisoned looks really so like PageHwpoisoned, so > it'll be still very nice to have some good document along with the patch it's > introduced. OK, I could add more comments for this flag in the enum. It should be just a duplicate of the comment right before the PAGEFLAG definition. > > Thanks, > > -- > Peter Xu >