From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DBE0D3A66D for ; Tue, 29 Oct 2024 16:08:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 026EB6B0093; Tue, 29 Oct 2024 12:08:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF0BB6B0096; Tue, 29 Oct 2024 12:08:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D917F6B0098; Tue, 29 Oct 2024 12:08:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BA6E26B0093 for ; Tue, 29 Oct 2024 12:08:37 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5CA9AC18BD for ; Tue, 29 Oct 2024 16:08:37 +0000 (UTC) X-FDA: 82727121456.13.85B5D88 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf13.hostedemail.com (Postfix) with ESMTP id EF4B52000B for ; Tue, 29 Oct 2024 16:08:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SIE6kLz9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730217940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A06TTu4K/Hw7kYgtfoh+7pEYBjhz9PQtPavahCL9qhA=; b=am2ueFK7sZ3OFIR1/A1Oen0an0YfhZ7sBgvLNAiOVx24uru6PL8fazwkuTbNcN92E1GnvT TnVJiV1aMB9scektAsgYNUqGFlCgyFJ2pLWf4tSKNLGByVXyM+W9qO7mkn2xSWuzvveEJt y0pcfmttOXsXSxi35MZg1wDKy/wl7+g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730217940; a=rsa-sha256; cv=none; b=bXkX3RUlJroxaHVn2+x8lKDUFmrWymOHIQuwBAlBOOiBjSJ7Cp/1Mu7ZH9/zd7cV3lmERP Ha8VOSrLSss2xFHcHvJX0kIqC2te7IAs5o53uLtJjibQ7kcL/+cDcxF5v51uW9633fbqkU M8p1xvs8iW3Xx72ZIoTONtNXNqIEKpE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SIE6kLz9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=shy828301@gmail.com Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5c96936065dso6598465a12.3 for ; Tue, 29 Oct 2024 09:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730218114; x=1730822914; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=A06TTu4K/Hw7kYgtfoh+7pEYBjhz9PQtPavahCL9qhA=; b=SIE6kLz9Hs9DEwh0Wv3Hv4M9KjDHnsVTjF3PDYG5SVyml8dqjVhCvFmX35aQewe+58 vVpTV5asDT2r+a+AZNMLUceqN/EOlpot7QXoPhU96IQkWM2T5iK1YF6XrNMt1U83vQM4 EILMcdo8xHyZDe3Np6KEbqQARuLGZr0lwl6KEnFuPKmAcMGYXedRn93iG+PJ83NHKX22 ox4sbPPWRV89GKAm1i2BKgpetnc0kJ6fhGEOfGdc0i5cNUM5mnT+BXGZT4okZS4uSHF/ 4kxdNOmSvHPm8bSoedr84Q+JvNK6A/nRAhJ8eCut0uCWG6aF7/uL/sOn5CHGRJe5Dzj1 yxfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730218114; x=1730822914; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A06TTu4K/Hw7kYgtfoh+7pEYBjhz9PQtPavahCL9qhA=; b=M63Snkr6XMqgipxeucCPxlHT3xbSbrRNJc1Kqe96apyoi1zO9T9N6A4JF2MMSpVnye RGYF9BRWBTfReX/66isKecnew7FHVx9AWZS4VmUxJM1DLM+kx2CyYX2ikPoZd75DT7wt /URhnpNTZjEcNI+4u+HfSFdm1S9F9DMATIEvbzZwb8KkMtZOT1Uk2Bdlrn06hBesFZYQ R/9KMFpqEesOuxqBMhRWP54H6m2UbP6C6gegeeUI/7k7Q8Vqtau7wI9ZcTqX5B+VzKxX 3EV3b/EgHZNTdNCetXXuiYj94m/25r3bqvzhrhMtPyco5aW7VThZZQeZFdnzNAJCZIOU zNgg== X-Forwarded-Encrypted: i=1; AJvYcCVATmZ5RygpywT2BH9naiKj646lF5BXug4XHPVftlBjwzInBPoUmi8xRFzk1o8F+ta9bBxhDTKcdQ==@kvack.org X-Gm-Message-State: AOJu0Yyox/n39awezNpFLFNv8apvrCVR1xpUu2Og2uODXOvNCSd1dg11 ZZfXCmT4uDpZ3KQjGlzfnIazh1fdMBX9TkOOVesVxwOwRWdr+FVuRkYUM45idHrsIMx/1P3/vO8 BHehFt24DYcg8pEgeRsjnBsYwphAqM6zY X-Google-Smtp-Source: AGHT+IH74eVrjzaa4trUOcmLyXjO6CWenLrQhabobnZcdo22+AisWlEFlNRHU+rC8G3QwxoacSmfWGmdR6B2NtODF3Y= X-Received: by 2002:a05:6402:2791:b0:5cb:b616:5eda with SMTP id 4fb4d7f45d1cf-5cbbfa54a5amr8452059a12.25.1730218113483; Tue, 29 Oct 2024 09:08:33 -0700 (PDT) MIME-Version: 1.0 References: <32e59a00-a174-4fcc-befd-56915cfb01d1@lucifer.local> In-Reply-To: <32e59a00-a174-4fcc-befd-56915cfb01d1@lucifer.local> From: Yang Shi Date: Tue, 29 Oct 2024 09:08:22 -0700 Message-ID: Subject: Re: [PATCH hotfix 6.12 v3 4/5] mm: refactor arch_validate_flags() and arm64 MTE handling To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Peter Xu , Catalin Marinas , Will Deacon , Mark Brown , "David S . Miller" , Andreas Larsson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EF4B52000B X-Stat-Signature: e1my63gzaitunutrgb7huxhg3a5qaa4j X-Rspam-User: X-HE-Tag: 1730218089-855417 X-HE-Meta: U2FsdGVkX1/KhmdYCrCu2e7Dg16OkF50r2k4tbI972jjF3mWx3elpY5t3ToGovUxnmxOT7as2kgirKuOOU3UfpfRDoWvukDyXVAP46+WwatvoSV3xGuZpJzcj7NjUdtCiUUHrcPjrOJhQTDNOAwfam8YOkLmxlgr+0T1E0onxlbVCGxrmxFhO+4VFxonI6tEFqEaCNGDtBXpBg7j32hN0i7YZK3WFDoR/d+DgFAlyCNTd5VlUMl6/muFPDEjEhfRFJRL/efC4D5eMOSwMqGzHP6YGKcJqLwSLxyJsrbaw3GOrlLCwzOWn5zejVyIiNINoQVIBVvtxfcYbfvU6Vz+hzQdkDeO7siDzJoHg4s1vb53aCge23GBibja4vRr92Mleqg547Nr+prY4vGFZbPjaWnu3pro2pqZ+UQ2Orm6jrbAm8tsMGaeKURdhv4btxhQ8xQsEqz8R/gzvUPG7dV/YAtEQMguFw8YGsjb1QNkuEPKbHv9Zn8hR7avrxMIip3R1bzBQy71IPEgPgax6GLLF19CvM9KgnhZBGCrQEgtFsN/oWX7Z9mYxREp03r+pjY/kVQem9ucNJYSJzgGVYMtJpwp+ihW7ySU047dJrQmksP1JL9SCSZlwi37EwM4/lxZhCt7zknKxSZ9BNLycIQ6CvgngguzLp2kvqs4yuX0oXBWv3SSiM13ZGqze5JDSkK4boFe97xYBo3h2LZUf36kzucLgk7nr/1+EYyfAhYgvnOVAzQfDgr0J4gNBiWKVKJXv0tH+ivCTmTvtCIM0S1b41aw7XfC5LkareZr73xXMCdFO+0a8BbiZrnF7pGpRQSTngWg2VuSSDrkfDpg9GxnhpieoXgBdNvaGO+IZBfm6B73B52YoxDtC/36440kmqOeDywVVNICxlw55R0IqUID0n/0dQZ8nL2z0Qw3VSmXYM1QhjQMJfXed/cN4rBKRXzcdvF9RkQ0bdKR+BHM9bI bu1jqoED 8kx8sk3lIswyps73SWBg6DH7G+mr3tsBhY9FTS3a4JiukUS4lTaAAcCmMBy250W4f28PwvtLl+qtoEBJGb8Dx6hy6cfnCXSE6KALyZHfbwzV79YHUlVIw6Z49pHhE0SWTlFpK84pgx/dCxcG57xvDnhrPUMnT+Q9+oktzANiPA36x3e5EPfUZDLpsPF/xeqOZ9UMSTyL/RsbxCsCXZJI2UqnCJ6CbU7JH+yPFTt5KPX7wFIChR/EWaEfMI5NnFNThR/tb/1bPt7E6694ekRTtxAR2rKrZSlgZrE0/l7hogqstLbYNdTfD41Wkqj8EkXfoIlVYiHsa2YWMgRfPcrjJatzJMK3/gE6/ZecHdvaYTMXnA6FN2CitRtB5kGTTRCDsxjd8G2wUpejtYGU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 29, 2024 at 8:52=E2=80=AFAM Lorenzo Stoakes wrote: > > On Tue, Oct 29, 2024 at 08:43:04AM -0700, Yang Shi wrote: > > > > > Sorry for chiming in late. This looks problematic IIUC. The patch 5/5 > > moved arch_validate_flags() before call_mmap() as the commit log said. > > But shmem_file() does this check: > > mapping->a_ops =3D=3D &shmem_aops > > > > But mapping->a_ops is not initialized until shmem_mmap(), which is > > called by call_mmap(). > > > > So shmem_file() should always return false here. Did I miss something? > > Well firstly this is tested and works so you did miss something :) > > Bu shmem_mmap() is not setting mapping->a_ops, it's setting vma->vm_ops. > > __shmem_get_inode() and shmem_symlink() set mapping->a_ops. My bad, stared at "_ops", but missed "vm" prefix. And shmem_mmap() can't touch a_ops. Sorry for the disruption.