From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE86EC07E96 for ; Tue, 6 Jul 2021 20:41:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D33361C81 for ; Tue, 6 Jul 2021 20:41:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D33361C81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 01DCE6B0011; Tue, 6 Jul 2021 16:41:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F10D96B0036; Tue, 6 Jul 2021 16:41:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB17D6B005D; Tue, 6 Jul 2021 16:41:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id BAC806B0011 for ; Tue, 6 Jul 2021 16:41:58 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2BD1722BE9 for ; Tue, 6 Jul 2021 20:41:58 +0000 (UTC) X-FDA: 78333334716.26.34F6105 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf29.hostedemail.com (Postfix) with ESMTP id F10519000241 for ; Tue, 6 Jul 2021 20:41:57 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id o5so36285403ejy.7 for ; Tue, 06 Jul 2021 13:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3KGUi2eO+MsCxXq1zsUMZr5k7SLp31poP5KKz7Mi2Q0=; b=BUHumQ980rq32+mbX/H/k/UQ9xqaADgASpqOUweJey3K1pQBJWAmCGypZD/+2RI4Nm 3X8SYdG8Yt/Uh3nlkWM3e7iW1ZBCBEbGnqi4kHKa0qtmgq69e34sjahHk1+JJc6N87bt TJOH4X4BhxVHYeWMBS+uAn4S9jwy+UG2XiCeolF/nUgH9rQCRxYnzT0x4ymSxVFnWLeM A0FM5Z5ctZSVAqWkqAwyGPNOtpRu3c6IeTuMs591WQli9Oy9+JwhJDOAoHZqnIrj2MMj wCL15R7CDZPYmB7YvTUO32NyLIO5JonTdFeln/JMJfrPdgpELc08hCHjckPlXU80q8ds t9Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3KGUi2eO+MsCxXq1zsUMZr5k7SLp31poP5KKz7Mi2Q0=; b=m5YJdL0jrzy+eL6/qd3KBavWG49YGO3BRGuzoDY6E7XMDmi2O7SWAwuyalhy0wFq3P r9jFP/nRdGmNOlLmyhav9UrZ+Y6X5ZwLCoUQPKGy9wPfQeLU4FXvPP7/8PhvzGtXsGgf epKbEwZe/J81hpGf93XuP+upyHEGNfzatcViK/qk2VCNtNiVvL6Md7aXMRK6HSmRssNp p+58B7XZn714JrgclDkfg7wjh/fAE5Kq020nAuN+IWsmpiTbAgpbneAXc3D7GezJrK5E Q6JwjMIYumQAxwANPGL0fcWNE+O5gWjf1eH2eueB+vVr/T8i1a7Ol1lt2k+NMbH2iB+5 M7kA== X-Gm-Message-State: AOAM533ye+KWuebr/p/lVywl2+v9xN3jdHNIC3L7QMQzDba880k8X93L nSj1nC2jD8rlx71Oczg+JrFpOyTT8I2gaNMiWdk= X-Google-Smtp-Source: ABdhPJzrzX2CzLT6FCs77vhq3Bnqk3DQLgxT6kEa0BgvAR+LeDqZuMHjv5+2D4Pp36KWwpqoBhPtHgFDkQG+JFKYYWI= X-Received: by 2002:a17:907:720a:: with SMTP id dr10mr19700223ejc.161.1625604116661; Tue, 06 Jul 2021 13:41:56 -0700 (PDT) MIME-Version: 1.0 References: <20210705053944.885828-1-hch@lst.de> In-Reply-To: <20210705053944.885828-1-hch@lst.de> From: Yang Shi Date: Tue, 6 Jul 2021 13:41:44 -0700 Message-ID: Subject: Re: [PATCH] mm: fix the try_to_unmap prototype for !CONFIG_MMU To: Christoph Hellwig Cc: Andrew Morton , Linux MM Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=BUHumQ98; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Stat-Signature: yuohk5b5375rdz6gw7urqcmugfuraodh X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F10519000241 X-HE-Tag: 1625604117-480385 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 4, 2021 at 10:40 PM Christoph Hellwig wrote: > > Adjust the nommu stub of try_to_unmap to match the changed protype > for the full version. Turn it into an inline instead of a macro to > generally improve the type checking. Thanks for catching this. Reviewed-by: Yang Shi > > Fixes: 1fb08ac63bee ("mm: rmap: make try_to_unmap() void function") > Signed-off-by: Christoph Hellwig > --- > include/linux/rmap.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/linux/rmap.h b/include/linux/rmap.h > index 83fb86133fe1..c976cc6de257 100644 > --- a/include/linux/rmap.h > +++ b/include/linux/rmap.h > @@ -291,7 +291,9 @@ static inline int page_referenced(struct page *page, int is_locked, > return 0; > } > > -#define try_to_unmap(page, refs) false > +static inline void try_to_unmap(struct page *page, enum ttu_flags flags) > +{ > +} > > static inline int page_mkclean(struct page *page) > { > -- > 2.30.2 > >