From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54911C07E9C for ; Wed, 7 Jul 2021 17:26:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EB88561C91 for ; Wed, 7 Jul 2021 17:26:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB88561C91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1B4DE6B0011; Wed, 7 Jul 2021 13:26:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1657E6B005D; Wed, 7 Jul 2021 13:26:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0058E6B006C; Wed, 7 Jul 2021 13:26:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CFDCA6B0011 for ; Wed, 7 Jul 2021 13:26:03 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1B94B1819589D for ; Wed, 7 Jul 2021 17:26:03 +0000 (UTC) X-FDA: 78336469806.01.905AED3 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf02.hostedemail.com (Postfix) with ESMTP id A43C8700177A for ; Wed, 7 Jul 2021 17:26:02 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id gb6so4505744ejc.5 for ; Wed, 07 Jul 2021 10:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CEEWx+Agfci6msVOCtYXN5NDbieVyI/f3RzczKPLAFU=; b=inZbLvGxVf98FTFjF604VAc9h6LIwYGerIC20fPdGfRlHRphgzkCwPYgZOSrcHr0i5 O93C6SkdIyxWevCOcuFqJmCq2LJBjjaOdc7bqEtmTKKjW8PrngSZozTJvcI44sEskyGy 9r34zyULZ8nSh8rvxMBc/v888UUHVPT6KcYNzF2qsuptvFXn6sIT9Ohi0Rwpxhz4wO8s LnbuyXM3BCYzXnSOONQAYsP/5LBm16dTl51q0tM/mpfIXgBwPOrTMGaFpkMBDLYcWVjV L4Eby3RS7EXSE6HAdTc3j/DBFTrQ16XkMDFDc6MqgwZgU1AjFUQpl9QioPCiafb+QdX0 qYGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CEEWx+Agfci6msVOCtYXN5NDbieVyI/f3RzczKPLAFU=; b=jbIGMDjzAYTCUpYomzRO7LkO7jQGwraOC2g7RgNCPF9d6F3pAWLMFjwyGiiFsFaGit V7YUufSAXGB7g0aarL0+gMqzBlGQldTeeNWPExHXrOy3dnb82qip+ydaVgqosdoCaYjq U1fDJYY2/TJUkwhIXkpCeh+XSGqINgdgD9BqJ06wmWHcXkBCHlEKxuq3AGMDMtKtkqoO 2n/dUbWKfPA4Nkb4Bz3tPNUSmS/QGR1gEBO7DpeaWyuQQVeGyPlgkck5XCM8tl3h06ub FWm4NdnzsjJOqLsywLU5y2nDzKeXI7L6mQb5Vz1D+FTIjMTABDoPPwutwgukCDX1RPcE /wPQ== X-Gm-Message-State: AOAM5315CFdcYyXzkdHgR5HfwZ59eI4/hOYlmhwbEQSB4LUAZewUOrf/ g73uaP9pDNCW763XyZMOCRmh3pMbyv5w+yupLwE= X-Google-Smtp-Source: ABdhPJxw1Jhg9j+lPF+XGBUe2mopy0bQo5zSumCrBkebSru5fpRDg9IVmCv6iRtxuosl+CJo4B1qZz58jvl4aDESZXM= X-Received: by 2002:a17:906:c148:: with SMTP id dp8mr24709133ejc.507.1625678761411; Wed, 07 Jul 2021 10:26:01 -0700 (PDT) MIME-Version: 1.0 References: <20210707161614.13001-1-rdunlap@infradead.org> In-Reply-To: <20210707161614.13001-1-rdunlap@infradead.org> From: Yang Shi Date: Wed, 7 Jul 2021 10:25:49 -0700 Message-ID: Subject: Re: [PATCH] mm: try_to_unmap() is now void To: Randy Dunlap Cc: Linux Kernel Mailing List , Hugh Dickins , Andrew Morton , Linux MM , Greg Ungerer , linux-m68k@lists.linux-m68k.org, uclinux-dev@uclinux.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=inZbLvGx; spf=pass (imf02.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A43C8700177A X-Rspam-User: nil X-Stat-Signature: 7d896w5oyo8oojth7puw5zebzrno5hba X-HE-Tag: 1625678762-54352 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 7, 2021 at 9:16 AM Randy Dunlap wrote: > > Fix the "CONFIG_MMU is not set" case of converting > try_to_unmap() from bool to void. > (as seen on m68k/coldfire) > > In file included from ../mm/vmscan.c:33: > ../mm/vmscan.c: In function 'shrink_page_list': > ../include/linux/rmap.h:294:34: warning: statement with no effect [-Wunused-value] > 294 | #define try_to_unmap(page, refs) false > | ^~~~~ > ../mm/vmscan.c:1508:4: note: in expansion of macro 'try_to_unmap' > 1508 | try_to_unmap(page, flags); > | ^~~~~~~~~~~~ > Thanks for the patch. hch sent a similar patch (https://lore.kernel.org/linux-mm/20210705053944.885828-1-hch@lst.de/) and it has been in -mm tree. > Fixes: 1fb08ac63bee ("mm: rmap: make try_to_unmap() void function") > Signed-off-by: Randy Dunlap > Cc: Yang Shi > Cc: Hugh Dickins > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: Greg Ungerer > Cc: linux-m68k@lists.linux-m68k.org > Cc: uclinux-dev@uclinux.org > --- > v2: add linux-mm m.l. > add M68K/Coldfire Cc's > change to static inline function. > > include/linux/rmap.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-next-20210701.orig/include/linux/rmap.h > +++ linux-next-20210701/include/linux/rmap.h > @@ -291,7 +291,8 @@ static inline int page_referenced(struct > return 0; > } > > -#define try_to_unmap(page, refs) false > +static inline void try_to_unmap(struct page *page, enum ttu_flags flags) > +{} > > static inline int page_mkclean(struct page *page) > {