From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CACDCC433B4 for ; Fri, 9 Apr 2021 20:10:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3276C61108 for ; Fri, 9 Apr 2021 20:10:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3276C61108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6F5DE6B006C; Fri, 9 Apr 2021 16:10:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A61B6B006E; Fri, 9 Apr 2021 16:10:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5462C6B0070; Fri, 9 Apr 2021 16:10:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 3C4EA6B006C for ; Fri, 9 Apr 2021 16:10:48 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E4F6B183380AD for ; Fri, 9 Apr 2021 20:10:47 +0000 (UTC) X-FDA: 78013921734.17.A82C14E Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf26.hostedemail.com (Postfix) with ESMTP id 87A6640002C8 for ; Fri, 9 Apr 2021 20:10:44 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id n2so10520151ejy.7 for ; Fri, 09 Apr 2021 13:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Lf36qlPIx942AzqupP75X0tTf2UJIm0G/Hhd8SI7Wag=; b=dCuXmXCO7osXPm0KUMVbp3DjgNxfeINyZ7M9kdP1FBxyXvyE/CsvJ86jTdR5rNej5r 6EyM7nzOldp2Q+IyngBXac2jSvnptdRK6X95AhPRvheloHmPhr8XMlSuhEKEyk6hu9lW u+VZPfb9jkRkph1fGf1r+ETuVj/kBSnpQ2r2FEn8gwL50XOcMdJ/a9W4zR9tKwkR+IC8 /HZQxO6w4VMG31bh1uf9lw5g8g+FieBzt4FDv36V1M43W30HKd7EHsFM5OZlT9GrTmbT xef0CYt9sh9U9evlE/35ZRDimJraJT9Vynttw2SNK6lJYxXZ+BWzOXhi4qHhbkJEXoAE GyLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lf36qlPIx942AzqupP75X0tTf2UJIm0G/Hhd8SI7Wag=; b=iWHZcmGoy/IdoyHJXfGQ7RO0ySoOnMSD1jhfA1mD5/d2NtX9XMApeTjc2TtZVLEWoz wl7gUX2bdUzcd7fl6hAPA73/BGsM6ip9DWKUeLHO22jdhVi77WzgwbyI0QX2GlZrPrQw tfZDv6IKpDgVjRbBayeDYvivoEdm4q4YxBDZhbeieUgCuvnloKLHUSdoW+UQsa0Ayg4+ 9WStXR71Bc+HXfxThpI8aUWYGPU29TcSwwR51pul5VSEX2wjhQ85b1Ilwbo/oVf2rifH EofM9sk6NOfAwO9YIm3NaALVknKHLMKT2xw5q+MayyA2RnuCkKYqp7ZLfb5F8glf2K8q soMQ== X-Gm-Message-State: AOAM5304ZrVjbsD3n+0bt7cAwbL70iPIoJjLYFIJdlL41UMAn+Bmexn6 Pb2H3mJDDtP530zaSpTSFkX5r9S8ILw85iL7PJA= X-Google-Smtp-Source: ABdhPJyeF4EqtX9vvgTqHhPKB0yFPThkRwGjIgW+Sz4j34OntIYLyYxDMUHW2X1P+C/I6IFRAJp3ZS6a8kAhXr8rgOM= X-Received: by 2002:a17:906:6dd9:: with SMTP id j25mr17395712ejt.507.1617999046419; Fri, 09 Apr 2021 13:10:46 -0700 (PDT) MIME-Version: 1.0 References: <20210401183216.443C4443@viggo.jf.intel.com> <20210401183223.80F1E291@viggo.jf.intel.com> In-Reply-To: From: Yang Shi Date: Fri, 9 Apr 2021 13:10:34 -0700 Message-ID: Subject: Re: [PATCH 04/10] mm/migrate: make migrate_pages() return nr_succeeded To: Dave Hansen Cc: Oscar Salvador , Dave Hansen , Linux MM , Linux Kernel Mailing List , Yang Shi , weixugc@google.com, Huang Ying , Dan Williams , David Hildenbrand Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 87A6640002C8 X-Stat-Signature: gaact95u1hopg1971oxqtmkfujjchxtn Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mail-ej1-f48.google.com; client-ip=209.85.218.48 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617999044-577374 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 9, 2021 at 8:50 AM Dave Hansen wrote: > > On 4/8/21 11:17 AM, Oscar Salvador wrote: > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -8490,7 +8490,8 @@ static int __alloc_contig_migrate_range(struct compact_control *cc, > > cc->nr_migratepages -= nr_reclaimed; > > > > ret = migrate_pages(&cc->migratepages, alloc_migration_target, > > - NULL, (unsigned long)&mtc, cc->mode, MR_CONTIG_RANGE); > > + NULL, (unsigned long)&mtc, cc->mode, MR_CONTIG_RANGE, > > + NULL); > > } > > if (ret < 0) { > > putback_movable_pages(&cc->migratepages); > > I also considered passing NULL to mean "I don't care about > nr_succeeded". I mostly avoided it to reduce churn. But, looking at it > here, it does seem cleaner. > > Any objections to moving over to Oscar's suggestion? No, fine to me.