From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4551C6FA82 for ; Tue, 13 Sep 2022 16:14:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D5468D0001; Tue, 13 Sep 2022 12:14:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7854C6B0075; Tue, 13 Sep 2022 12:14:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65C736B0072; Tue, 13 Sep 2022 12:14:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 548016B0072 for ; Tue, 13 Sep 2022 12:14:30 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 23179161234 for ; Tue, 13 Sep 2022 16:14:30 +0000 (UTC) X-FDA: 79907559858.24.B26E5FB Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf26.hostedemail.com (Postfix) with ESMTP id CA2611400C9 for ; Tue, 13 Sep 2022 16:14:28 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id a80so3645896pfa.4 for ; Tue, 13 Sep 2022 09:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=lzDsZjQ90ROGs3QYZwYvWTXpZ9Q4iGmt8mIgUDdFakM=; b=L2otZpAM2XwR4F4Fi5ZOUqbNPzHUvvQSGXulE/iSNWhmno5mOUPhUHfLXfJSbuXvmQ CMwXfxhpoTEdxY4fydU/PT2nyh2NK+PhfWQlx9f0pfHnfZa8T/H3HNakT7K9xlJz/Mat qEX8TspCRwlWntwcn65iN17P2mddtyWSfuPWXg2y9M5c0vxbugCwPgZec7ABtzId9+bX EzIz8e1JcFqcaJMsNIR+ld+LqWx364ls0Gmr1AlEdqUCCC04aaMHyZ1ejr2TQq3uj6HI hNhPgMEvCOvUqppo8ktcsVa7+Iuz0os8sFanzamezriqg5oC2TdGuYci+4+BsmERs71L rAZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=lzDsZjQ90ROGs3QYZwYvWTXpZ9Q4iGmt8mIgUDdFakM=; b=wJ4KZ2f9TlkQLOjrZIpPeNWKzsR5QTXJACBx5efcdqkurpPBAgnvAnIEE2JWdJypLL xZp+TEW7wzuv9xqPj+xan36genUpoBg6buzH/HPfvTPR27CNUGrfdJDMw/TeSO1nVGaW f/JfJpGhOXjUZd7JDJxCpUQQBmOTAjFksvIEzFBXbgMhYLu96BTRP8z78paoNDAWP3Ds 4cmDnJoHQCjdtHG94vdeBCy+T73G4yRRumkLq3ohiat3NEW28czHyuccChoIPN6ve5GN v9yIOFNe0QkC2VKWMSAwiMCT0f450ZWXOzXOU9HdX+WuDMxQbKtf1cowhsSFKeCicPNx QbWw== X-Gm-Message-State: ACgBeo19b92BCu9MirvtS/pDA8XibewAAWZeVPqV8cZVvCUIMNDFpt58 mHf84k+5My30iJAKQfSHEf1NUgAa9+Emoc5vVtI= X-Google-Smtp-Source: AA6agR5ugs0i3khW3C/hEznDf3Tg3v3P6/AkqnJx578lLIXmxQarLDpjN7FrH1aNY0qfrpx7gRYwlOcTncQcYcgobvI= X-Received: by 2002:a63:d511:0:b0:438:91d5:5a43 with SMTP id c17-20020a63d511000000b0043891d55a43mr17340710pgg.587.1663085667416; Tue, 13 Sep 2022 09:14:27 -0700 (PDT) MIME-Version: 1.0 References: <000000000000f537cc05ddef88db@google.com> <0000000000007d793405e87350df@google.com> In-Reply-To: From: Yang Shi Date: Tue, 13 Sep 2022 09:14:15 -0700 Message-ID: Subject: Re: [syzbot] BUG: Bad page map (5) To: syzbot , "Zach O'Keefe" Cc: akpm@linux-foundation.org, andrii@kernel.org, ast@kernel.org, bigeasy@linutronix.de, bpf@vger.kernel.org, brauner@kernel.org, daniel@iogearbox.net, david@redhat.com, ebiederm@xmission.com, john.fastabend@gmail.com, kafai@fb.com, kpsingh@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, syzkaller-bugs@googlegroups.com, tglx@linutronix.de, yhs@fb.com Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663085669; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lzDsZjQ90ROGs3QYZwYvWTXpZ9Q4iGmt8mIgUDdFakM=; b=2IjmgvOI8xEdC6Ix482HATOfecKTe1RkW/imbt2Xh2qR/4yB5hsvSzKMyzTR996NeBUZ3T CsGYy8JWAKjhqcVjzC8ncoYwa/1ckb3NL4eWFTB0CLXId/hYl15xa4lcJjnLQ3CHKAKHnF 7IqOsioMHjCBBV3XApFdk0p+cEKXS4I= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=L2otZpAM; spf=pass (imf26.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663085669; a=rsa-sha256; cv=none; b=En2ozkl8RlY+ZuLZHD6ulLXRHls/TPOSxMgVatzvVSgwon87mkGrq+A/fLKfWN8/HtZOAH yFedYY7soo4gd0BWhPCsHa4/c7IppykUsm/gnQfFtdsC87d0WAyZSOSwkV/n30sUWEQFro tGbZbjmZALf+ZG1KRRl4EKhR1ymEyN0= X-Stat-Signature: gnzh8niajtoshxahkqsh3f457fzffadf X-Rspamd-Queue-Id: CA2611400C9 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=L2otZpAM; spf=pass (imf26.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1663085668-20054 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 12, 2022 at 2:47 PM Yang Shi wrote: > > On Sun, Sep 11, 2022 at 9:27 PM syzbot > wrote: > > > > syzbot has found a reproducer for the following issue on: > > > > HEAD commit: e47eb90a0a9a Add linux-next specific files for 20220901 > > git tree: linux-next > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=17330430880000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=7933882276523081 > > dashboard link: https://syzkaller.appspot.com/bug?extid=915f3e317adb0e85835f > > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13397b77080000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1793564f080000 > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > Reported-by: syzbot+915f3e317adb0e85835f@syzkaller.appspotmail.com > > > > BUG: Bad page map in process syz-executor198 pte:8000000071c00227 pmd:74b30067 > > addr:0000000020563000 vm_flags:08100077 anon_vma:ffff8880547d2200 mapping:0000000000000000 index:20563 > > file:(null) fault:0x0 mmap:0x0 read_folio:0x0 > > CPU: 1 PID: 3614 Comm: syz-executor198 Not tainted 6.0.0-rc3-next-20220901-syzkaller #0 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/26/2022 > > Call Trace: > > > > __dump_stack lib/dump_stack.c:88 [inline] > > dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 > > print_bad_pte.cold+0x2a7/0x2d0 mm/memory.c:565 > > vm_normal_page+0x10c/0x2a0 mm/memory.c:636 > > hpage_collapse_scan_pmd+0x729/0x1da0 mm/khugepaged.c:1199 > > madvise_collapse+0x481/0x910 mm/khugepaged.c:2433 > > madvise_vma_behavior+0xd0a/0x1cc0 mm/madvise.c:1062 > > madvise_walk_vmas+0x1c7/0x2b0 mm/madvise.c:1236 > > do_madvise.part.0+0x24a/0x340 mm/madvise.c:1415 > > do_madvise mm/madvise.c:1428 [inline] > > __do_sys_madvise mm/madvise.c:1428 [inline] > > __se_sys_madvise mm/madvise.c:1426 [inline] > > __x64_sys_madvise+0x113/0x150 mm/madvise.c:1426 > > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > > do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 > > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > RIP: 0033:0x7f770ba87929 > > Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 11 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 > > RSP: 002b:00007f770ba18308 EFLAGS: 00000246 ORIG_RAX: 000000000000001c > > RAX: ffffffffffffffda RBX: 00007f770bb0f3f8 RCX: 00007f770ba87929 > > RDX: 0000000000000019 RSI: 0000000000600003 RDI: 0000000020000000 > > RBP: 00007f770bb0f3f0 R08: 00007f770ba18700 R09: 0000000000000000 > > R10: 00007f770ba18700 R11: 0000000000000246 R12: 00007f770bb0f3fc > > R13: 00007ffc2d8b62ef R14: 00007f770ba18400 R15: 0000000000022000 > > > > I think I figured out the problem. The reproducer actually triggered > the below race in madvise_collapse(): > > CPU A > CPU B > mmap 0x20000000 - 0x21000000 as anon > > madvise_collapse is called on this area > > Retrieve start and end address from the vma (NEVER updated > later!) > > Collapsed the first 2M area and dropped mmap_lock > Acquire mmap_lock > mmap io_uring file at 0x20563000 > Release mmap_lock > > Reacquire mmap_lock > > revalidate vma pass since 0x20200000 + 0x200000 > > 0x20563000 > > scan the next 2M (0x20200000 - 0x20400000), but due to > whatever reason it didn't release mmap_lock > > scan the 3rd 2M area (start from 0x20400000) > > actually scan the new vma created by io_uring since the > end was never updated > > The below patch should be able to fix the problem (untested): > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 5f7c60b8b269..e708c5d62325 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2441,8 +2441,10 @@ int madvise_collapse(struct vm_area_struct > *vma, struct vm_area_struct **prev, > memset(cc->node_load, 0, sizeof(cc->node_load)); > result = hpage_collapse_scan_pmd(mm, vma, addr, &mmap_locked, > cc); > - if (!mmap_locked) > + if (!mmap_locked) { > *prev = NULL; /* Tell caller we dropped mmap_lock */ > + hend = vma->end & HPAGE_PMD_MASK; > + } This is wrong. We should refetch the vma end after hugepage_vma_revalidate() otherwise the vma is still the old one. diff --git a/mm/khugepaged.c b/mm/khugepaged.c index a3acd3e5e0f3..1860be232a26 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2592,6 +2592,8 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev, last_fail = result; goto out_nolock; } + + hend = vma->vm_end & HPAGE_PMD_MASK; } mmap_assert_locked(mm); memset(cc->node_load, 0, sizeof(cc->node_load)); > > switch (result) { > case SCAN_SUCCEED: > > > > > >