From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB875C4320A for ; Thu, 5 Aug 2021 19:54:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 68EF1610FB for ; Thu, 5 Aug 2021 19:54:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 68EF1610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BA7446B006C; Thu, 5 Aug 2021 15:54:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B576F8D0001; Thu, 5 Aug 2021 15:54:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A45F66B0072; Thu, 5 Aug 2021 15:54:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 8F0686B006C for ; Thu, 5 Aug 2021 15:54:33 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3EDCF1AA8E for ; Thu, 5 Aug 2021 19:54:33 +0000 (UTC) X-FDA: 78442079226.01.DC6E4F2 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf07.hostedemail.com (Postfix) with ESMTP id E13B31001BF6 for ; Thu, 5 Aug 2021 19:54:32 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id x11so11450176ejj.8 for ; Thu, 05 Aug 2021 12:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oinuciazXZfKW3TA9YzSzopJrbNJm33ivJgVFjFAUqI=; b=TQeDfCeS06LDTcK4A+9yVv4lstRFP3tT1dJQhE+YuLxHRkr5UTy/ZqABUCl53AMO42 nkX99lqF3uf8sH6Rb08U/TvjAJ7JE9zT/jiQHBZz2Bjm251rLu2ugwOOlF6yIp/r9SPE bGcmcKlWebmmDOqGRgxpFq8GdG+G69jl9YO6t3EYEoYlkbLmFNuO9yc8BlGGNhx09zMl TR9s195p2O+tFeEKr9dZ2o/Pc9OtTXGFTPoODtbLAzYi9CpdAgIE2CLuVaIaJrSFa5qa 6qhP/f6tJqAJezayA+1BUHdyKznufJhO4eDYk1EtXb2SGnBTCtamM6N5Nm/F4yrbc/cC 4ATg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oinuciazXZfKW3TA9YzSzopJrbNJm33ivJgVFjFAUqI=; b=CZ8kruv+uP/dhZLVRgq50676xI5WD+A59X7a3b+ibWK4AofZojKUd2nj1KKwWawnUZ Ehh9br0DEns738SvTe+vxZDQht03JyNp97MIs+rYUXKvC/45RqLdYTh6YtErFGXWVidM 9yMgtfHAtBV2Y8XLYoGKYnO9dCAaJsq7u2GpA1EBLS2H3dX9r/af3Eo7MBfQ5z9sXsrx +WduyfxkTCu1XMxJnANbvu77RfdvuMvtDCHyKUIB2MqlpGjH4F+WX/OkhB+EE/6p4726 fnXpHl2DeRBH8MZOUUPCLLsN0u/Z0eH0qKJE+0A2Q/gR/7lNvR9b5pvNnuBFy35xtsfQ Vo3w== X-Gm-Message-State: AOAM5331cuHMc9YGNfUdxU5rbo5G5BuNTuThBlogH7WojzTWMk5RwtNU LvmyQL9ltVOs08hmoAhx6PklcJ95H6nVVwlwMnU= X-Google-Smtp-Source: ABdhPJxkQjEaUpkRe3wmRLfGE8VZoOWXYMUbx4g5Y/9/PRoG4zR+lS4NgOE21pyikNB2anncTFrUTkgGbs9oEBMf/pA= X-Received: by 2002:a17:906:1919:: with SMTP id a25mr6399565eje.161.1628193271401; Thu, 05 Aug 2021 12:54:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yang Shi Date: Thu, 5 Aug 2021 12:54:19 -0700 Message-ID: Subject: Re: [PATCH 5/5] mm: migrate: Remove redundant goto labels To: Baolin Wang Cc: Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E13B31001BF6 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=TQeDfCeS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Stat-Signature: p5ouf1grn7en1c9grrzsehpfb7j8f1so X-HE-Tag: 1628193272-28297 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 5, 2021 at 8:06 AM Baolin Wang wrote: > > Remove redundant goto labels to simplify the code. TBH I don't see too much benefit. The "goto" makes the functions have a single exit point. > > Signed-off-by: Baolin Wang > --- > mm/migrate.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 0ab364f..ed74fda 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -911,9 +911,8 @@ static int move_to_new_page(struct page *newpage, struct page *page, > */ > VM_BUG_ON_PAGE(!PageIsolated(page), page); > if (!PageMovable(page)) { > - rc = MIGRATEPAGE_SUCCESS; > __ClearPageIsolated(page); > - goto out; > + return MIGRATEPAGE_SUCCESS; > } > > rc = mapping->a_ops->migratepage(mapping, newpage, > @@ -949,7 +948,7 @@ static int move_to_new_page(struct page *newpage, struct page *page, > flush_dcache_page(newpage); > > } > -out: > + > return rc; > } > > @@ -2095,11 +2094,10 @@ static struct page *alloc_misplaced_dst_page_thp(struct page *page, > newpage = alloc_pages_node(nid, (GFP_TRANSHUGE_LIGHT | __GFP_THISNODE), > HPAGE_PMD_ORDER); > if (!newpage) > - goto out; > + return NULL; > > prep_transhuge_page(newpage); > > -out: > return newpage; > } > > -- > 1.8.3.1 > >