From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94069C433DB for ; Wed, 13 Jan 2021 19:49:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 07397206C0 for ; Wed, 13 Jan 2021 19:49:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07397206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F7D56B00AA; Wed, 13 Jan 2021 14:49:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A9136B00AC; Wed, 13 Jan 2021 14:49:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2983A6B00AF; Wed, 13 Jan 2021 14:49:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 102066B00AA for ; Wed, 13 Jan 2021 14:49:18 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AB7853634 for ; Wed, 13 Jan 2021 19:49:17 +0000 (UTC) X-FDA: 77701790754.18.gate97_330ab4927520 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 7B4D1100ED3CD for ; Wed, 13 Jan 2021 19:49:17 +0000 (UTC) X-HE-Tag: gate97_330ab4927520 X-Filterd-Recvd-Size: 4945 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 Jan 2021 19:49:17 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id i24so3233028edj.8 for ; Wed, 13 Jan 2021 11:49:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hum8GyG3YMlF2j+bxEQbnrEJdDI8ZwOXjUuAUt+nY5o=; b=nyp9gl2zbAqKPACHRjRmZ6TXdtLeiEsBNMwfT3WGY+fCYVRR+c1leQub87DsLVeJfq 9NWb113ao8Eu34k9t8uRuezckTJ/iJhhD1vXiY3bq3Z1RUns4FgxxA8vhShVZQC+gFD4 Xt5UnainWHnatCq2QeBDPdnpIAYN+lFPOpAgok7mZDkcKkwRs+OJWgbEOi+N43JWS3zM MROQgfyGprzFpIoKPPOxBqD6sJFKkJwWeN7ckn72dcS/RMONnGn7EaZMHK2PdcBbSyoX 6kyYuFnIpRCW7mPzT+ptucYB832V5x4L7njN+eCOZUlfHZy/RmkBpy6lCl6LFCShJHSR OTsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hum8GyG3YMlF2j+bxEQbnrEJdDI8ZwOXjUuAUt+nY5o=; b=gRelk+hhXBGVGU0HIb+FoOUCYjpfJjUxicMgphURYAoWR5gscA/Bld7TgsmIGGVM62 4XTf4GsXkL0NQHdtbyLKK+sCTQWvOmOqJPKOyy7HGJT8W1ushvJAgogf1yTrsLnEOkNj qsQ42FtoCQm662tKvgWGRxBAmkFD0kWX2oVqTt69ieeAm79ZnR5uFIjGkzr81mVKtLNO eH1byTotrXT0CJEZypVGCWosZGnrDO2/Ix0u0j/lCjenpXZAqYU2ygok8P99rQ/UF1uC 8C6EK3xwvhnmDbFG102gjHOy6jp3rU8yo1GS87AfeAWLoRHBsPBN9woj7V2V/xTh+LU0 /mww== X-Gm-Message-State: AOAM532J74KxWHXE3SqQHOlj8NniFJz546sYXXk3DxiFUnyqT/y+IXkb b6x8kNdwK6t0aYszC0YhLLIhaz9n58kUr7q6RvQ= X-Google-Smtp-Source: ABdhPJyJaxgJMfUXIfDa3mHs8m3ahoENpeSe735GUb4ZErj5SmpdGwF3yo0BrKjfh5HDkbATF/1dB2+wWsP+ziud/8A= X-Received: by 2002:a05:6402:1c8a:: with SMTP id cy10mr3106450edb.151.1610567356100; Wed, 13 Jan 2021 11:49:16 -0800 (PST) MIME-Version: 1.0 References: <20210112214105.1440932-1-shakeelb@google.com> <20210112233108.GD99586@carbon.dhcp.thefacebook.com> <20210112234822.GA134064@carbon.dhcp.thefacebook.com> <20210113184302.GA355124@carbon.dhcp.thefacebook.com> In-Reply-To: From: Yang Shi Date: Wed, 13 Jan 2021 11:49:02 -0800 Message-ID: Subject: Re: [PATCH] mm: net: memcg accounting for TCP rx zerocopy To: Shakeel Butt Cc: Roman Gushchin , Arjun Roy , Johannes Weiner , Michal Hocko , Eric Dumazet , Andrew Morton , "David S . Miller" , Jakub Kicinski , Linux MM , Cgroups , netdev , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 13, 2021 at 11:13 AM Shakeel Butt wrote: > > On Wed, Jan 13, 2021 at 10:43 AM Roman Gushchin wrote: > > > > On Tue, Jan 12, 2021 at 04:18:44PM -0800, Shakeel Butt wrote: > > > On Tue, Jan 12, 2021 at 4:12 PM Arjun Roy wrote: > > > > > > > > On Tue, Jan 12, 2021 at 3:48 PM Roman Gushchin wrote: > > > > > > > > [snip] > > > > > Historically we have a corresponding vmstat counter to each charged page. > > > > > It helps with finding accounting/stastistics issues: we can check that > > > > > memory.current ~= anon + file + sock + slab + percpu + stack. > > > > > It would be nice to preserve such ability. > > > > > > > > > > > > > Perhaps one option would be to have it count as a file page, or have a > > > > new category. > > > > > > > > > > Oh these are actually already accounted for in NR_FILE_MAPPED. > > > > Well, it's confusing. Can't we fix this by looking at the new page memcg flag? > > Yes we can. I am inclined more towards just using NR_FILE_PAGES (as > Arjun suggested) instead of adding a new metric. IMHO I tend to agree with Roman, it sounds confusing. I'm not sure how people relies on the counter to have ballpark estimation about the amount of reclaimable memory for specific memcg, but they are unreclaimable. And, I don't think they are accounted to NR_ACTIVE_FILE/NR_INACTIVE_FILE, right? So, the disparity between NR_FILE_PAGES and NR_{IN}ACTIVE_FILE may be confusing either. >