From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89040C433ED for ; Thu, 20 May 2021 22:51:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2AA8961074 for ; Thu, 20 May 2021 22:51:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AA8961074 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 969D66B00E5; Thu, 20 May 2021 18:51:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9199B8D0001; Thu, 20 May 2021 18:51:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76BC86B00E7; Thu, 20 May 2021 18:51:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 440DE6B00E5 for ; Thu, 20 May 2021 18:51:18 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D24D0180ACEFB for ; Thu, 20 May 2021 22:51:17 +0000 (UTC) X-FDA: 78163106994.34.8A9FCAB Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf02.hostedemail.com (Postfix) with ESMTP id 6844740B8CC9 for ; Thu, 20 May 2021 22:51:16 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id lz27so27703719ejb.11 for ; Thu, 20 May 2021 15:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WnulEUF+qKEePwDXKxeGeGtxQA2bAguCelUNMLELUoA=; b=GAEOzlTCEDBcqsbziiyhHvnbiwoI/+0tvlRfIN4UM/d1viE38G2LMCs0q8up8/q+cO 9znHTzyhGCmW/bndJ+/nJgzFGu5jBFIFco/O0GPX0RCUVeuGHidqyc0VLPQzuR+IwMH8 3XRCW2ZpCSvWCYawNxeY5l7bcwQO5nYXjG0atA3pnPoNlHWBMVkmp6JYxWzVj20le1zT TAxJdfJqUHtt0yZnCbWE/MCHd7iOS3KoOihcJbQ6ADtDrRYCA+MdB+RMRxUw+7gajRhm V2pjG/u5/bt/MaVnkWCbAg8ftgdSOPH0rmBvd9GtrqbFusYSjO0ZV7kLcxkXIQC5niA1 yFFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WnulEUF+qKEePwDXKxeGeGtxQA2bAguCelUNMLELUoA=; b=IjSdMl8elb0zUSkmGBv8bM7lUgKVAhbHUPN7B3hQbyw3IF5fN1BCfEdnC4XAK13nwL LcSSHV7zOyC57ZVbM3QENMANJMV4Cd+Td6j6v7jdpC38Q9GtQrqbcCtELJgsY82Y1jsu ToTD3GwiPXMi6vLEZjLMghk5Rq+BQF90Pm16acucnjL1oEDDEWeZnu4PcdVm0BXnxJug z8CF7LCT9FT3CDM2K/61V3V2uqCq/yQlULq3UHOR/xYPYstI9etI7PK2ZJxWmd4uhNAn 2FWMJnt0bgg83+jJVC1sKzSxt+LlbzHT7e7ohyIEh4F4SbvXCzmkl6NbtmrQMNcm0s6e DpMg== X-Gm-Message-State: AOAM5317iz/r+yigjkdHL7XnuiB0hTvuQWSWJ2cRZgVmxq5OkJSg6iTo rGyCnjt/dBGRc6altN43aB2OPQ8GUC6tGpi8ULo= X-Google-Smtp-Source: ABdhPJzgnN4yFnHN23Q4Dpkk4qLOzNWWiWZYntyQKHmMNx3p9t8PwBqS0hk57D6bHXhfUC0FOO9DH0p0xp498ntZSvk= X-Received: by 2002:a17:906:2dca:: with SMTP id h10mr6765363eji.507.1621551076357; Thu, 20 May 2021 15:51:16 -0700 (PDT) MIME-Version: 1.0 References: <20210520084809.8576-1-mgorman@techsingularity.net> In-Reply-To: <20210520084809.8576-1-mgorman@techsingularity.net> From: Yang Shi Date: Thu, 20 May 2021 15:51:04 -0700 Message-ID: Subject: Re: [PATCH 00/14] Clean W=1 build warnings for mm/ To: Mel Gorman Cc: Andrew Morton , Michal Hocko , David Hildenbrand , Vlastimil Babka , Dan Streetman , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6844740B8CC9 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=GAEOzlTC; spf=pass (imf02.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: gsdm99np7x35mziksc9x1td5sdcgxdst X-HE-Tag: 1621551076-23175 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 20, 2021 at 1:48 AM Mel Gorman wrote: > > This is a janitorial only. During development of a tool to catch build > warnings early to avoid tripping the Intel lkp-robot, I noticed that mm/ > is not clean for W=1. This is generally harmless but there is no harm in > cleaning it up. It disrupts git blame a little but on relatively obvious > lines that are unlikely to be git blame targets. > > include/asm-generic/early_ioremap.h | 9 +++++++++ > include/linux/mmzone.h | 5 ++++- > include/linux/swap.h | 6 +++++- > mm/internal.h | 3 +-- > mm/mapping_dirty_helpers.c | 2 +- > mm/memcontrol.c | 2 +- > mm/memory_hotplug.c | 6 +++--- > mm/mmap_lock.c | 2 ++ > mm/page_alloc.c | 2 +- > mm/vmalloc.c | 3 +++ > mm/vmscan.c | 2 +- > mm/z3fold.c | 2 ++ > mm/zbud.c | 2 ++ > 13 files changed, 35 insertions(+), 11 deletions(-) The whole series looks good to me. Reviewed-by: Yang Shi > > -- > 2.26.2 >