From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97067C19F2D for ; Tue, 9 Aug 2022 17:17:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D3938E0002; Tue, 9 Aug 2022 13:17:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 383B18E0001; Tue, 9 Aug 2022 13:17:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24BA88E0002; Tue, 9 Aug 2022 13:17:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 15C4E8E0001 for ; Tue, 9 Aug 2022 13:17:01 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DF69C1610E5 for ; Tue, 9 Aug 2022 17:17:00 +0000 (UTC) X-FDA: 79780709400.02.E2C4D5D Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf17.hostedemail.com (Postfix) with ESMTP id 65C0640170 for ; Tue, 9 Aug 2022 17:17:00 +0000 (UTC) Received: by mail-pg1-f170.google.com with SMTP id h132so11928222pgc.10 for ; Tue, 09 Aug 2022 10:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=gu/ADwJi3t0Jblxt3mkW75ioV1NEMLy3raBP5kzU0lo=; b=Ri+kiivl7PP55O7l69I+GTjZSb17Cb0nabu/wlFXF701lZUFf6kRcUE3w66fMkNLU+ jzmGyPpH90cSxUpO3DMjXKtNhgE1lxEEo6i1vABrOywT0Vx8Y/nB+ysge2QHEnVYYfPR H+MCaNtu0KDf/RYS6xbyN64dbmOQaambENrIMcKDgbvxh6bzhYmeDSlTmVv8cPFwKJ8v xABbab3BfofT1VufwuwvYBU/UEwdlpSNxZ0jLtEK09WsmKWROFX0LrlgJzqJ4q9O0SZ7 4mgOexGagiwt26ox89AAAupFO2n+ttGX+uhhjHF35GKVfpU8QnUNgUijz39cBD6MIC5E iSKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=gu/ADwJi3t0Jblxt3mkW75ioV1NEMLy3raBP5kzU0lo=; b=vEAXiK25ueWsA5gj60cnn7mF8lmCCwi9mMKkc7ZAdUDi/S4Ex9pBAH9SI4H21p7ELf ieyWQ/PcklRtqc44rAtDG3ufyfhyiiVAuDlxj6WbP2yT9uYspwk7C3JrXpqsP67VBX2S 7PD1wfBRatLIrkUZbQN4iyGHeBJ0A4qGZD53QWRkRO3ENVKar6ADCv15bXiJ9kPIPzup WAAa/yg1wsjvegZI0wZBo1iEgxzb2SGrlBGaC3ytYn8dhZ6EilAVHD3bXN970HXqQEEG /SL25F9j/XVQziA1ewSXYeoBao2HbaN2788ZEx3eBZAUNoBzf672UaHrI/Z/9FvO5+B4 3VPw== X-Gm-Message-State: ACgBeo0V04o3LpiCyn98NPKEA4Tvd2bMoUlD+InPmDWhXhW1nxEtPHvS u+4z8zxsYTTGzk9+I2FwmcS6mkREYNyzf0160D4= X-Google-Smtp-Source: AA6agR7+DZJ3Oe0xzRTHubTmyEKvSYFs4bfWYnhhTCdFFRYlCCD/WlIFRvO14rjVA+XnChbZ73C2niBmEzhBxMDQjGY= X-Received: by 2002:a65:5503:0:b0:41b:bbdc:9a5d with SMTP id f3-20020a655503000000b0041bbbdc9a5dmr19608787pgr.587.1660065419344; Tue, 09 Aug 2022 10:16:59 -0700 (PDT) MIME-Version: 1.0 References: <20220808164658.5079a9a0@imladris.surriel.com> In-Reply-To: <20220808164658.5079a9a0@imladris.surriel.com> From: Yang Shi Date: Tue, 9 Aug 2022 10:16:46 -0700 Message-ID: Subject: Re: [PATCH] mm: align larger anonymous mappings on THP boundaries To: Rik van Riel Cc: Andrew Morton , linux-mm@kvack.org, kernel-team@fb.com, Matthew Wilcox Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ri+kiivl; spf=pass (imf17.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660065420; a=rsa-sha256; cv=none; b=HUrhCQMN+8Du+uzI6KMIJiSfYQF8JBQbXWguM2XohNz9Knxj3uCDO2MDea8G0fnF0fr1iN gbZG1HfxVjW8QOlbGsY8ridfORkGFxPgbfEQIe+XSorN3ddBdG2Qi2vD9ajugFjt63h/bT jy7zG02cVyAf/CPhqeBtAKVVqLJbGjg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660065420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gu/ADwJi3t0Jblxt3mkW75ioV1NEMLy3raBP5kzU0lo=; b=aAyEFmf889qwCw0weamQ6T2j+ez7jANLs84bkgY6F3DrabesMnh+ET4dXlAtHpWUSTgJxE WY6Hl07n4zWCLuw21DFHk11LtvZEUY31S1v4f82OxL5CTZxi0zumxv5ippjOLmgtIEgrdX ge2z3LmbF6hoewdeaY3B5tRyJo8UyLA= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 65C0640170 X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ri+kiivl; spf=pass (imf17.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: xca3p16x9mawc3cixfsqq5e35mqphgjp X-HE-Tag: 1660065420-948962 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 8, 2022 at 1:47 PM Rik van Riel wrote: > > Align larger anonymous memory mappings on THP boundaries by > going through thp_get_unmapped_area if THPs are enabled for > the current process. > > With this patch, larger anonymous mappings are now THP aligned > when checking in /proc/PID/maps, but only when THP is enabled > for that process. > > Signed-off-by: Rik van Riel > --- > mm/mmap.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/mmap.c b/mm/mmap.c > index c035020d0c89..3a9d19cec690 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -2229,6 +2229,9 @@ get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, > */ > pgoff = 0; > get_area = shmem_get_unmapped_area; > + } else if (test_bit(MMF_VM_HUGEPAGE, ¤t->mm->flags)) { There is a kind of chicken & egg problem here, MMF_VM_HUGEPAGE is not going to be set if there is no THP eligible vma even though THP is enabled. > + /* Ensures that larger anonymous mappings are THP aligned. */ > + get_area = thp_get_unmapped_area; > } > > addr = get_area(file, addr, len, pgoff, flags); > -- > 2.37.1 > >