From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D20C433F5 for ; Tue, 25 Jan 2022 17:45:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FFE96B0074; Tue, 25 Jan 2022 12:45:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AF496B0075; Tue, 25 Jan 2022 12:45:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64FC16B007B; Tue, 25 Jan 2022 12:45:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 530BB6B0074 for ; Tue, 25 Jan 2022 12:45:15 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0ECB88249980 for ; Tue, 25 Jan 2022 17:45:15 +0000 (UTC) X-FDA: 79069535790.17.CBDBEE7 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf06.hostedemail.com (Postfix) with ESMTP id BD77D18007B for ; Tue, 25 Jan 2022 17:45:14 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id z22so64469497edd.12 for ; Tue, 25 Jan 2022 09:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wLbqBjI2QnhR5W9uEc5kkHoAs2Fwdz+cZ7biUUiwy8I=; b=XI+wODe5OVLQqTQfMtV40bTEaKsreLM3EPk019QiGLOikHZQw2tz4GUN/nEsn3qY9g VS/GjD06yJHcWVGcUTR5DLpphOlZEUhQkrray2nW8tEqDuaXHmKm2w9G9lXgmF56nJlL y4Xmc8N2EFRfMfiEr+4IwSVxKKw0ZD6zgcQusWP3L0bOjw3fEY1DdDtm4y4iQ4oYzZZD ZMLdPdbJ59kN143+7jOdGXVCDaT/G0MQB+Y7gpLmnjnffCAvEswRbc8rijNM+w3YzriD nAxYRZxTlW1iMkMPRluiEcO7ZW3UQphCfeIcBJ26vr3mRojCFk6VqLyhyyt9SaMn5S6e tu8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wLbqBjI2QnhR5W9uEc5kkHoAs2Fwdz+cZ7biUUiwy8I=; b=4HUUr2tvvohCG4oVpczhw/mcX4twFWMjG4O1gReNVNIVgnNP0GTsK9q0FRutTEi5YW zY7qedmC4hoLVZBiENFl15Gpb/u2uaZmaUSG21CLLQMQs4J3UWomHAdDrY/Zu0mXFfrx 6pa6FTNQIZJzwzaOU6Qi05ePdGOrJyhWlsXszjg3U/t3R8BRQ+kcHjegULRB664Y9VXC U205nLy5H7cUX0Sgz4CF52Os1++KgGEjMOrOjFb1So/wGmcXWZVt657s4xklMCJmSpJB LiqcZtu4dDqkM1HSbCzGVLFcSDWrfJVH1PClHZlxDF3lzm7AIZKGpZSke8+0nHbpq+4h Qggw== X-Gm-Message-State: AOAM532ccCjt7vQLtT9DnXlObeAOsODv5rDIb/yG2zg0tsrTSWQojW5c ypV6h8bpkYmXKLJNOMYxRogjukynO3FYWti3uIg= X-Google-Smtp-Source: ABdhPJy7sDNAtxM6nI6YrtNMouAdltvqi5H3GTLWL14Ws7Rtx1o1qgjY/BjnpCqfjcgQpU+bXrah2e6sBPMvn/ALJhs= X-Received: by 2002:a50:cf86:: with SMTP id h6mr21975916edk.82.1643132713452; Tue, 25 Jan 2022 09:45:13 -0800 (PST) MIME-Version: 1.0 References: <20220125025601.3054511-1-naoya.horiguchi@linux.dev> In-Reply-To: <20220125025601.3054511-1-naoya.horiguchi@linux.dev> From: Yang Shi Date: Tue, 25 Jan 2022 09:45:01 -0800 Message-ID: Subject: Re: [PATCH v1] mm, hwpoison: remove obsolete comment To: Naoya Horiguchi Cc: Linux MM , Andrew Morton , Mike Kravetz , Tony Luck , Naoya Horiguchi , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XI+wODe5; spf=pass (imf06.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: nil X-Rspamd-Queue-Id: BD77D18007B X-Stat-Signature: d9d4skicp4dipiygoar6n6h6zs4nxcqy X-Rspamd-Server: rspam12 X-HE-Tag: 1643132714-966319 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 24, 2022 at 6:56 PM Naoya Horiguchi wrote: > > From: Naoya Horiguchi > > With the introduction of mf_mutex, most of memory error handling > process is mutually exclusive, so the in-line comment about > subtlety about double-checking PageHWPoison is no more correct. > So remove it. > > Suggested-by: Mike Kravetz > Signed-off-by: Naoya Horiguchi Reviewed-by: Yang Shi > --- > mm/memory-failure.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 4c9bd1d37301..a6a1e02759e7 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2146,12 +2146,6 @@ static int __soft_offline_page(struct page *page) > .gfp_mask = GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL, > }; > > - /* > - * Check PageHWPoison again inside page lock because PageHWPoison > - * is set by memory_failure() outside page lock. Note that > - * memory_failure() also double-checks PageHWPoison inside page lock, > - * so there's no race between soft_offline_page() and memory_failure(). > - */ > lock_page(page); > if (!PageHuge(page)) > wait_on_page_writeback(page); > -- > 2.25.1 > >