From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C366C433F5 for ; Thu, 4 Nov 2021 17:44:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D811060EFE for ; Thu, 4 Nov 2021 17:44:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D811060EFE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4C7B7940007; Thu, 4 Nov 2021 13:44:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 477966B0072; Thu, 4 Nov 2021 13:44:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 365E1940007; Thu, 4 Nov 2021 13:44:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id 286D06B006C for ; Thu, 4 Nov 2021 13:44:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C92DD181BCF0E for ; Thu, 4 Nov 2021 17:44:01 +0000 (UTC) X-FDA: 78771971082.30.9A81DB8 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf28.hostedemail.com (Postfix) with ESMTP id 7D6E090000B6 for ; Thu, 4 Nov 2021 17:44:01 +0000 (UTC) Received: by mail-ed1-f41.google.com with SMTP id g14so23681584edz.2 for ; Thu, 04 Nov 2021 10:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SaoNZd94jArTmVGn/jRfCzD6DEp4wsUPuwPe5TNdHKA=; b=Ci5zimqbv8P1cMefPHzbCNeFUUN8LJw8Y64xtBRDBYcVGncRiKkUApmWPgiZSVOwNh eEcSUytkkKxJYJuWZ8JEv1/fYRI+7ml4Gd2k3Me8jItIDOCl3Jos3+LN8nDrf+rKKy0F aA6Hx2u1dvMUGB3jtkwWYzKO2jndLVJXDdwEetiMZ6/qPNmV7ESiRPzNsCKLEMR2yyKB 55LRGk1WD9xJ9GHmTGsfS8mFy1kVbKipwOZSGQJdIa3AFrsuccTXIu+jlZ2yVJhskbM6 9YCQd3w88SmPEqDRkQuXlyVF2gqf+KYAYoVVNnCn7LzDc3PDv7vjxwNYmLf5ZPoB/k00 Mauw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SaoNZd94jArTmVGn/jRfCzD6DEp4wsUPuwPe5TNdHKA=; b=gygmZ6TEnte3KcTqq0ryI/oL4JyYqZZPZnWa3KcEKZu2nvOzZyIkT6AbQ6FqegqObz Ftp7/JKKEncLMWWnZ5VurVOH4Aq5WnAwX/zaVCvPWX/795nNivKvnkFbzV0l8nUEJ37p y1i3RpzyTLNGrtl+ivnheGdLP9bCM4Y3U2Ik0AAmShgnrLIXdCPGPFnhODGtIGqSiTAD NT1TBwDJJEGhSxWYi8RIvNDbebr/oSe0tM4Ie7ZyGgZH80sOAbxyuZ4yPrg744+fMcmy kBRyfAJWU1F1/qICvsNqccoJm1zFAkL5+LJCyPV0goHqgmeNl9JaZ2dE8VRHr0b+H+0b mheQ== X-Gm-Message-State: AOAM531iAIpnolTKPycr4P9VaPYSqIMnH6swlhRweWsO2FyC/7pRjU6V P0R7M0BRXdMaGRDHNCOS1hUXntq88mebhmM7kzo= X-Google-Smtp-Source: ABdhPJxjJVjhCFczPSEV79xEXIH2iDBKSXc5wLai7n6k3tdNY0aTKGZTGE6HhigLRtDP94cd/1k3YlOAqioLJn3YXKo= X-Received: by 2002:a05:6402:520b:: with SMTP id s11mr28768622edd.363.1636047840071; Thu, 04 Nov 2021 10:44:00 -0700 (PDT) MIME-Version: 1.0 References: <20211101194856.305642-1-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Thu, 4 Nov 2021 10:43:47 -0700 Message-ID: Subject: Re: [stable 5.10 PATCH] mm: hwpoison: remove the unnecessary THP check To: Greg KH Cc: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Oscar Salvador , Peter Xu , Andrew Morton , stable , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7D6E090000B6 X-Stat-Signature: fisjccbcrua9xauqsr8npmtqhsq8mjk1 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ci5zimqb; spf=pass (imf28.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1636047841-627067 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 4, 2021 at 9:53 AM Greg KH wrote: > > On Wed, Nov 03, 2021 at 10:46:24AM +0100, Greg KH wrote: > > On Mon, Nov 01, 2021 at 12:48:56PM -0700, Yang Shi wrote: > > > commit c7cb42e94473aafe553c0f2a3d8ca904599399ed upstream. > > > > > > When handling THP hwpoison checked if the THP is in allocation or free > > > stage since hwpoison may mistreat it as hugetlb page. After commit > > > 415c64c1453a ("mm/memory-failure: split thp earlier in memory error > > > handling") the problem has been fixed, so this check is no longer > > > needed. Remove it. The side effect of the removal is hwpoison may > > > report unsplit THP instead of unknown error for shmem THP. It seems not > > > like a big deal. > > > > > > The following patch "mm: filemap: check if THP has hwpoisoned subpage > > > for PMD page fault" depends on this, which fixes shmem THP with > > > hwpoisoned subpage(s) are mapped PMD wrongly. So this patch needs to be > > > backported to -stable as well. > > > > > > Link: https://lkml.kernel.org/r/20211020210755.23964-2-shy828301@gmail.com > > > Signed-off-by: Yang Shi > > > Suggested-by: Naoya Horiguchi > > > Acked-by: Naoya Horiguchi > > > Cc: Hugh Dickins > > > Cc: Kirill A. Shutemov > > > Cc: Matthew Wilcox > > > Cc: Oscar Salvador > > > Cc: Peter Xu > > > Cc: > > > Signed-off-by: Andrew Morton > > > Signed-off-by: Linus Torvalds > > > --- > > > mm-filemap-check-if-thp-has-hwpoisoned-subpage-for-pmd-page-fault.patch > > > depends on this one. > > > > Both now queued up, thanks. > > This breaks the build, see: > https://lore.kernel.org/r/acabc414-164b-cd65-6a1a-cf912d8621d7@roeck-us.net > > so I'm going to drop both of these now. Please fix this up and resend a > tested series. Thanks for catching this. It is because I accidentally left the PAGEFLAG_* macros into CONFIG_TRANSHUGE_PAGE section, so it is: #ifdef CONFIG_TRANSHUGE_PAGE ... #if defined(CONFIG_MEMORY_FAILURE) && defined(CONFIG_TRANSHUGE_PAGE) PAGEFLAG_xxx #else PAGEFLAG_FALSE_xxx #endif ... #endif So when THP is disabled the PAGEFLAG_FALSE_xxx macro is actually absent. The upstream has the same issue, will send a patch to fix it soon, and send fixes (folded the new fix in) to -stable later. Sorry for the inconvenience. > > thanks, > > greg k-h