From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E77C6C61DA4 for ; Wed, 15 Mar 2023 21:06:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DAC76B0071; Wed, 15 Mar 2023 17:06:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48A156B0072; Wed, 15 Mar 2023 17:06:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 353136B0075; Wed, 15 Mar 2023 17:06:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 27D806B0071 for ; Wed, 15 Mar 2023 17:06:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D2350A11FD for ; Wed, 15 Mar 2023 21:06:42 +0000 (UTC) X-FDA: 80572366644.16.688FD31 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf02.hostedemail.com (Postfix) with ESMTP id 703B380011 for ; Wed, 15 Mar 2023 21:06:40 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Sq9sDYEU; spf=pass (imf02.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678914400; a=rsa-sha256; cv=none; b=C2hhML3dJIfXGZTzHIt5QeG91BosK1WdYbJTnpHPfhnQ+PgM4VbVkTXxQToITVMmBWxcP9 tlltO9CmyUtvC5kmjTtEQVQGD5XyU0ZfBbTJcvW0+8mrNSwJDL7uAt+Nmwbm+oR9MtUxMu 4g+p/PZZypZCpZQeOFGtIEaOuVrj3mk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Sq9sDYEU; spf=pass (imf02.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678914400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iKYYaPT5Is0MJH9ud4+ebRYb/vJAs/FQRvpTFpyZc7Y=; b=UGL3XjKDI1dc35rWd+o3cbddQOFPRpD/tfGu7D0MYJcahGlj1AyukE8wzBznn7aTVJBDq/ VXwEhfU9x6hUiRZa9NDBeEfx0A22/0t5DQNttdpvtBG891Do+53MBWH4IL+Haqr2ExY8Y6 fqB++1zjvgB5k9KJ423glTzTKYrvirE= Received: by mail-pf1-f178.google.com with SMTP id ce7so12547626pfb.9 for ; Wed, 15 Mar 2023 14:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678914399; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iKYYaPT5Is0MJH9ud4+ebRYb/vJAs/FQRvpTFpyZc7Y=; b=Sq9sDYEUQPSqrreoT3iByu/xaaOclmqRZ4BZ8oTI6ZByIhmIYt4vvpr3yoyLDGEc+r Bh7IOxubKomnUk8OzozZQ84IitmdmnZsQeNtAJ2lXdUfFP5DQx6IFVUgsMIU0OOS1GEn FPbbthhFVHIMmx00Vm13rQJVZc3/Tal/GJLmF/rZjejSfB8bOAV2lIodf7JJX20QYHOw oHJtOJ+pfoeWsKBvIT/NfdUjCQ3mzBBmv9Ws33pREk6tO+zc12OhPo1kd21gxUjbIAol x925KwtHGn+x9bOAvOVy1icbNxQtwwmZ7JOZ9cim3RJ/aCQaSCjIUzPhfsYvQs0gad5O 8z8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678914399; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iKYYaPT5Is0MJH9ud4+ebRYb/vJAs/FQRvpTFpyZc7Y=; b=Q9U/t6rOkWGGy+zmQIBFV53BaPyXnIYLqIHgz9ggHUqT6oVbQzHfVii9AUCH/iUehF eMz4fMVRRpttNZJvCTWF/+FipAYCKRYPA7CaFi4yjmcnrEXi2CGOttsuJtvIOTgX6QVn iNkTwQ4qhuo8x74pszqHLODS7zwcD76Quc0PoaO/31soknswiQaOtetykEi9SegQ7slo hY2qF56PWqR1yR9wh74YlfrLCYxfvSYWaAeLb6j6St6w5+GCpvBYzznE5QLHTuBKzuje uXSfOAnWVtNSJmZ7Xyb7TPWFaOqJYgLcH1an994ElEFwejKDJEh5fH4Ap6jW+T/2Obek V3ig== X-Gm-Message-State: AO0yUKXIBjmkEgeon2Av6MrvpfdvLzBuTbk3bjFecRHsGM5+37cf9Oca uVV/GEBOKei4KYewa/WioFbpc5BCWn408nD1fws= X-Google-Smtp-Source: AK7set/vin/gH7uqM0zKWCc7qnMyrIM4uNDSSRFlUr2NYSPDlXh+VQAl1j6lpXoUOiTtYyPA3BhG/uIwYAg/RIHJzP4= X-Received: by 2002:a05:6a00:2d0e:b0:625:dc5b:9d1d with SMTP id fa14-20020a056a002d0e00b00625dc5b9d1dmr550388pfb.0.1678914399119; Wed, 15 Mar 2023 14:06:39 -0700 (PDT) MIME-Version: 1.0 References: <20230315171642.1244625-1-peterx@redhat.com> In-Reply-To: <20230315171642.1244625-1-peterx@redhat.com> From: Yang Shi Date: Wed, 15 Mar 2023 14:06:27 -0700 Message-ID: Subject: Re: [PATCH] mm/thp: Rename TRANSPARENT_HUGEPAGE_NEVER_DAX to _UNSUPPORTED To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Aneesh Kumar K . V" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 703B380011 X-Rspamd-Server: rspam01 X-Stat-Signature: ad9zf6qnow7xh3fkxs1ozi5a9b3gbtmz X-HE-Tag: 1678914400-622689 X-HE-Meta: U2FsdGVkX1+HRuvJ8Ffn3mcmiCh2TQD5n+7Lh5wrANBaaJXw+ZRizrf2abUNFxsimLp7zftVnaXv2GfN5kjHGSQqRFWqfhj3ZqmtOTqXzEKxYPQMvEHB8hlxDCREN3L6me2ZDtiYdch+Hd4Hx8asdG0Bm2yMAyWvgOYbO3smrtIJo+4qN5DxkXydFNpO/ict3ASWTeHFEMvS3V0FwNaZgKtJSskr0r+MPfjiIdGNiFivIq4N5wdH8oihQaiCICpMFOGlemfKgTgCsjKdpgWwsLdZA5YOUjXUE4SfK4QDCH6eJoafdMSLZWVq3fRd9vSm3Dm+v8Oi0S/TouanbDUU07a0UPZuwH0eOoTQCYDwn9DvgjErke59xsYyPrEQtICie4p5m8WdV7DvAR7ghxAqhvZbZN2rJmpaBNxpSXTzBfpp5W0lgLfFeZcdXCuOBOaYMxQsPHswlLV4xox9caVAEih+acfVGPOOanRviwRiZfZ5dH2arU1iAz1/So5PrR9mjipk6Yi5lFpzJcymO0rGcbFvI9VK0CalibmqNnjWtzNTV7bTP+AyPIpIY4JOurSTeS5nCfbGbqj20MjT2J24rx+d6XcvS08ZEzu46dCWrv0WYfpiNFYQ824gWM5wqXZktS/vZhuQNkoVfWVcezZKqiyoBOITfAQ/agwzvmTeOZfarHc/YYjztSYwApbUg5cblMfghHHoSTz4rwR07mbAwoPqAKMsbfHWybm5IXtBJXfxUAqu2GPq0DPV9PKBZiTfawSpVmSsBZ3Cr4bUdzti9RcayRu3EjdEqwgFP8qKEuuL1RVvjgX7DW7iFpELQ5sGvHOt/THHf/z8dD9qLyx6x5y9VMek/ga7DheG7lp5q1hyutQI5TY0iY2wrtLq1LmxR+v/z62UVfGk1zGnFX+EAdElPSZv1vvveDRDpUMLljYyMe3UY4XIIoO7IaNZye6YFtiLZ3miO8y3x0F8sDc riU3USOz 2+oDVRHlqx2AEDm5I4/y34Wztc0EF2106c0o+vM2QU3Mpsq6PKfe3i+IaorvY9BEvsAqZhyjCpWbFArgg9ssMJPmXaqIdERH7DvRz1aZA2IPK9XeY3hWFKfGuQ1lOZz/PygeLaRf6lIuBUIFjaK9guriTSezG+fZ+Xl0peucWmMEyYHRRcSpcxfhlIXfKhR0wfjsz7Soyy6JokVqAbun9wMeJULxmqIBak1H2GvAQ75PrX4z4arfAApXwsdYM2c11ogpMl/kpu4A2vwfBwhNAD46VVrzuB1NQNWlamlnkqDTXCr4UJd4e0EZUnQPPD4+F8fVAUh4O5Z9LCLuFFxHeufkg8J0u0Xu2VOljjzWMDRvkqNUT0bHelg8bdzLVP9U3TULLhVkH7xZBW6CTTAhNVK9arDRSX04xlt7X5frtgRJxGc2dzAGwgvFiTwZtjkSpvCgnUtZf2BascwxRUEiBVtD7disv818TjFwYwzSJ69lfllw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 10:16=E2=80=AFAM Peter Xu wrote= : > > TRANSPARENT_HUGEPAGE_NEVER_DAX has nothing to do with DAX. It's set when > has_transparent_hugepage() returns false, checked in hugepage_vma_check() > and will disable THP completely if false. Rename it to reflect its real > purpose. Makes sense to me. Reviewed-by: Yang Shi > > Cc: Aneesh Kumar K.V > Cc: Yang Shi > Signed-off-by: Peter Xu > --- > include/linux/huge_mm.h | 2 +- > mm/huge_memory.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 70bd867eba94..9a3a3af2dd80 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -79,7 +79,7 @@ static inline vm_fault_t vmf_insert_pfn_pud(struct vm_f= ault *vmf, pfn_t pfn, > } > > enum transparent_hugepage_flag { > - TRANSPARENT_HUGEPAGE_NEVER_DAX, > + TRANSPARENT_HUGEPAGE_UNSUPPORTED, > TRANSPARENT_HUGEPAGE_FLAG, > TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, > TRANSPARENT_HUGEPAGE_DEFRAG_DIRECT_FLAG, > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index b0ab247939e0..913e7dc32869 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -88,7 +88,7 @@ bool hugepage_vma_check(struct vm_area_struct *vma, uns= igned long vm_flags, > /* > * If the hardware/firmware marked hugepage support disabled. > */ > - if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_NEVER= _DAX)) > + if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_UNSUP= PORTED)) > return false; > > /* khugepaged doesn't collapse DAX vma, but page fault is fine. *= / > @@ -464,7 +464,7 @@ static int __init hugepage_init(void) > * Hardware doesn't support hugepages, hence disable > * DAX PMD support. > */ > - transparent_hugepage_flags =3D 1 << TRANSPARENT_HUGEPAGE_= NEVER_DAX; > + transparent_hugepage_flags =3D 1 << TRANSPARENT_HUGEPAGE_= UNSUPPORTED; > return -EINVAL; > } > > -- > 2.39.1 >