From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B23D3C433C1 for ; Thu, 25 Mar 2021 17:42:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38AB761A2B for ; Thu, 25 Mar 2021 17:42:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38AB761A2B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 778FC6B006C; Thu, 25 Mar 2021 13:42:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74F4B6B006E; Thu, 25 Mar 2021 13:42:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 619836B0070; Thu, 25 Mar 2021 13:42:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 46D406B006C for ; Thu, 25 Mar 2021 13:42:00 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E867D6EDE0 for ; Thu, 25 Mar 2021 17:41:59 +0000 (UTC) X-FDA: 77959114758.20.1693BA3 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf20.hostedemail.com (Postfix) with ESMTP id 673F12BE7 for ; Thu, 25 Mar 2021 17:41:53 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id l18so3356743edc.9 for ; Thu, 25 Mar 2021 10:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IHDykkReNSm3ZOFg7ydDzHjqeU87p4aBYX134mXqwS0=; b=U8jWh1rt8wbsrOMOgiWrInaicpU1aTZUHHFwoA1Ita/pIAdAA2N+zD5kzQaaFLaPm7 sz5OdDarqh/Rk2foLOjXlf9e1veqEA3Yx8+8IrJJEgVWdRg5QRTJsHD7qGZrVegiu7Kk /7KOTRSLAovyXZlTu3IsHtB8SH7Za1zwRuQDKm9vlBxTwvWyRWTh+UUaHsYFzICLOQ/w rPKMQ4DaoOQPrKOZYo8UHoCUxnbQQm2eVnBn2m13Hd19URD1Y0vljd6pnpApVgkjPDLf EAagTxYcLVwZm84aMRqB3q58U4N++DV3PSwxr7FSwyJZJOnvng8xaLgmnkSRlvcsP1BV E60g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IHDykkReNSm3ZOFg7ydDzHjqeU87p4aBYX134mXqwS0=; b=QVgebNm0pU/UslVJdH5GlfNBWa/vAuG7eZ2MTGpHMhp8q1zqYQWc9Utu7XdgZpHZir nNwhkAcs614dzfvilIltmATEeu382XFu9i36nIsc/p7EsTICplYF63SKEefRYoPutphm sNfAe0Pjx2+YstLtERgU7JrYHvtNqdo19xjF1d0hY7N0keo+cep7RX+/+p2eNUWPEzx5 JzuDbK0UtWDztAicV5PTvlt+uljAE1qsFxe//rC0p8PIKQ0NLKqbDEXPKfeHBXJZu6Fk D7Jkr1tOehbjQ82pKsXDtTwSutff0XLAkxNccZFxrZZQV1QuNpJt+hZtUzTR0+jMIka3 q5gw== X-Gm-Message-State: AOAM533SR6dZpliMf+tGmeyMz0MQU4Lq086fBpb3tZ6xvoSZ9dSaOUMr Vuz9Yhd/0AgB7MvuaT+KmM2ezcLbPauH4D9lWOM= X-Google-Smtp-Source: ABdhPJw+mEY8ZzQ3Maik8xS/iynh/pNdIFiPp8cPjI3hBlOWkrnp2ghRvm/M/KkdIByLOPi05qFw7vQAArqm819rSJA= X-Received: by 2002:aa7:df86:: with SMTP id b6mr10424244edy.294.1616694108324; Thu, 25 Mar 2021 10:41:48 -0700 (PDT) MIME-Version: 1.0 References: <20210325131524.48181-1-linmiaohe@huawei.com> <20210325131524.48181-2-linmiaohe@huawei.com> In-Reply-To: <20210325131524.48181-2-linmiaohe@huawei.com> From: Yang Shi Date: Thu, 25 Mar 2021 10:41:36 -0700 Message-ID: Subject: Re: [PATCH v3 1/5] mm/migrate.c: make putback_movable_page() static To: Miaohe Lin Cc: Andrew Morton , Jerome Glisse , Rafael Aquini , David Hildenbrand , Alistair Popple , Linux Kernel Mailing List , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 673F12BE7 X-Stat-Signature: o5se7trq7bzkkgzs4ajyy9fwkwo49peg Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mail-ed1-f44.google.com; client-ip=209.85.208.44 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616694113-596163 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 25, 2021 at 6:16 AM Miaohe Lin wrote: > > The putback_movable_page() is just called by putback_movable_pages() and > we know the page is locked and both PageMovable() and PageIsolated() is > checked right before calling putback_movable_page(). So we make it static > and remove all the 3 VM_BUG_ON_PAGE(). Reviewed-by: Yang Shi > > Signed-off-by: Miaohe Lin > --- > include/linux/migrate.h | 1 - > mm/migrate.c | 7 +------ > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index fdf65f23acec..1d8095069b1c 100644 > --- a/include/linux/migrate.h > +++ b/include/linux/migrate.h > @@ -44,7 +44,6 @@ extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free, > unsigned long private, enum migrate_mode mode, int reason); > extern struct page *alloc_migration_target(struct page *page, unsigned long private); > extern int isolate_movable_page(struct page *page, isolate_mode_t mode); > -extern void putback_movable_page(struct page *page); > > extern void migrate_prep(void); > extern void migrate_prep_local(void); > diff --git a/mm/migrate.c b/mm/migrate.c > index 47df0df8f21a..61e7f848b554 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -140,15 +140,10 @@ int isolate_movable_page(struct page *page, isolate_mode_t mode) > return -EBUSY; > } > > -/* It should be called on page which is PG_movable */ > -void putback_movable_page(struct page *page) > +static void putback_movable_page(struct page *page) > { > struct address_space *mapping; > > - VM_BUG_ON_PAGE(!PageLocked(page), page); > - VM_BUG_ON_PAGE(!PageMovable(page), page); > - VM_BUG_ON_PAGE(!PageIsolated(page), page); > - > mapping = page_mapping(page); > mapping->a_ops->putback_page(page); > __ClearPageIsolated(page); > -- > 2.19.1 >