From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA989C433F5 for ; Tue, 12 Oct 2021 18:02:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7AA3C60D07 for ; Tue, 12 Oct 2021 18:02:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7AA3C60D07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 20ED7940012; Tue, 12 Oct 2021 14:02:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BE55940007; Tue, 12 Oct 2021 14:02:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AE57940012; Tue, 12 Oct 2021 14:02:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id EE010940007 for ; Tue, 12 Oct 2021 14:02:23 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B82572CFFF for ; Tue, 12 Oct 2021 18:02:23 +0000 (UTC) X-FDA: 78688554966.35.2124D2D Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf08.hostedemail.com (Postfix) with ESMTP id 78D4A30000A8 for ; Tue, 12 Oct 2021 18:02:23 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id g8so2696531edt.7 for ; Tue, 12 Oct 2021 11:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mt4tK4CWEsYitFNESRdq5gQKepAHPRfQuKWF85se3SU=; b=KB1PXcwmOUmX7nb07cBlXcrMUqLhlGSrYIxMjpNQvY4wp9bhDm/X+x+P+MlBlUNRmo rIAb/7DMPXEKLsynOCMSYU5uqiAb8zEhTTu50wXdi/TVl89hxRGaD3NW+Ihfl/SwKviF geWVOTAaOczrRkmsz3UiQSKCG5mxH5ZJHENLcHTLufWt6j8/ffNepWG6BI9p+z8ZGTym 170zYv+VWAbzGe8RRwzh7nNbxmuY6gilJ6/TzK48GNk58FjLLP/cWIjfjAaQ3hsvUczP cEbeMd+UVvXttFIp5v/CZi/qYtWMkT2Fs6/8TSR5lV1D1BSbKl0+I2yj7bCAT1lkUC0+ gP6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mt4tK4CWEsYitFNESRdq5gQKepAHPRfQuKWF85se3SU=; b=k2jZw51gPew/yeM9WOu2TgUbtxq842Ll0kEvsW6h6rEcqbpmZS0t2Grswp7Epe98Rc 5wnw0Z6lOgEztDyYp6VqzZXXM8p1SV9jnrNL1LbBniEr3LRrc0iEj0liftX4SmMcJ9Pj 2zFSvYtkEfaooOxITuAWX6T0dpNURBm4nhHTbmFUCpI60YpQsTe+9Nk2vor6bhdTkn95 lO1OrV2yGcDMBXnUMZTtzXwCkIA6DM9LS2KyJzraw/Hz6IYrQPe76qLUeriNA8oZ2K4a 4mOAgzfcLWQdwjFmRuYr72Iewqook/PCaFRInGY5byRgZ8UtTyTyrieDH1zT8UWvyFfr NVig== X-Gm-Message-State: AOAM533Amzqog7PsCw0olOKTu2cjdpltAFzNKJcWR4A2T+N2bnKTIZkH NZ6GAOAOnSULYMw+hiA1QyjSck0+uw9wwvr+e1o= X-Google-Smtp-Source: ABdhPJyuIkpKy+46yE0qflE4D2DsnLc14o01sPyp4dhRjRZbwenXL07HKHkTqE8edAB9lYY5S/VYXvLb6B1Unpm71QE= X-Received: by 2002:a05:6402:5112:: with SMTP id m18mr1652051edd.101.1634061742373; Tue, 12 Oct 2021 11:02:22 -0700 (PDT) MIME-Version: 1.0 References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-3-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Tue, 12 Oct 2021 11:02:09 -0700 Message-ID: Subject: Re: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault To: Peter Xu Cc: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Oscar Salvador , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 78D4A30000A8 X-Stat-Signature: puw3gigmyec7hd3qibnx5soe4n48tf1c Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KB1PXcwm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-HE-Tag: 1634061743-559637 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 11, 2021 at 6:44 PM Peter Xu wrote: > > On Mon, Oct 11, 2021 at 08:55:26PM -0400, Peter Xu wrote: > > Another thing is I noticed soft_offline_in_use_page() will still ignore file > > backed split. I'm not sure whether it means we'd better also handle that case > > as well, so shmem thp can be split there too? > > Please ignore this paragraph - I somehow read "!PageHuge(page)" as > "PageAnon(page)"... So I think patch 5 handles soft offline too. Yes, exactly. And even though the split is failed (or file THP didn't get split before patch 5/5), soft offline would just return -EBUSY instead of calling __soft_offline_page->page_handle_poison(). So page_handle_poison() should not see THP at all. > > -- > Peter Xu >