From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD57C433F5 for ; Tue, 1 Feb 2022 18:29:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 923E48D0079; Tue, 1 Feb 2022 13:29:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D2E08D006D; Tue, 1 Feb 2022 13:29:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79B798D0079; Tue, 1 Feb 2022 13:29:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 6A1298D006D for ; Tue, 1 Feb 2022 13:29:19 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F1708180989E2 for ; Tue, 1 Feb 2022 18:29:18 +0000 (UTC) X-FDA: 79095048438.18.7D07C24 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf11.hostedemail.com (Postfix) with ESMTP id 6761240007 for ; Tue, 1 Feb 2022 18:29:18 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id ka4so56739627ejc.11 for ; Tue, 01 Feb 2022 10:29:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mP4EyjDtTGrvqxHN8nh2Bmr+7fmCKpgGCdhP+Ipwfsg=; b=FUjdGPY4Ibsu65A439Yis7dUvvuwYlClwb5wZgWyq39fVGm/NmY1aPpgO/gFbvwBjR 1SFwi3Kh13NLNUZKTfd3KlVnDAAbb+VMn1fIw5nbQL0jFvl8qZdPwKkR+vLPo/GBliMI +8RU0Tw01+QIBdtCAoM2jdCX8Uih78tme0h+5Pk5xBoDUG//1mTksXqtf0Qgq1eva+87 IKAU6Ud5m8r2oQR+RH+vxmUGc1DIJVdBc7onXmqD3hl9PKAVC4Lkixj+wDwpUHPcIzpd yId0zwrAnRHZgUgrXjVOSx6ehJmR2V9mQ83A5hQB+KOARf33cNzMKUb+7pzpT641uXD8 JYBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mP4EyjDtTGrvqxHN8nh2Bmr+7fmCKpgGCdhP+Ipwfsg=; b=7UWyEGZWLoqy+www3xzd+zPq3+3Rp8K6EVPPj/10P3PxFYlSRIE1KEAxyraL0T8swj 7gA3oJrWpysFf29Be0uXYRY8+q5kQSaC/+c0WVJ4LcmNK0Eqr6/27R2BYiJUk6e4NXmy GU7UVryIx2Jf0vexkfdRl0t9IsQyQTq93iuomHTVvoYpTK83Gg1Rm+a/8GzJdDRoB/HZ EVmDFIkskinwAKAKDDRCNNNCQVNhwPB6h2zH15kQeWyPHJAH3f73sEmplXkcuo61zy9a pYqGBatAb+v0S5JH94ZmzMFoM8epTiYmsTjzkUBTN838bxyyXYUSnrK3sXQmGZErBq3J ZDZg== X-Gm-Message-State: AOAM533rPtOG7tNfznEXUvYqjo/yaM+VLs9zwZhQoDSeTn5fUkdOUYbI 9FE2+PrVHhxfU7H4Y7BjOJWZV4O5XnnQYOmKeOp+CyPu X-Google-Smtp-Source: ABdhPJxU/84XvZQ2ewaxgmwpeK/Cyc1itnMi82MZRRgGbpt/sYzB0aTy3ZLCYM8RlPaQ/yY/vhM7B7mLw/FQ0/BRIKQ= X-Received: by 2002:a17:906:30c9:: with SMTP id b9mr22577198ejb.377.1643740157151; Tue, 01 Feb 2022 10:29:17 -0800 (PST) MIME-Version: 1.0 References: <20220130013042.1906881-1-willy@infradead.org> In-Reply-To: <20220130013042.1906881-1-willy@infradead.org> From: Yang Shi Date: Tue, 1 Feb 2022 10:29:05 -0800 Message-ID: Subject: Re: [PATCH] mm/hwpoison: Check the subpage, not the head page To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Linux MM , Linux Kernel Mailing List , Naoya Horiguchi Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: wuwcm59i8zuc85hyuax4n8sfdradiuzk X-Rspam-User: nil Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FUjdGPY4; spf=pass (imf11.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6761240007 X-HE-Tag: 1643740158-174554 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 29, 2022 at 5:30 PM Matthew Wilcox (Oracle) wrote: > > Hardware poison is tracked on a per-page basis, not on the head page. Looks correct to me. Reviewed-by: Yang Shi > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/rmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 6a1e8c7f6213..09b08888120e 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1553,7 +1553,7 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma, > /* Update high watermark before we lower rss */ > update_hiwater_rss(mm); > > - if (PageHWPoison(page) && !(flags & TTU_IGNORE_HWPOISON)) { > + if (PageHWPoison(subpage) && !(flags & TTU_IGNORE_HWPOISON)) { > pteval = swp_entry_to_pte(make_hwpoison_entry(subpage)); > if (PageHuge(page)) { > hugetlb_count_sub(compound_nr(page), mm); > @@ -1873,7 +1873,7 @@ static bool try_to_migrate_one(struct page *page, struct vm_area_struct *vma, > * memory are supported. > */ > subpage = page; > - } else if (PageHWPoison(page)) { > + } else if (PageHWPoison(subpage)) { > pteval = swp_entry_to_pte(make_hwpoison_entry(subpage)); > if (PageHuge(page)) { > hugetlb_count_sub(compound_nr(page), mm); > -- > 2.34.1 > >