From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E07C4338F for ; Wed, 18 Aug 2021 18:07:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B3313610FD for ; Wed, 18 Aug 2021 18:07:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B3313610FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4EE918D0002; Wed, 18 Aug 2021 14:07:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49F3D8D0001; Wed, 18 Aug 2021 14:07:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38E278D0002; Wed, 18 Aug 2021 14:07:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 1F72D8D0001 for ; Wed, 18 Aug 2021 14:07:57 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BBE2518481CDB for ; Wed, 18 Aug 2021 18:07:56 +0000 (UTC) X-FDA: 78488984952.11.9CC8EAA Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf02.hostedemail.com (Postfix) with ESMTP id 764847005E4D for ; Wed, 18 Aug 2021 18:07:56 +0000 (UTC) Received: by mail-ej1-f42.google.com with SMTP id bt14so6862329ejb.3 for ; Wed, 18 Aug 2021 11:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hx28tyUB9KiCFAY9cyuoD0VE1SUmiWqAmn6LZw6GdqM=; b=Ivn9I5XbRrwoplOFaspCCcybEySrshPBY5LxabeMfF9J3hA7yX5eyan+yPWWo9g6XN noZWJrVnjn7URoYnYqQy3wYsR2dHsm+QJu8YbPmMIfhs0FLeuxyR4WvWH+Z48HyqvMeQ SB7JJm4pmAHNx/mqZdmZEKcSshDKKvdvrIX8p35uQ5f4zTuYy7k3DvG2Gi+XD0oVoNAW 4x64MBvq8UaYETvp1bMn4bKaHl4UWknwpBU+DAVIbfV1WYlXaMyYPwrufzaQ4t070Dey 5xFFA7JYuQ17SmTGOmTYp98/dkRadf7WieyELBTLpe9o2kWxm09gvNrqNvJp+d3JHihM tPeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hx28tyUB9KiCFAY9cyuoD0VE1SUmiWqAmn6LZw6GdqM=; b=QbNmxb1Noa45R92c6RoG9AcFqlER2UuFHvEFIl0DVYJ/XQN9KUIKMRYxAt0NOJs0qZ WDtiUPWEFOJR99nrcHujZnHNBny9a1ML85YVK7ebrGpKwT/k4TzMtq3myEz35pgSL9/w 6PHgwlra8wptRwS5qNHK2Rd3lqFQsXQCDGBLOeJLSWPcxM03clV8g3Rn8Jqz1B92FAan R2EqFF/krTe83lkre/6e7q3I9DvG3pEugDpa3fInVqgBwpp5of1xp/wSc4lOmidWTWXw s7CCRn4YId37ntiiiSTQK4PttLD36tcZnsfCUDqSOUumB9jspV3r3mf87ibD7LaMc3E6 Hd2g== X-Gm-Message-State: AOAM531jAikxHOTekkxbrlSO6UJAc8mteeWTuGIALwyjDJNJVS4STm2S ObEFoexeELlBuSebyCWYXnnYu4SdAhZuLl9VfM0= X-Google-Smtp-Source: ABdhPJzZHmWsoIsqMYnWIZzdgtWZcINZycCty6LdqZp4YBnydV2udS6zRdbz6xic1TEqZ7wAu70biRsHMMIuwlPYLfo= X-Received: by 2002:a17:906:491a:: with SMTP id b26mr11233299ejq.25.1629310075279; Wed, 18 Aug 2021 11:07:55 -0700 (PDT) MIME-Version: 1.0 References: <20210817053703.2267588-1-naoya.horiguchi@linux.dev> In-Reply-To: <20210817053703.2267588-1-naoya.horiguchi@linux.dev> From: Yang Shi Date: Wed, 18 Aug 2021 11:07:43 -0700 Message-ID: Subject: Re: [PATCH v1] mm/hwpoison: Retry with shake_page() for unhandlable pages To: Naoya Horiguchi Cc: Linux MM , Andrew Morton , Tony Luck , Oscar Salvador , Muchun Song , Mike Kravetz , Michal Hocko , Naoya Horiguchi , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 764847005E4D X-Stat-Signature: iuz76oeatcjx3trrw5gj1y4fk5gnfjow Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Ivn9I5Xb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-HE-Tag: 1629310076-649176 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 16, 2021 at 10:37 PM Naoya Horiguchi wrote: > > From: Naoya Horiguchi > > HWPoisonHandlable() sometimes returns false for typical user pages > due to races with average memory events like transfers over LRU lists. > This causes failures in hwpoison handling. > > There's retry code for such a case but does not work because the retry > loop reaches the retry limit too quickly before the page settles down to > handlable state. Let get_any_page() call shake_page() to fix it. > > Fixes: 25182f05ffed ("mm,hwpoison: fix race with hugetlb page allocation") > Reported-by: Tony Luck > Signed-off-by: Naoya Horiguchi > Cc: stable@vger.kernel.org # 5.13 > --- > mm/memory-failure.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git v5.14-rc6/mm/memory-failure.c v5.14-rc6_patched/mm/memory-failure.c > index eefd823deb67..aa6592540f17 100644 > --- v5.14-rc6/mm/memory-failure.c > +++ v5.14-rc6_patched/mm/memory-failure.c > @@ -1146,7 +1146,7 @@ static int __get_hwpoison_page(struct page *page) > * unexpected races caused by taking a page refcount. > */ > if (!HWPoisonHandlable(head)) > - return 0; > + return -EBUSY; > > if (PageTransHuge(head)) { > /* > @@ -1199,9 +1199,14 @@ static int get_any_page(struct page *p, unsigned long flags) > } > goto out; > } else if (ret == -EBUSY) { > - /* We raced with freeing huge page to buddy, retry. */ > - if (pass++ < 3) > + /* > + * We raced with (possibly temporary) unhandlable > + * page, retry. > + */ > + if (pass++ < 3) { > + shake_page(p, 1); > goto try_again; > + } I think the return value should be set to -EIO before jumping to out. I'm supposed -EIO means this is really or very likely an unhandlable page. > goto out; > } > } > -- > 2.25.1 > >