From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26451C4338F for ; Wed, 28 Jul 2021 23:44:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 968796103E for ; Wed, 28 Jul 2021 23:44:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 968796103E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 03D8F8D0001; Wed, 28 Jul 2021 19:44:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2FA46B005D; Wed, 28 Jul 2021 19:44:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1EA28D0001; Wed, 28 Jul 2021 19:44:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 9B0FB6B0036 for ; Wed, 28 Jul 2021 19:44:27 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8852F250D5 for ; Wed, 28 Jul 2021 23:44:26 +0000 (UTC) X-FDA: 78413628132.17.D46080E Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf03.hostedemail.com (Postfix) with ESMTP id 5A676300A2D2 for ; Wed, 28 Jul 2021 23:44:26 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id nd39so7351928ejc.5 for ; Wed, 28 Jul 2021 16:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ugXfezE+ZwhEh4U/P9UCcdlzkyruIuxnzLSqjoNBlak=; b=uuLS6NZyFl0VuxBfzH/YtbQBikB10CrkqwserRwhVhR2NwrFDaHwSRGUwnrpoNq98u Bap1qOWOJp8eu7ydzTktgdB0aXKorHLsu2YPJ5RB5HITJI56YhRCyUzSfihc/cFeMWgI 3iPxO0aNURHPDK+NGm5db+bBLMlvO4x8wc1PZGPJk3p6SqpUOJa4rMBqZ5nRxxaGQhmi 7QRehz8ccxhEavyUDoPm7oYtO/sQRQZm/6QHhDdW9sB09To/WFD3cBWW3QC4aWOH03rm qpMm/X73RRKOan3SDwjXkcduqJvUZD0mEQaR722sfRNygdIvP/UjJU6BIBUg8xQlwEbI lzdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ugXfezE+ZwhEh4U/P9UCcdlzkyruIuxnzLSqjoNBlak=; b=RrPaQYDYxOZvn2CgWRR/BSvB2mGpiM4PbOAhesuLib0g0HB6qmbmMHIpffBqAPZdoA vOgozL3hmgQ1EuGt+ygvHvqHE4Z30PGKLIWWuD+rZhLrpiGCY6+2YqFlYLYuxXz4WZOW hhP2l9bDs0aRbyuon+G8kxgPLSl7aFMb1+XT2IpVjHR0/KA7bG4phvuEYyQuzVmZVsUN q7Vz3/OhveUVOCm3EKahospl9zDe+Y1pdlD0P17tXcXGMhJ+vYT0jF08mlFDFrCaY8Ux Is1Q10r96Brw6//Klr+SIAzse9hN6t6PWJtoFNtOS77slHtInbqK/xpkeFMcNcpUob9y hpZA== X-Gm-Message-State: AOAM531lvoaI7Dk/6Bo9QcEU9clIZ43J5oI3QHl3fkuDs+CSVNx6o8xc vhuY6WHxCeLFY33llHXV5ir0tTbWtxsNitXq3Xo= X-Google-Smtp-Source: ABdhPJyu2wwk1Vw7Zo3H4+uoSsUQ2oG2lPmP285DF0KpDzdEIh/9ZGsih5cZmxOgdd7YY/CA8xqkOdvvgPVAOo02Tto= X-Received: by 2002:a17:907:75d2:: with SMTP id jl18mr1815279ejc.238.1627515864907; Wed, 28 Jul 2021 16:44:24 -0700 (PDT) MIME-Version: 1.0 References: <20210728042531.359409-1-aneesh.kumar@linux.ibm.com> In-Reply-To: <20210728042531.359409-1-aneesh.kumar@linux.ibm.com> From: Yang Shi Date: Wed, 28 Jul 2021 16:44:13 -0700 Message-ID: Subject: Re: [PATCH] mm/migrate: fix NR_ISOLATED corruption on 64-bit To: "Aneesh Kumar K.V" Cc: Linux MM , Andrew Morton , Michael Ellerman Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5A676300A2D2 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=uuLS6NZy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Stat-Signature: 1wnziqypq5pxyh4dttm9qrfnws8xphph X-HE-Tag: 1627515866-928080 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 27, 2021 at 9:25 PM Aneesh Kumar K.V wrote: > > Similar to commit 2da9f6305f30 ("mm/vmscan: fix NR_ISOLATED_FILE corruption on 64-bit") > avoid using unsigned int for nr_pages. With unsigned int type the large > unsigned int converts to a large positive signed long. > > Symptoms include CMA allocations hanging forever > due to alloc_contig_range->...->isolate_migratepages_block waiting > forever in "while (unlikely(too_many_isolated(pgdat)))". > > Fixes: c5fc5c3ae0c8 ("mm: migrate: account THP NUMA migration counters correctly") > Cc: Yang Shi > Reported-by: Michael Ellerman > Signed-off-by: Aneesh Kumar K.V It seems Andrew picked this one. Either one is fine to me. Reviewed-by: Yang Shi > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 34a9ad3e0a4f..7e240437e7d9 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2068,7 +2068,7 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, > LIST_HEAD(migratepages); > new_page_t *new; > bool compound; > - unsigned int nr_pages = thp_nr_pages(page); > + int nr_pages = thp_nr_pages(page); > > /* > * PTE mapped THP or HugeTLB page can't reach here so the page could > -- > 2.31.1 >