From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0975DC4338F for ; Tue, 24 Aug 2021 22:19:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A4791610FD for ; Tue, 24 Aug 2021 22:19:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A4791610FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1403C6B0072; Tue, 24 Aug 2021 18:19:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CAAC6B0073; Tue, 24 Aug 2021 18:19:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAD0E8D0001; Tue, 24 Aug 2021 18:19:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id CDFA36B0072 for ; Tue, 24 Aug 2021 18:19:20 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 625A61D5A8 for ; Tue, 24 Aug 2021 22:19:20 +0000 (UTC) X-FDA: 78511391280.39.3CFA9BF Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf18.hostedemail.com (Postfix) with ESMTP id 254C54002093 for ; Tue, 24 Aug 2021 22:19:20 +0000 (UTC) Received: by mail-ej1-f46.google.com with SMTP id u14so22552914ejf.13 for ; Tue, 24 Aug 2021 15:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=q5nttO+EVJ+S8LC490ljDcRd9HEmiraLUmRSH5LRsGU=; b=fqCQuAQFqhzUQ0KuQIDY+P8057+0Y5EMgYDiqy08hw4ify0ZD9irk51i93kshUiH1j i0XJt5MRrj3cDrlgmwk1le/EChqbN9yVTb08b/4auSoI06lEY5b3GIoVpKK1BJNHrup1 P46q2wHztrXmxnqD3IJM2YzdDDneuVujl0YGYF7t0PVFgEWkewPfVTyGtDtFkyQvgTKC OQKdeMnrd6g/hKAaA1V+IEUVD0zyMoPAncRMpqkb6T93lEb7v82arMaxzqq7DwhXsFag y/BGuMImc8lKtYzlE8Tq9cZlTNXtusFoFTDzUkpE5EX7ygWUjjFb+UBU1eQ/y39FvWBf h00A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=q5nttO+EVJ+S8LC490ljDcRd9HEmiraLUmRSH5LRsGU=; b=QmrxJ4pyvdIdjCl2ggYfUuBHc83fgBDYylbvZeeWrG5JaRc+SdSMeWFJeTwmyfZ4Xf rn9wO0KykyfD6CxJeHIHv2Aj/zWfNTqiihjNLjOrgB3AtL8SGF1XW9/avmv9M2V1Ej/A 5Pa4AkZrO/HQlFk22/xtvik3t/OW82KTFVRvyDUc4Ze8bn86g4UyQtCepqFYsB3s1RZz P+re7vjjf41WFF1Tk1lw6lzc11KOTIK/hPsOpH89SSgkPnUPOffvXLOsP+d9WnI1FXuy 4TeLzVHn8hUm7KGH7qMQtI0m/MqdqOPIHSO0s8ABVUrDN/e+V5/pubv9uA5R5KWxmv3f RXpQ== X-Gm-Message-State: AOAM531he9gtaIrKyNrBIl7xIJNJAaik1mzd+I0UTVGHtn59l+z1YiXa PdmHdhz+I/oh7fUH1vfDhuwHurYgxmF0LszApbs= X-Google-Smtp-Source: ABdhPJwMH8lLLdOyAd1yBCJ9w2a/GWpgFynhTDYophuuh3pJdd+TFZVvLWLZfxVFcnVwFp/L38EcoDdK0L6QWR2nnSQ= X-Received: by 2002:a17:906:491a:: with SMTP id b26mr43345639ejq.25.1629843558874; Tue, 24 Aug 2021 15:19:18 -0700 (PDT) MIME-Version: 1.0 References: <00000000000007510305ca5225b0@google.com> In-Reply-To: From: Yang Shi Date: Tue, 24 Aug 2021 15:19:07 -0700 Message-ID: Subject: Re: [syzbot] kernel BUG in collapse_file To: syzbot , Linux MM , Linux Kernel Mailing List , Andrew Morton , Hugh Dickins , "Kirill A. Shutemov" Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=fqCQuAQF; spf=pass (imf18.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 254C54002093 X-Stat-Signature: c6u656iuohxprgzsizgk3ehbnpr1uwff X-HE-Tag: 1629843560-139970 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 24, 2021 at 12:14 PM Yang Shi wrote: > > On Tue, Aug 24, 2021 at 12:13 PM Yang Shi wrote: > > > > On Tue, Aug 24, 2021 at 11:17 AM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit: d6d09a694205 Merge tag 'for-5.14-rc6-tag' of git://git.ker.. > > > git tree: upstream > > > console output: https://syzkaller.appspot.com/x/log.txt?x=14924605300000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=f61012d0b1cd846f > > > dashboard link: https://syzkaller.appspot.com/bug?extid=f17e5ab118d29367bda9 > > > compiler: Debian clang version 11.0.1-2, GNU ld (GNU Binutils for Debian) 2.35.1 > > > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > > Reported-by: syzbot+f17e5ab118d29367bda9@syzkaller.appspotmail.com > > > > > > unmap_region+0x2ab/0x300 mm/mmap.c:2680 > > > __do_munmap+0x18eb/0x2050 mm/mmap.c:2911 > > > __do_sys_mremap+0x5d9/0x1390 mm/mremap.c:969 > > > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > > > do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 > > > entry_SYSCALL_64_after_hwframe+0x44/0xae > > > ------------[ cut here ]------------ > > > kernel BUG at mm/khugepaged.c:1830! > > > > The BUG means the page is not fully unmapped due to some race, just > > like what https://lore.kernel.org/linux-mm/00000000000030563005ca006ffd@google.com/ > > reported. > > > > But I really don't think it is worth VM_BUG since khugepaged can just back off. In addition, I think we should be able to just replace unmap_mapping_pages() to try_to_unmap() or unmap_page (of course, make it non-static) since some races are closed by Hugh's patches. > > Forgot cc to other stakeholders. > > > > > > invalid opcode: 0000 [#1] PREEMPT SMP KASAN > > > CPU: 0 PID: 1651 Comm: khugepaged Not tainted 5.14.0-rc6-syzkaller #0 > > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > > > RIP: 0010:collapse_file+0x3537/0x36e0 mm/khugepaged.c:1830 > > > Code: e8 1e 7a b2 ff 48 89 df 48 c7 c6 40 7b 3d 8a e8 ef 02 e8 ff 0f 0b e8 08 7a b2 ff 48 89 df 48 c7 c6 a0 7b 3d 8a e8 d9 02 e8 ff <0f> 0b e8 f2 79 b2 ff 4c 89 e7 48 c7 c6 a0 7e 3d 8a e8 c3 02 e8 ff > > > RSP: 0018:ffffc900066df820 EFLAGS: 00010046 > > > RAX: 8601299b4ae62f00 RBX: ffffea0000e4e240 RCX: ffff888018fed4c0 > > > RDX: 0000000000000000 RSI: 000000000000ffff RDI: 000000000000ffff > > > RBP: ffffc900066dfa90 R08: ffffffff81d08764 R09: ffffed1017383f2c > > > R10: ffffed1017383f2c R11: 0000000000000000 R12: ffffc900066df9d8 > > > R13: dffffc0000000000 R14: ffffc900066dfa20 R15: 0000000000000001 > > > FS: 0000000000000000(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000 > > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > CR2: 0000000100000000 CR3: 000000000c48e000 CR4: 00000000001506f0 > > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > Call Trace: > > > khugepaged_scan_file mm/khugepaged.c:2051 [inline] > > > khugepaged_scan_mm_slot+0x27be/0x2ad0 mm/khugepaged.c:2146 > > > khugepaged_do_scan+0x2b1/0x640 mm/khugepaged.c:2230 > > > khugepaged+0x105/0x890 mm/khugepaged.c:2275 > > > kthread+0x453/0x480 kernel/kthread.c:319 > > > ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 > > > Modules linked in: > > > ---[ end trace 8de2a60ea4ac5483 ]--- > > > RIP: 0010:collapse_file+0x3537/0x36e0 mm/khugepaged.c:1830 > > > Code: e8 1e 7a b2 ff 48 89 df 48 c7 c6 40 7b 3d 8a e8 ef 02 e8 ff 0f 0b e8 08 7a b2 ff 48 89 df 48 c7 c6 a0 7b 3d 8a e8 d9 02 e8 ff <0f> 0b e8 f2 79 b2 ff 4c 89 e7 48 c7 c6 a0 7e 3d 8a e8 c3 02 e8 ff > > > RSP: 0018:ffffc900066df820 EFLAGS: 00010046 > > > RAX: 8601299b4ae62f00 RBX: ffffea0000e4e240 RCX: ffff888018fed4c0 > > > RDX: 0000000000000000 RSI: 000000000000ffff RDI: 000000000000ffff > > > RBP: ffffc900066dfa90 R08: ffffffff81d08764 R09: ffffed1017383f2c > > > R10: ffffed1017383f2c R11: 0000000000000000 R12: ffffc900066df9d8 > > > R13: dffffc0000000000 R14: ffffc900066dfa20 R15: 0000000000000001 > > > FS: 0000000000000000(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000 > > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > CR2: 0000000100000000 CR3: 000000000c48e000 CR4: 00000000001506f0 > > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > ---------------- > > > Code disassembly (best guess): > > > 0: e8 1e 7a b2 ff callq 0xffb27a23 > > > 5: 48 89 df mov %rbx,%rdi > > > 8: 48 c7 c6 40 7b 3d 8a mov $0xffffffff8a3d7b40,%rsi > > > f: e8 ef 02 e8 ff callq 0xffe80303 > > > 14: 0f 0b ud2 > > > 16: e8 08 7a b2 ff callq 0xffb27a23 > > > 1b: 48 89 df mov %rbx,%rdi > > > 1e: 48 c7 c6 a0 7b 3d 8a mov $0xffffffff8a3d7ba0,%rsi > > > 25: e8 d9 02 e8 ff callq 0xffe80303 > > > 2a: 0f 0b ud2 <-- trapping instruction > > > 2c: e8 f2 79 b2 ff callq 0xffb27a23 > > > 31: 4c 89 e7 mov %r12,%rdi > > > 34: 48 c7 c6 a0 7e 3d 8a mov $0xffffffff8a3d7ea0,%rsi > > > 3b: e8 c3 02 e8 ff callq 0xffe80303 > > > > > > > > > --- > > > This report is generated by a bot. It may contain errors. > > > See https://goo.gl/tpsmEJ for more information about syzbot. > > > syzbot engineers can be reached at syzkaller@googlegroups.com. > > > > > > syzbot will keep track of this issue. See: > > > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > > >