From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 523C7C00140 for ; Wed, 10 Aug 2022 17:06:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9EDA6B0071; Wed, 10 Aug 2022 13:06:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4D686B0072; Wed, 10 Aug 2022 13:06:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B15286B0073; Wed, 10 Aug 2022 13:06:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A207D6B0071 for ; Wed, 10 Aug 2022 13:06:35 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6471A1A143C for ; Wed, 10 Aug 2022 17:06:35 +0000 (UTC) X-FDA: 79784311950.14.C7E4588 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf24.hostedemail.com (Postfix) with ESMTP id EBC4B180065 for ; Wed, 10 Aug 2022 17:06:34 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id c19-20020a17090ae11300b001f2f94ed5c6so3652049pjz.1 for ; Wed, 10 Aug 2022 10:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=BloIoqd28Gq/iR4Kl8DFhiJxo48Wnl4+cYDJh7THU3o=; b=J+lmDtEx1spmwcuZ6nzWNtmyWixs3iQlKNfDN9GHbj7bwZHS4cMQbFPjooczgmAi28 noJJpXytFM8RIKB8NHp+fliGadlVLNst/hyjPRLMP+3hYVf+8QDFzlQWS1fysWpJz0JD TbWYk4JzP8IUdumwwuedXE+kt3m43E1rT6SPPPJkx/7laJgMvWjE9w2M0GgCYu2+JIOK jPvzJBB08jggfJRS9Lm3GxdvpIfexx8h6llCHHLvJFDG21IrKwjyQ6jiUKR2XSkcQ1lQ ZRWokGoVdniJyH8OesMPG8L+Ipk2t5G7Yr78kywJZCIgsua3CC35c682Zwa4A4qSsXMZ 7wZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=BloIoqd28Gq/iR4Kl8DFhiJxo48Wnl4+cYDJh7THU3o=; b=EcTpCMxs/W8oohgQPKAIeLdA8iJAXxFXFzcpi+0pKT8V28Xya5910qgh+lZkxBX3F8 dGS0aWkOV7ctfrl5YfJYcDDb7xFrZpVSkH0tTHLSlxz+wLQmBrysKfmKF7BeLt7Uq5Bl zcnvzKyc2LMYQ0mJ8KT78360oS/dZLMLUryS4EVFH89vrYtncNkJxkp7Bs80so2Ybvdn clj1ZYZmWqzG1CCoRMMUGMQXd0hCCSnPbnFVBwJDDqxbPEiZAHCmU1TW1MjKi9sF+5gN A8cFI0TTBwnGcQVq01UeI/bvsOOSajQMu7rk1S4dihX6mPrkLUiZNv3ZRgprnC68jSaU fVlA== X-Gm-Message-State: ACgBeo3m6iaVT6UyYuWDoj53Nt/rS7opbbXqftx5LeD/k3KfucevEWUU vcPyNEAYIl9exb/au8OquCf3YF3Fv/VeouWMKX0= X-Google-Smtp-Source: AA6agR7gaelm+IrsPpnI13nlpFFrvd9qLj+QGdfP1m8ePEL2ktkuUURsgHk47ox+qo60DBytLG8d7Wu8BIzH8gvt560= X-Received: by 2002:a17:90b:1b45:b0:1f3:1974:eb8 with SMTP id nv5-20020a17090b1b4500b001f319740eb8mr4645072pjb.200.1660151193845; Wed, 10 Aug 2022 10:06:33 -0700 (PDT) MIME-Version: 1.0 References: <20220809142457.4751229f@imladris.surriel.com> In-Reply-To: <20220809142457.4751229f@imladris.surriel.com> From: Yang Shi Date: Wed, 10 Aug 2022 10:06:21 -0700 Message-ID: Subject: Re: [PATCH v2] mm: align larger anonymous mappings on THP boundaries To: Rik van Riel Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Matthew Wilcox Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660151195; a=rsa-sha256; cv=none; b=IBN5uurGHV4al7iDn0rAovVNoodWQsbKWNStgdjywbu/ZVS5Q+MuTI68KrefXKgl9Y7S1h fWaIk/+ESC8A6Bxc8K/vzbh0t4Ir1q+ASvG/fpbQKFCaCOlbt9DXVMPmdJKeqaYrdJUwVi Lm5+J/A04+B4wnYbJpmrqxZx/xU6y6g= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=J+lmDtEx; spf=pass (imf24.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660151195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BloIoqd28Gq/iR4Kl8DFhiJxo48Wnl4+cYDJh7THU3o=; b=0dMp/CsBBt6TQ+UbrakHFsnTFJmoTQm8m1XNtOMH8UXlud6zkFfBaNpH5lxa9AXhM6eLHN 4gNEA58yScnIybqNryB97bylqIHVvqH/9bn5tDNz5nt36f1M/6wiS4fpmo3lpohuF+a7xF RzQJUJvL0zn/V7v+O5RTmp5vhA8/2Fw= X-Stat-Signature: 9swdfxxmhxeqwe1pfx9e975afyxwxg8q X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EBC4B180065 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=J+lmDtEx; spf=pass (imf24.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-HE-Tag: 1660151194-353283 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 9, 2022 at 11:25 AM Rik van Riel wrote: > > Align larger anonymous memory mappings on THP boundaries by > going through thp_get_unmapped_area if THPs are enabled for > the current process. > > With this patch, larger anonymous mappings are now THP aligned. > When a malloc library allocates a 2MB or larger arena, that > arena can now be mapped with THPs right from the start, which > can result in better TLB hit rates and execution time. > > Signed-off-by: Rik van Riel > --- > v2: avoid the chicken & egg issue with MMF_VM_HUGEPAGE (Yang Shi) Reviewed-by: Yang Shi > > mm/mmap.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/mmap.c b/mm/mmap.c > index c035020d0c89..1d859893436d 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -2229,6 +2229,9 @@ get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, > */ > pgoff = 0; > get_area = shmem_get_unmapped_area; > + } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { > + /* Ensures that larger anonymous mappings are THP aligned. */ > + get_area = thp_get_unmapped_area; > } > > addr = get_area(file, addr, len, pgoff, flags); > -- > 2.37.1 > >