From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD1C4C433DF for ; Wed, 19 Aug 2020 22:17:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 701F02067C for ; Wed, 19 Aug 2020 22:17:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FxWNqRgR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 701F02067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE28F8D001C; Wed, 19 Aug 2020 18:17:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B94638D0003; Wed, 19 Aug 2020 18:17:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAA0C8D001C; Wed, 19 Aug 2020 18:17:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id 911B48D0003 for ; Wed, 19 Aug 2020 18:17:05 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3EAB8181AC9CC for ; Wed, 19 Aug 2020 22:17:05 +0000 (UTC) X-FDA: 77168729610.09.party01_0f0f9692702b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 05476180AD822 for ; Wed, 19 Aug 2020 22:17:04 +0000 (UTC) X-HE-Tag: party01_0f0f9692702b X-Filterd-Recvd-Size: 5815 Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 19 Aug 2020 22:17:04 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id i26so89303edv.4 for ; Wed, 19 Aug 2020 15:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z5oYfnvvNgOKzQEdHzTF0gJ2oJXC1K1LiPYrVBa6INo=; b=FxWNqRgRfNBd3JnmSgawx8jx2Sl7u9W80bi/iJMlRO3QXrnKPQoz+hBqp5ysqGSeJw ljW6J+Hng6tKeaCq1cY5k7YSo19zuCj5WVqXyV2eiWw6WSRjRoWmd/cQ6xlFkMd28cnj w5OLYfTdy4huFqN41t5A4BFB7Eke2et5WQQmHm5uRBWnbAzBDPin+6K2fT8eyys5k5xZ FYaH/YVHqHMf2oOubqj6ahqwJRqe6B4ycx/lxJJbYG31WkwzP2CuNBpjvfsCdYvh7Qgd IoDHwqtBRyLP1QA381RwwnEt6J6RqEWL0inppfi5H+KO3wiDv/mzKQAog4zFDzBiGyX0 BVOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z5oYfnvvNgOKzQEdHzTF0gJ2oJXC1K1LiPYrVBa6INo=; b=DJXIGOwNiOUTW+8UeDO/w1ydVRKhh2mJ2DGezc0U1QZpp4p4fExaVd4LN+z2PSMxV1 7bSxsINGjSB7h1WfaGcKU3lZ4dsaZGmP8PYbaEfr6Q9yn4lT7Us49QZGpVqV1vnWiGjq Pb8MFt0Nt7n1MGDOPk8OzOnDoP84Tr5XZCKuqchduT6yjk9AEWHD+3U7UcwPiuDUhSQg d7HxOT7vW6v0cz2N7lwyQ176S/SWu1HYAt1KIu2YWTVZfVYgk7hlIOkti2RwbbPIAus3 5q93VCRUkB/N4A52t3NsuKr2Wl+cgOXWWBOzjuYxhQc+2ZFAPxyTkVBNGP45Q5jQ+Q3Q 04Eg== X-Gm-Message-State: AOAM5316VuTr8WdrjjH01hqyty4Z32iFjM5tKLE4BVgvlHIZ+YwNEcgt Wkgpa2LNbuR8WiHOTkEQJ0n1cGDq83Gh7lZ0N2w= X-Google-Smtp-Source: ABdhPJzLW5c7FEkm5VPOxnh2XWllxfX9yJ8+CA0Yx5IymNKzUh21FK1RKmLUBk/p0raePx4rN1qkz/EWKn+q2pYq7xg= X-Received: by 2002:a05:6402:2038:: with SMTP id ay24mr172019edb.200.1597875423373; Wed, 19 Aug 2020 15:17:03 -0700 (PDT) MIME-Version: 1.0 References: <20200818184704.3625199-1-yuzhao@google.com> In-Reply-To: <20200818184704.3625199-1-yuzhao@google.com> From: Yang Shi Date: Wed, 19 Aug 2020 15:16:51 -0700 Message-ID: Subject: Re: [PATCH v2 1/3] mm: remove activate_page() from unuse_pte() To: Yu Zhao Cc: Andrew Morton , Alexander Duyck , Huang Ying , David Hildenbrand , Michal Hocko , Yang Shi , Qian Cai , Mel Gorman , Nicholas Piggin , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Hugh Dickins , Linux MM , Linux Kernel Mailing List , Joonsoo Kim Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 05476180AD822 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 18, 2020 at 11:47 AM Yu Zhao wrote: > > We don't initially add anon pages to active lruvec after > commit b518154e59aa ("mm/vmscan: protect the workingset on anonymous LRU"). > Remove activate_page() from unuse_pte(), which seems to be missed by > the commit. And make the function static while we are at it. > > Before the commit, we called lru_cache_add_active_or_unevictable() to > add new ksm pages to active lruvec. Therefore, activate_page() wasn't > necessary for them in the first place. Reviewed-by: Yang Shi > > Signed-off-by: Yu Zhao > --- > include/linux/swap.h | 1 - > mm/swap.c | 4 ++-- > mm/swapfile.c | 5 ----- > 3 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/include/linux/swap.h b/include/linux/swap.h > index 661046994db4..df6207346078 100644 > --- a/include/linux/swap.h > +++ b/include/linux/swap.h > @@ -340,7 +340,6 @@ extern void lru_note_cost_page(struct page *); > extern void lru_cache_add(struct page *); > extern void lru_add_page_tail(struct page *page, struct page *page_tail, > struct lruvec *lruvec, struct list_head *head); > -extern void activate_page(struct page *); > extern void mark_page_accessed(struct page *); > extern void lru_add_drain(void); > extern void lru_add_drain_cpu(int cpu); > diff --git a/mm/swap.c b/mm/swap.c > index d16d65d9b4e0..25c4043491b3 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -348,7 +348,7 @@ static bool need_activate_page_drain(int cpu) > return pagevec_count(&per_cpu(lru_pvecs.activate_page, cpu)) != 0; > } > > -void activate_page(struct page *page) > +static void activate_page(struct page *page) > { > page = compound_head(page); > if (PageLRU(page) && !PageActive(page) && !PageUnevictable(page)) { > @@ -368,7 +368,7 @@ static inline void activate_page_drain(int cpu) > { > } > > -void activate_page(struct page *page) > +static void activate_page(struct page *page) > { > pg_data_t *pgdat = page_pgdat(page); > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 12f59e641b5e..c287c560f96d 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1925,11 +1925,6 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd, > lru_cache_add_inactive_or_unevictable(page, vma); > } > swap_free(entry); > - /* > - * Move the page to the active list so it is not > - * immediately swapped out again after swapon. > - */ > - activate_page(page); > out: > pte_unmap_unlock(pte, ptl); > if (page != swapcache) { > -- > 2.28.0.220.ged08abb693-goog > >