From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34ED8C7EE2E for ; Mon, 12 Jun 2023 21:59:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C67DE8E0003; Mon, 12 Jun 2023 17:59:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF09E8E0002; Mon, 12 Jun 2023 17:59:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6B818E0003; Mon, 12 Jun 2023 17:59:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8F2388E0002 for ; Mon, 12 Jun 2023 17:59:42 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 62B2540321 for ; Mon, 12 Jun 2023 21:59:42 +0000 (UTC) X-FDA: 80895463404.13.330C8CA Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf25.hostedemail.com (Postfix) with ESMTP id 975EFA0009 for ; Mon, 12 Jun 2023 21:59:40 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=myc3EmpZ; spf=pass (imf25.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686607180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qLgFlmrwGHFojofRCOBcCy0uqVKvL62eTYXx07rbD5s=; b=UUGrWooMpjJYnrUhKTRJV2L73YeS+ooKl7LLrQHysP7CL6ggvwusPKFZ5wWz8vafly/HBj WHTH0yf47V0tamX1rbXFNDthWz52FmB5+h1FUtkQpmTIDLZAGm2iYDaRnqRZH2Qp1xpjQx 026ZzIvB/AUrWJxmYJqTGLEzzWJ8g8Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686607180; a=rsa-sha256; cv=none; b=W2x1xt6nOnwU2jzFeofbYIe8GWD5IXW0DEFYy8dRCbzh0wyaVugMDvg4amYVH0/Nqg24O7 EJHOZJojA/cwDJRCzs+4vdiam6zVw/mrl2JsCxxX+GFo6lXt2O+ddfdhvH2ef0l28xcE0W yv/pA3JG/inPjG1DxdaRKO4xKYsjFus= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=myc3EmpZ; spf=pass (imf25.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-53f04fdd77dso2130054a12.3 for ; Mon, 12 Jun 2023 14:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686607179; x=1689199179; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qLgFlmrwGHFojofRCOBcCy0uqVKvL62eTYXx07rbD5s=; b=myc3EmpZMXXYpMTpTggL4Lnje9n7a/UxxmFD5LgWcQhVipEpkH7qFsXBEmfCeJX5vH uEASlz2XNaxfdybThNtmgP9FngfJaUajLWde2BJyt3c0XTjbAFAGOU8QokRL/R/TcNWh 0XOtCE7eL9I1ohexZmXMyBSjoJPJdD61SxF5CGrpnSJl/Q2V0qV48evebb3n0P/TRL83 vGOdacV8SUS7jj0q7fd0pu12VpVN5jxxFwfI4y8PLJN6QE4w5mFLCPwT6hMS9Q0YPIJi CPxhhVGdth3XWjgQ+z8mDT7/K8qClg7SC0rsyRBur9/eVH+dhzJ56HYXZSOjwlykasFP 12YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686607179; x=1689199179; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qLgFlmrwGHFojofRCOBcCy0uqVKvL62eTYXx07rbD5s=; b=TMVTXiKHXgg21lJ3OhZgz0AJGG3NlEj9nK3EH+FBRbiRb9xXfd95Efskz+7P0gwJcO CSXxe8SQZclCawTxC21spq7y6npNeJdhZt4OoydBBZR/UmGvpgwfqWdiZKLCrAz7FcN/ ufN/av/OdNBFQkg0eX31gqGayKUPUPcdWyWdyMAPj+KUjJIQZdmVtj4bnLyOxXLZT3XB /ev5egfw+we1GzOfCsroCdkyEznIgYxT2R6KMhgmkkit0Cv5zN0wPP8sDvtlccHQRCAW E2xg0RMZ5oLvhpYjKY5icOxj6kotAhGJI8rh3ZlpMAL1PMjYfgWsPZngXZDxQFu0jw+l bdfg== X-Gm-Message-State: AC+VfDzk57L2xiZxdlsBZSWDpum8Li0wd4sCLxjudWGZY612mTOUES5g ZKp/4lpI7XYjrn/2AXKmS8Yn2fYud3FoF/7Bx7Y= X-Google-Smtp-Source: ACHHUZ4hHouejIGEFo/58CX4x8uXkC6mOkfNn1V1t1hCCorbIfjuyAVwq3PNOZJrDl9CvwTcyWY5BWqwQTzRfAsY3lI= X-Received: by 2002:a17:90b:ec7:b0:25b:ce40:7dd6 with SMTP id gz7-20020a17090b0ec700b0025bce407dd6mr4989957pjb.33.1686607179324; Mon, 12 Jun 2023 14:59:39 -0700 (PDT) MIME-Version: 1.0 References: <20230609-khugepage-v1-1-dad4e8382298@google.com> In-Reply-To: <20230609-khugepage-v1-1-dad4e8382298@google.com> From: Yang Shi Date: Mon, 12 Jun 2023 14:59:28 -0700 Message-ID: Subject: Re: [PATCH] mm/khugepaged: use DEFINE_READ_MOSTLY_HASHTABLE macro To: ndesaulniers@google.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 975EFA0009 X-Rspam-User: X-Stat-Signature: 7oh66p33zp8jmesk15powpbn1t79dtms X-Rspamd-Server: rspam03 X-HE-Tag: 1686607180-644501 X-HE-Meta: U2FsdGVkX18+fQ3pbV/JtS0TOIH81yOb2fuWYyESbw3O+eSrC6M3rYu0EQxI4j/Wh+IET37qobqlAQICE1ABUSgTdx0p0YycGF/zcVNCucEMNqo8PvNFnZA5aKl7C0aHnjsiyTILpHSrlcppZUp802uCtAYAoS70WbAS/kl67nMucPrValramdIIZbvIYZpEdafL/eb6roNPNb6cbtEo/73s36ALPFtv4WZRevaH7J51CoIr0D2wLJe6+ZRE0NZG3UUGOrRvhheRrO829SKX+JBhGMpiHfwRfMNM0uortQnaoJPXtTUWSUAmJ5P3aXIFZDKF9t4H27wBWg7LdJlsZ4rZ2RaQJHTgzqtzSNWgQzQX2Geq7sxMfDXaiQdkRRxrlj+Pu3MyxtdgBo5uXZy+IPOXcMCKZOugxiQ5PQXtfV4gGgK0HBo03Re+h32bU5goZb2eerR4dhBsMiIes08rb5ZTJ8QhT3Kz0TidMtEObEv51Al2UrwukXQmEffFoGN18skmgs3dQJ11aR/u77078CGDb79PyilhRSpCwM5mAuyANIk+jdw3pSSlU4k1hc26yomEwGt6QBwqJ7RE3JNUpdBiKP0XnjvUP8JewTZND4xr9ivVOEAphgMxxNlxfmj38v5cTAorqVHTq98oYh+33XmOUHoAbVObDCHtsor1EVvTGEnmRqYjcfLYOQFue9uN9SNyNMjTRct8lTZJqKORYpCVfrhMHnAogl1hUx03HVnCxAp5XtwoGDgbNC4omHJI0YbjoBkoKvYjPYW8sQZRoX2QMe8DqagQA2SooSAYjnjstqY4aIDaIqPEz+X6EOuBZZ6QBC+HReqVz0HB0Ap6FbHvXGx0mzE1ZT9g8gRETezKhbKuLyhBgDdn4gCz4rAjVafXGIs0npa4MnKwwJOimNxfISv5UwzD8T9gqRIiy9ECVSKw8X4T9DJZ6Z+sz4l1r5SBHiq0gJub68lW0oI qsWBpY8j RY6zFPsp28Py/jXoosvx0WCzEq2KW2JPo3rj+fdYnoHu/Xm3RyejwkELG6WMpAfSPPCJmj6EnLEfLOMsCdU4WciI8G0PFgZs4ACTEurmm+yZIU1WcOpcZ1Gf0WRPeAypzKHsylE5fP9qU7D3ELZ7bM1ATxiCFQUQt2x2X0vvb8S03QNX0PSey3u4kPVMEuoeX++bbf2yGaWduI5BaSWD90DEm0Rml9T6PTLKT2s1yYjRjuglZjZVLPA35pqr3vZXVIQwfC6nms6OpvVRXVEschWVBXt7FX4RLTB+7xQ7shhI6CSVY/3BeZZZUj+VZaqu0r/5wGwXHP2PXMMGtPD3lfdx8StMEqCPP0rwiFB/5O45XaaRycdzeK3Ijl3MKLwoF1aMRJ59ArO7x3WM8HyuvKzEjHKfGSBYvX/z90Y/w5614JxCBGCug3mQVWIe5afmf/Dkv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000435, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 9, 2023 at 4:44=E2=80=AFPM wrote: > > These are equivalent, but DEFINE_READ_MOSTLY_HASHTABLE exists to define > a hashtable in the .data..read_mostly section. > > Signed-off-by: Nick Desaulniers Reviewed-by: Yang Shi > --- > mm/khugepaged.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 6b9d39d65b73..e7dc49214413 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -88,7 +88,7 @@ static unsigned int khugepaged_max_ptes_swap __read_mos= tly; > static unsigned int khugepaged_max_ptes_shared __read_mostly; > > #define MM_SLOTS_HASH_BITS 10 > -static __read_mostly DEFINE_HASHTABLE(mm_slots_hash, MM_SLOTS_HASH_BITS)= ; > +static DEFINE_READ_MOSTLY_HASHTABLE(mm_slots_hash, MM_SLOTS_HASH_BITS); > > static struct kmem_cache *mm_slot_cache __read_mostly; > > > --- > base-commit: 64569520920a3ca5d456ddd9f4f95fc6ea9b8b45 > change-id: 20230609-khugepage-09ea340b378e > > Best regards, > -- > Nick Desaulniers > >