From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56EE5C433E0 for ; Mon, 8 Mar 2021 20:22:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB77D6527A for ; Mon, 8 Mar 2021 20:22:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB77D6527A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 298838D0073; Mon, 8 Mar 2021 15:22:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 221068D001D; Mon, 8 Mar 2021 15:22:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09DEC8D0073; Mon, 8 Mar 2021 15:22:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id DDD7B8D001D for ; Mon, 8 Mar 2021 15:22:33 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9C768180AD81A for ; Mon, 8 Mar 2021 20:22:33 +0000 (UTC) X-FDA: 77897829786.06.61C4925 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf08.hostedemail.com (Postfix) with ESMTP id D8566801914E for ; Mon, 8 Mar 2021 20:22:27 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id b13so16698432edx.1 for ; Mon, 08 Mar 2021 12:22:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3p1K7qixRZDMiRKjRkwZnb9DrzcEb8jXcbBFm53rg9s=; b=Caln3dMvsxXDLD71Ze56UjGJP3p+B/XeWTIG8AYVUOuupr1rf1sJw1TIqhfR59BNZF 3HyEP9un1YcjnDN7H7aNTIq4yv1s/RY+zFF25Akb/W334PqjR+VFZD4A1kYOmzLVNVV4 s9ER+BzJUHFPwnuePf/jfuPlHPW3S+51L3RtuSawnNe+roneB9K+1mDIkuc7FP4jre/7 jPSIhyyC3o11Gica68KKnO7LGbw5lHpYZTgPVfV67B5gu4YITK8ikiFR27oj4GcgMImS uZKCHayfX9zATHeBQ8yCHiqpFBpgw7v+p1/tta6COdbfrz8mPpRoMPtJ5DkCZqq1KXj4 Q/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3p1K7qixRZDMiRKjRkwZnb9DrzcEb8jXcbBFm53rg9s=; b=LS0la7tc4fP/yxVoKMLOKDI04r1uJ56bz4aan/BgIsX20E8llozzcWaCTmnPA3rKmZ JXU1aNR8sUDLQX1hKDlUGcg3yZ9HgHCAxNo03nPdgfmyQes25Yzi8zgFu0z1UybRBJb6 cj3mftdNmXtY5Mf9G760MUFdGiaFs0GgM3bJV52Zk989iCx1bma1+1zM1lZLgjBIMWll 5odoxQgBoDOfyMK58U1YRoujM7WPMcO3/ZRcO6q2PMo+yQKH+MLOLq9buzPZtxFkZkd1 xhXXdY1y6ZSmPOSOPZNqaFTJHTTUO0zPGxDY/2H5IschrnMgv8dLD2kzVpacOPPHE92R aN0Q== X-Gm-Message-State: AOAM532n3svwSbWwI9PA8GuLaIM6vYgDWsctM/XiT7N7+6E+BlomV3MP KATL0Y9SnggZwNsWCpBPQX+QDDbuCDc9vwFJMeSvl1Xdd3w= X-Google-Smtp-Source: ABdhPJxXgBHFmRBDWrSq58/rlEQ8Ee4ZYwQpZFrx6BX5YlFLoXsxQiEQinIj3MRdqqPCbruqA0NCUhzrpVL24ERXIcY= X-Received: by 2002:a50:8f42:: with SMTP id 60mr363572edy.168.1615234952188; Mon, 08 Mar 2021 12:22:32 -0800 (PST) MIME-Version: 1.0 References: <20210217001322.2226796-1-shy828301@gmail.com> <20210217001322.2226796-6-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Mon, 8 Mar 2021 12:22:20 -0800 Message-ID: Subject: Re: [v8 PATCH 05/13] mm: vmscan: use kvfree_rcu instead of call_rcu To: Roman Gushchin Cc: Shakeel Butt , paulmck@kernel.org, Kirill Tkhai , Vlastimil Babka , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , linux-fsdevel , LKML Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ar7kxfa411y7ybw76dfursj7icn5nao9 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D8566801914E Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mail-ed1-f42.google.com; client-ip=209.85.208.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615234947-26405 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 8, 2021 at 8:49 AM Roman Gushchin wrote: > > On Sun, Mar 07, 2021 at 10:13:04PM -0800, Shakeel Butt wrote: > > On Tue, Feb 16, 2021 at 4:13 PM Yang Shi wrote: > > > > > > Using kvfree_rcu() to free the old shrinker_maps instead of call_rcu(). > > > We don't have to define a dedicated callback for call_rcu() anymore. > > > > > > Signed-off-by: Yang Shi > > > --- > > > mm/vmscan.c | 7 +------ > > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > > index 2e753c2516fa..c2a309acd86b 100644 > > > --- a/mm/vmscan.c > > > +++ b/mm/vmscan.c > > > @@ -192,11 +192,6 @@ static inline int shrinker_map_size(int nr_items) > > > return (DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long)); > > > } > > > > > > -static void free_shrinker_map_rcu(struct rcu_head *head) > > > -{ > > > - kvfree(container_of(head, struct memcg_shrinker_map, rcu)); > > > -} > > > - > > > static int expand_one_shrinker_map(struct mem_cgroup *memcg, > > > int size, int old_size) > > > { > > > @@ -219,7 +214,7 @@ static int expand_one_shrinker_map(struct mem_cgroup *memcg, > > > memset((void *)new->map + old_size, 0, size - old_size); > > > > > > rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_map, new); > > > - call_rcu(&old->rcu, free_shrinker_map_rcu); > > > + kvfree_rcu(old); > > > > Please use kvfree_rcu(old, rcu) instead of kvfree_rcu(old). The single > > param can call synchronize_rcu(). > > Oh, I didn't know about this difference. Thank you for noticing! BTW, I think I could keep you and Kirill's acked-by with this change (using two params form kvfree_rcu) since the change seems trivial.