From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7BFEC25B08 for ; Wed, 17 Aug 2022 21:10:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CBA18D0002; Wed, 17 Aug 2022 17:10:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 353AD6B0074; Wed, 17 Aug 2022 17:10:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F44B8D0002; Wed, 17 Aug 2022 17:10:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0C4AA6B0073 for ; Wed, 17 Aug 2022 17:10:40 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D809040ABF for ; Wed, 17 Aug 2022 21:10:39 +0000 (UTC) X-FDA: 79810328598.29.DFF73E8 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf07.hostedemail.com (Postfix) with ESMTP id 73285401BE for ; Wed, 17 Aug 2022 21:10:39 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id p125so13073797pfp.2 for ; Wed, 17 Aug 2022 14:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=jubgmtu9ZCV2QamN97BJw9SKo7GeHiKN8FVBsuK4MpI=; b=ht0aNzrRUImTnu8m1fHSTGs+ufFWe/8x7bzHLosVnh7BI1beTfMKcxipuQ0yK5aeis 9slQDNzhO5mKIxJGUa2m6YRI87WzGWk37jrmGvTQhUY/oPtIPce3BMRowls9MzMKTwUB bkE2Da0iUdGcVkeONg7sUqORvzcdE5CZOZAWlY4Cx2EN0f5FkB5lNy5OAuwZvhcDaZRt KvHtVJDhe/ZpIpdLnaFfelO8+TiwhFpYyu6B63i+hB/qUo4iPV5H5ZGcvDqbGRHsZDJ8 fOT4hjPork4yl/xLMWag47Aynp0q/xot6f/Zvd+/f2Wv5yX6E6LbpcalrtAphtGsuB5S Inxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=jubgmtu9ZCV2QamN97BJw9SKo7GeHiKN8FVBsuK4MpI=; b=5fdehp0skJd+mlYEo0b4nu9f/SbSSJOR1f+YhEHiw5f49T6kB/D7FO3hA/zwPzmQ45 6FyP4Spdb9DVQ3uy8uvnKPOqZM8MwqkzjtiH7GpffT0Z3VZ2HSf2836ABvxex8gU96bc 24CblI2cKJrx0T7fHRjrE0bXu6rWAesNKQKhaKVt8q5hLSyGUFiyVUZqZwm9xakidD6G KPJtHrT5KMG/TTSPFLae2NL/V4Fxz6EoWavrjDHas7linI12vvI+xJS/sQopnZ8ohfJa VA2JUYur91cEFBDalrPaQoAvD2TsgEroGF7s7bnhj8ZPVyEYeME/nUYG+E7QQZzyRo1M 7XNw== X-Gm-Message-State: ACgBeo2dJQOMsc/vmC3LiIgJe+0lgKgHl4SxyyYSd/umM28L4jMn4N9L HnGK1a/RrMPhVaj0RMTZWrrqJRkIJJ78HgDErXdrmXCZ X-Google-Smtp-Source: AA6agR7OHj9u+NNZWCSUmy9mZH1jQdHUoh0nYfg4H0rqmb+tvXKvWXUpgTNlfNERRBskRQ4BtwiN4ZxYDsQ648A7/lE= X-Received: by 2002:a05:6a00:4393:b0:52f:3603:e62f with SMTP id bt19-20020a056a00439300b0052f3603e62fmr13087pfb.23.1660770638491; Wed, 17 Aug 2022 14:10:38 -0700 (PDT) MIME-Version: 1.0 References: <20220816185801.651091-1-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Wed, 17 Aug 2022 14:10:26 -0700 Message-ID: Subject: Re: [PATCH] mm: memcg: export workingset refault stats for cgroup v1 To: Shakeel Butt Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Cgroups , Linux MM , LKML , Yosry Ahmed Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ht0aNzrR; spf=pass (imf07.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660770639; a=rsa-sha256; cv=none; b=jWESCtBe4Nw0QyqXl0FQjTFhVecyz7lKHx63jd1sgorLplWkeKTBPHtdTE09Bs1CHwacbo LLRbJI4j2JTCvBaPb6hc21obVE8ckG0shZ3/MUH2sqvF85Tsu32cM5/F6iUpqvyabPJUY8 nBC7tAgfuU8J4yYyH6oNYEQFK6nPYVE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660770639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jubgmtu9ZCV2QamN97BJw9SKo7GeHiKN8FVBsuK4MpI=; b=Fn8HrQ9pfQaktl0vlR3XKg9p9TmLMY2m87lATTf7uVGSaaeXzL8CQKtvK4YD14u9dWaaQY 2zgIHLzwGO7AgQ0a6A6GfzExNJlv9XyN8dUkEICe0NRliYb8Av9Iu2+xqFdHS4MhVaSdD7 fdKKy38S2fGkC7jEWrb6jC8L20IYHas= X-Stat-Signature: jpay3i51wz9fqbtjdq7d9jkn8za8fhx8 X-Rspamd-Queue-Id: 73285401BE Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ht0aNzrR; spf=pass (imf07.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1660770639-33669 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 16, 2022 at 7:05 PM Shakeel Butt wrote: > > On Tue, Aug 16, 2022 at 7:01 PM Yang Shi wrote: > > > > On Tue, Aug 16, 2022 at 3:06 PM Shakeel Butt wrote: > > > > > > On Tue, Aug 16, 2022 at 11:58 AM Yang Shi wrote: > > > > > > > > Workingset refault stats are important and usefule metrics to measure > > > > how well reclaimer and swapping work and how healthy the services are, > > > > but they are just available for cgroup v2. There are still plenty users > > > > with cgroup v1, export the stats for cgroup v1. > > > > > > > > Signed-off-by: Yang Shi > > > > --- > > > > I do understand the development of cgroup v1 is actually stalled and > > > > the community is reluctant to accept new features for v1. However > > > > the workingset refault stats are really quite useful and exporting > > > > two new stats, which have been supported by v2, seems ok IMHO. So > > > > hopefully this patch could be considered. Thanks. > > > > > > > > > > Is just workingset refault good enough for your use-case? What about > > > the other workingset stats? I don't have a strong opinion against > > > adding these to v1 and I think these specific stats should be fine. > > > > The workingset refault is good enough for our usercase, but I don't > > mind adding all the workingset_* stats if nobody has objection. > > For now let's just start with what your use-case needs. If in future > there is a need we can add other workingset_* stats as well. Sure, works for me. > > > > > > (There is subtlety in exposing objcg based stats (i.e. reparenting) in > > > v1 due to non-hierarchical stats in v1. I remember Yosry and Muchun > > > were looking into that.) > > > > The workingset_* stats should have nothing to do with obj based stats IIUC. > > Yeah, that was just FYI for anyone in future who wants to export such > stat in v1. Thanks, Shakeel. If it looks good to me, would you please ack the patch?