From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22CA7C433FE for ; Mon, 25 Apr 2022 18:47:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33AA86B0075; Mon, 25 Apr 2022 14:47:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C1B86B007B; Mon, 25 Apr 2022 14:47:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1632B6B007D; Mon, 25 Apr 2022 14:47:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 0253B6B0075 for ; Mon, 25 Apr 2022 14:47:17 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B217827ECF for ; Mon, 25 Apr 2022 18:47:17 +0000 (UTC) X-FDA: 79396284114.06.E42CB74 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf31.hostedemail.com (Postfix) with ESMTP id 5010120042 for ; Mon, 25 Apr 2022 18:47:10 +0000 (UTC) Received: by mail-pf1-f172.google.com with SMTP id a15so15623857pfv.11 for ; Mon, 25 Apr 2022 11:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=652mnymtbDgCCX9g5fGs2OnolWX/AZW131cU9D4UNAk=; b=gl89Cnh2lJYKdg3GPzzOhMqTLilZsOPpNw/KN6mi9AO3sqOwtwMMLFh+KkNPA8CrB6 4RHte8YlX2j16gJdg+5MRI7KRe/g875gM+sdWDiMzwdRz4UJjSwf1xZ29d5jsvoHzEQt RsQgmlzeJz6vtTJnb4SAaMctVwhm7N/P6Uy4K4oh3L6EJ+Qu+utYcZ1+/29EUtPV5WIM B+cRPz4ZIXSuOoV6yCfMTeD5n5j9FRM0kHV0PBW7cZUqWspTYn24w354aEenygTq/ErA fcmn5Vj+hRcgHJsSJhyvUYCf7vff7uxe1VMiJlZsM1ZNBeWsCVE6Tt0xrzX2arCgJm72 AY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=652mnymtbDgCCX9g5fGs2OnolWX/AZW131cU9D4UNAk=; b=nZaOs9/mMZJmES6B1F8BKNFsOy6jhhm7IDHnWaoJ+wAkJg1zk9dnQ4bzxvMgsgjHsX w04We/6VPzDrKCItJWCIPtrgi1ZWO0jMbSgKsF0F9xUhIRddXZEpFV8SRKVzuWYb+UIQ 7Ns/01EQ960dve6v97mvn1/dDhNveLEjmVKBS+5uruklYZTPyMuOhEDWEJ67B94wEnCx Ive+mhfPMmx77mZnCJnL6ACnXrexztrQCyZC/rjyqFOjmuMqkrtIdd/1CX65/likmUbe YhzyiVol3TneiIFe8jkhnYT1TXCn/08s8VlV7NCc3utCV6x8i1PeDtyeIF0Sie3+bzny b6SA== X-Gm-Message-State: AOAM530yIgvghnSHRG91ddt3B4lDC+h3ILFTzg4rcP3ZRo9rUmqK3W8E 1bZT1JrrmMGkDADbIgWd+fdP38kgljjXHtf7NSQ= X-Google-Smtp-Source: ABdhPJwtbuMeTN7q5Hh0mfJeFx1L310lE9wKnEmBcYRj1tOoqnFC72yhOcEB0RPPiT/u8XFHhA/7hnH7ZHRWoipj7Zw= X-Received: by 2002:a63:8442:0:b0:3ab:2451:5239 with SMTP id k63-20020a638442000000b003ab24515239mr6849412pgd.75.1650912436221; Mon, 25 Apr 2022 11:47:16 -0700 (PDT) MIME-Version: 1.0 References: <20220424071642.3234971-1-xu.xin16@zte.com.cn> In-Reply-To: <20220424071642.3234971-1-xu.xin16@zte.com.cn> From: Yang Shi Date: Mon, 25 Apr 2022 11:47:03 -0700 Message-ID: Subject: Re: [PATCH] mm/khugepaged: use vma_is_anonymous To: cgel.zte@gmail.com Cc: Andrew Morton , Linux MM , Linux Kernel Mailing List , xu xin Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gl89Cnh2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf31.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5010120042 X-Rspam-User: X-Stat-Signature: 7wg4wnajmehtzpn7w85nidsyfboratyr X-HE-Tag: 1650912430-984275 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 24, 2022 at 12:16 AM wrote: > > From: xu xin > > Cleanup the vma->vm_ops usage. Use vma_is_anonymous instead of > vma->vm_ops to make it more understandable. Fine to me. Reviewed-by: Yang Shi > > Signed-off-by: xu xin > --- > mm/khugepaged.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index cb43c3aee8b2..ba8dbd1825da 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -466,7 +466,7 @@ static bool hugepage_vma_check(struct vm_area_struct *vma, > if (file_thp_enabled(vma)) > return true; > > - if (!vma->anon_vma || vma->vm_ops) > + if (!vma->anon_vma || !vma_is_anonymous(vma)) > return false; > if (vma_is_temporary_stack(vma)) > return false; > @@ -982,7 +982,7 @@ static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, > if (!hugepage_vma_check(vma, vma->vm_flags)) > return SCAN_VMA_CHECK; > /* Anon VMA expected */ > - if (!vma->anon_vma || vma->vm_ops) > + if (!vma->anon_vma || !vma_is_anonymous(vma)) > return SCAN_VMA_CHECK; > return 0; > } > -- > 2.25.1 > >