Re: [PATCH] mm/khugepaged: use vma_is_anonymous

[Yang Shi <shy828301@gmail.com>]

On Sun, Apr 24, 2022 at 12:16 AM <cgel.zte@gmail.com> wrote:
>
> From: xu xin <xu.xin16@zte.com.cn>
>
> Cleanup the vma->vm_ops usage. Use vma_is_anonymous instead of
> vma->vm_ops to make it more understandable.

Fine to me. Reviewed-by: Yang Shi <shy828301@gmail.com>

>
> Signed-off-by: xu xin <xu.xin16@zte.com.cn>
> ---
>  mm/khugepaged.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index cb43c3aee8b2..ba8dbd1825da 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -466,7 +466,7 @@ static bool hugepage_vma_check(struct vm_area_struct *vma,
>         if (file_thp_enabled(vma))
>                 return true;
>
> -       if (!vma->anon_vma || vma->vm_ops)
> +       if (!vma->anon_vma || !vma_is_anonymous(vma))
>                 return false;
>         if (vma_is_temporary_stack(vma))
>                 return false;
> @@ -982,7 +982,7 @@ static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address,
>         if (!hugepage_vma_check(vma, vma->vm_flags))
>                 return SCAN_VMA_CHECK;
>         /* Anon VMA expected */
> -       if (!vma->anon_vma || vma->vm_ops)
> +       if (!vma->anon_vma || !vma_is_anonymous(vma))
>                 return SCAN_VMA_CHECK;
>         return 0;
>  }
> --
> 2.25.1
>
>