From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BAE3C433DB for ; Mon, 11 Jan 2021 19:00:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BD32C22ADF for ; Mon, 11 Jan 2021 19:00:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD32C22ADF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 184756B013C; Mon, 11 Jan 2021 14:00:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 135F46B0196; Mon, 11 Jan 2021 14:00:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F17866B0197; Mon, 11 Jan 2021 14:00:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id D77B46B013C for ; Mon, 11 Jan 2021 14:00:35 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 58E20362C for ; Mon, 11 Jan 2021 19:00:35 +0000 (UTC) X-FDA: 77694410430.28.scale07_3e082202750f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id DD6336D80 for ; Mon, 11 Jan 2021 19:00:30 +0000 (UTC) X-HE-Tag: scale07_3e082202750f X-Filterd-Recvd-Size: 3600 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 19:00:30 +0000 (UTC) Received: by mail-ed1-f45.google.com with SMTP id v26so820901eds.13 for ; Mon, 11 Jan 2021 11:00:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uzP+1DGQOIvMcrmW5euTCx4qruv4FZRB/uAKoISXx7g=; b=vYvjvw2VygIPnmh6It2+CmmoRmokSmmdOVcghJAay5P0gwOKgCtrJIRfxmNk2JQ9Gt Yp0EGdFJPRo/PUP/Tvb5Co7yP6dVVCNru/NvggkdIy5K54ABaJH9xQODCLmSHkFnFRIy ep+ZBEwOBxlwgelNEP5kkgO2CNeoE9ZK9v8Oa6dRWAv7JOM/RC+4tBCCA1UZiJig1v1c 7j14pM6nHFGOWjiKadNnZvQpLqTEU7rmlkd2GSB6GAxQCnL6MbK/HH8V4K9Jvc68mdVQ ws2kbYHyusZvYf84yhPCtP56WXOvrGTi9ph1iWYcDNx5QmkaFOvQO6OVVLmgsoBmNXAd d33A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uzP+1DGQOIvMcrmW5euTCx4qruv4FZRB/uAKoISXx7g=; b=QrI/tcYmkJp6SnPXJgoR/5dGigsmK2EBOTX1pov1JSSg+yVFRCTo7PEBXISGTJLXTV 3A4d8TmFyojVRdD/oHGOf+XfEWrOplmPy87TKuJjWkGCrYKczqyCxHPjqVP+GvRhhXhW pUFKaYBZG1L5xsFlK2jPEhaL2IgJOBgIAG3mHweB+KRkbyQm8cLHzhT+mCYvDYyxHa+g puyNEEK/LIng2BsAifjfxaHo8b1b6Y3QcIso02Ar42YCgj1KskTbz+hC2wJmgdLwCmFT LYGQW10DReTDfC2HGMHn+mMKhXQj6nJ0ifO9RvQP+XhksiNecW+NIQk1v5KGn52PwB7e HWRA== X-Gm-Message-State: AOAM531JnBhS6ci81xP6pJzoBAZjUlsgye7FVxAd2+Q5ZjzUe50ALxc8 Oc9iQxSlngYjY+RG0keQQ3fRAbMkfOyZ4JLu9V8= X-Google-Smtp-Source: ABdhPJxstPPw4CO3o1D30g5iH8wIXuWOW04btKKyxK2E6Wtyijem6zZOJ+FxolNGIMsJ4KvkthSWqv5R7y1ou0a4L1Q= X-Received: by 2002:a05:6402:c95:: with SMTP id cm21mr593253edb.294.1610391629218; Mon, 11 Jan 2021 11:00:29 -0800 (PST) MIME-Version: 1.0 References: <20210105225817.1036378-1-shy828301@gmail.com> <20210105225817.1036378-3-shy828301@gmail.com> <20210107001351.GD1110904@carbon.dhcp.thefacebook.com> In-Reply-To: <20210107001351.GD1110904@carbon.dhcp.thefacebook.com> From: Yang Shi Date: Mon, 11 Jan 2021 11:00:17 -0800 Message-ID: Subject: Re: [v3 PATCH 02/11] mm: vmscan: consolidate shrinker_maps handling code To: Roman Gushchin Cc: Kirill Tkhai , Shakeel Butt , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 6, 2021 at 4:14 PM Roman Gushchin wrote: > > On Tue, Jan 05, 2021 at 02:58:08PM -0800, Yang Shi wrote: > > The shrinker map management is not really memcg specific, it's just allocation > > In the current form it doesn't look so, especially because each name > has a memcg_ prefix and each function takes a memcg argument. > > It begs for some refactorings (Kirill suggested some) and renamings. BTW, do you mean the suggestion about renaming memcg_shrinker_maps to shrinker_maps? I just saw his email today since gmail filtered his emails to SPAM :-( > > Thanks!