From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A3C8C77B61 for ; Mon, 24 Apr 2023 23:05:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B29BF6B0074; Mon, 24 Apr 2023 19:05:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD95A6B0075; Mon, 24 Apr 2023 19:05:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A11B6B0078; Mon, 24 Apr 2023 19:05:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 86BF86B0074 for ; Mon, 24 Apr 2023 19:05:47 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 50D488043D for ; Mon, 24 Apr 2023 23:05:47 +0000 (UTC) X-FDA: 80717818734.19.F543366 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf05.hostedemail.com (Postfix) with ESMTP id 81281100008 for ; Mon, 24 Apr 2023 23:05:45 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WD+ceziX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682377545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VQ8sFzZ9vlAXommM0w2/PXvGSOKBNi6JzIA9K33bVAU=; b=CWU9RoyzcbDQR3eWfViCizsy9bB1VEedYa2tOqCl6dGc1+vZLV/EHqmP1EHsv9V+25i+9m jrpiMH3bvUEUAlGCN6jUcm9dOiFrn1ljWcKy3+kJ/QAoFDQWnom7kFkKTrlkRuhb9c0MdP NH2Jp0syo94PjKRAqNQdk29H5nb5OSU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WD+ceziX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682377545; a=rsa-sha256; cv=none; b=xzM8Y2Xow7ajUf7TSnfT8GG9GpcnzQ8q9/97UiZqFQgXT5/pe76CVXfp3eNDJ546o1c/Lo SLS4TnkVyhxIrVcFNgjrStXiZxaXzmyL4cgMSy9sBVEhsXD038+52F/k30rDBE4sSOExwP Oq7nEl+5wXrqoPTMC3wKt/BbSxKwLoI= Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-24756a12ba0so3548329a91.1 for ; Mon, 24 Apr 2023 16:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682377544; x=1684969544; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VQ8sFzZ9vlAXommM0w2/PXvGSOKBNi6JzIA9K33bVAU=; b=WD+ceziX6bq4nghbfbXLNklOmtmN9i6mL4/A14bPp9VINUyoFGGw8A0p3dQ34YR+WV V9UR0Cc1hxLra/AnBrIM2gSUcmRFtrM5vgBmxBXyH5v7k/iTTDcarBsO+NVHuUmNRLqk dSPFhIKxc3ozN6inFnMIifOSp0RHJ/2bfCVGkAJqyAaWeKXijbsqYI4AwyageV940smm vD8mw7+iTiazzzJQjSbKJtwtb48sO7QbkT+1hYFzC/8SxrZf/CzoX0kZPwM3nS41A+6/ q+e/CJ8lPeZJCI19Jmmuvmazx2ljqsBXJIf6qkom4c4wGxwyamVIDb5oE81/KJI0NGbi vljw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682377544; x=1684969544; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VQ8sFzZ9vlAXommM0w2/PXvGSOKBNi6JzIA9K33bVAU=; b=JJZYzMxyvpuFSz8tSv2Ma1LqxHv0nKG0inViKthCZnAyxC3oByLNeAEZ5G9LXUlbl7 iPnsBEhVOda9oFStkjMA2Mm8gDgNQskE9pKGPyuQ+gq5e9MOx/HDx+8oM5duCE+LShaz 2cOjNp1etoARggiU8d+Y1qc2ZGCaZjUPRay11GocuRBMGFLaihx6yiNbd73j/MOmRimV Kx+tAFLrf0rjwf9pVFbCDGCG6KoKIHyFS1/uD52JPZ+EyPIfIJRLHlQmqjVtU67WjkuP 5UUCgc3e71gdXXpMF4IpbTDkipa9fbd2VhIglDffDR1dBa22V5rySYRB4+bQmk8m7Tm4 aNbQ== X-Gm-Message-State: AAQBX9fW2RH9CSVqcsc33zgGw7/yAa3VEazS1DrvDhMie1v7feGfcRCM NrDx53cTPJS6gaQP0W/O+Nk46R9POeHQKZHJqTI= X-Google-Smtp-Source: AKy350YiJuL4duFP78n+ItNB+lUpN4w+zRdMWcrBiJgXD2Qk753AS4CLImpFJFw1UHLIr+HVloJCI3jyLWK4zIDEzVY= X-Received: by 2002:a17:90a:fd17:b0:247:1de8:8263 with SMTP id cv23-20020a17090afd1700b002471de88263mr16233416pjb.4.1682377544182; Mon, 24 Apr 2023 16:05:44 -0700 (PDT) MIME-Version: 1.0 References: <20230421214400.2836131-1-mcgrof@kernel.org> <20230421214400.2836131-3-mcgrof@kernel.org> In-Reply-To: From: Yang Shi Date: Mon, 24 Apr 2023 16:05:32 -0700 Message-ID: Subject: Re: [RFC 2/8] shmem: convert to use folio_test_hwpoison() To: Matthew Wilcox Cc: Luis Chamberlain , hughd@google.com, akpm@linux-foundation.org, brauner@kernel.org, djwong@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, hare@suse.de, kbusch@kernel.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 81281100008 X-Stat-Signature: xoniisqmjenj4m8c6hkr8cmda6ynsijd X-HE-Tag: 1682377545-977448 X-HE-Meta: U2FsdGVkX1+BoYDpEp50i+vHhMPPmlPLjZ7ZKrz/fUPiM5Il+6RczpqwT7/KHtzcIAIXxhndqtMwvzvzcpkkmB0K5wuA1Cm92Z0hiVI/nLinVkL1cVe2a+wP5QnqfBs/GbWmhjqew68YTCk1m5iVqOh8SPEOdMbg/sje3StEMXhk+MK4mQ95P/SFi7yia5oKjLv1k0wjpfiTt+j+r47H9ZOBEUISEJlzi3mVzOy7iMaySA6EQVlJQdhNYuB1oloB3GjXP4iPscPFXlnhgEb5mPVykEllz9zLP0MtMuWARiWRtcdaq8WUHBK8GT+34pUofl7+W9n+FbCNap2JCXn9VrX0zmHY5U+8WYlnEjywASuhylflGc/4L5XAENztUT53bydp4oYlpeYd9jlpOB4TAWCg7V+8mJuUigT3eiwG01r0VFUDW6mheSqITiOt4EwGkB7HvS3882igywrqhRCwzvKm39DMMpwMIwJ82Peho/tmmALUpaKdfe9Sd1aVR3xv0ZvuHSs6Ih5WVDIuCdvM0lx5tLgNifKMbfazMIXr1hkW4XzmZ724admHlEUaSP55BG9bBSZb3TVC91I1mAMMrE0MEdK5UTvSRldpoezZuHIQ1av9gNVzXl68H/vX7stw0IZwgOmOwlzqmMEAnPE2uTC18SDYQaJD/hsS4U9lq2dd8YUfjx1t37hdXW/sbCT5FyTcBH0masnaDtXCDFCnD9RVvdZb6RCmPf6CLTKYUKH7Hch8RFo9WD7COlPLVM2EJ3rLzmmUs7H9c45vGCZowK2+EC86KGjyrJCGggPmppSLytFhoBhfccc9j4D2cjku6IWpKLDq/q1LMb6WFAek2QMZKJwDe/Q73LgI9e3mxDdZ5UrGxvsgk4XL5F5civosl/JRBV4zZ1wKsiOjf7d3LvzaYd7BaJDl1W75eglq7fM/W4ZAPG0vTSQodrCvUJw0s0nu4q6BGXcVbCNM98v ViezEsQA b/e1EmVjNXhZ8mgdTKceIwem65B+GOfwCJmmGhIxYf7Ar5Zev8r1YaVOnbCBKpf7zHcvMM7FEY/vlHK5mmPlvElxwb2P3zbpiRoA2U5kITSkI6kWJTS+EOY7WMMml/5FwruClelXikLuy/beuMCBHnh/zOLsyGyaORH32laDB7tx6UoPiEZqvaL0SJ5W8Qu78ie0JwfudmBW6Ovl67T+J+RAeJj71ia0PB2X2UZyjNl8hBabcD91AIoCT7pj7lzr2uLLF1gvt2FYbcdOSeDAFxQ2a/RyCFgbMYjjDcFMFup4IPWm0uazb9OAqc3xscMCO7Z28y44iF20/vRHI2TE03DLY41EikL189xnbPvRSSlcCGJ0WmNj/J21T5Ydjil86+iKq5GtzFYKx2uD3ldl+4dIkMd/cLqXxa1yYxkgHq4PiikNkJ8NY5Ggz4/RgZxzNlbY0lhcMGSLDlLkBbjEfTK0kcWFZM+cajNio4HNpZ/M9VTXLqW4A8C5bNsGrUe9rFGbqjmD8KBFgpQE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000230, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 24, 2023 at 2:37=E2=80=AFPM Matthew Wilcox wrote: > > On Mon, Apr 24, 2023 at 02:17:12PM -0700, Yang Shi wrote: > > On Fri, Apr 21, 2023 at 8:05=E2=80=AFPM Luis Chamberlain wrote: > > > > > > On Fri, Apr 21, 2023 at 11:42:53PM +0100, Matthew Wilcox wrote: > > > > On Fri, Apr 21, 2023 at 02:43:54PM -0700, Luis Chamberlain wrote: > > > > > The PageHWPoison() call can be converted over to the respective f= olio call > > > > > folio_test_hwpoison(). This introduces no functional changes. > > > > > > > > Um, no. Nobody should use folio_test_hwpoison(), it's a nonsense. > > > > > > > > Individual pages are hwpoisoned. You're only testing the head page > > > > if you use folio_test_hwpoison(). There's folio_has_hwpoisoned() t= o > > > > test if _any_ page in the folio is poisoned. But blindly convertin= g > > > > PageHWPoison to folio_test_hwpoison() is wrong. > > > > > > Thanks! I don't see folio_has_hwpoisoned() though. > > > > We do have PageHasHWPoisoned(), which indicates at least one subpage > > is hwpoisoned in the huge page. > > > > You may need to add a folio variant. > > PAGEFLAG(HasHWPoisoned, has_hwpoisoned, PF_SECOND) > TESTSCFLAG(HasHWPoisoned, has_hwpoisoned, PF_SECOND) > > That generates folio_has_hwpoisoned() along with > folio_set_has_hwpoisoned(), folio_clear_has_hwpoisoned(), > folio_test_set_has_hwpoisoned() and folio_test_clear_has_hwpoisoned(). Oh, yeah, I missed that part. Thanks.