From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF663C25B10 for ; Mon, 13 May 2024 19:05:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68E966B0085; Mon, 13 May 2024 15:05:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63EE06B00EF; Mon, 13 May 2024 15:05:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 506686B00F0; Mon, 13 May 2024 15:05:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 334A06B0085 for ; Mon, 13 May 2024 15:05:44 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A1A20809A0 for ; Mon, 13 May 2024 19:05:43 +0000 (UTC) X-FDA: 82114301766.03.38233E1 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf29.hostedemail.com (Postfix) with ESMTP id C3E79120019 for ; Mon, 13 May 2024 19:05:41 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AFLbBs48; spf=pass (imf29.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715627141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CHVX7QXs7ZSa+q8I5S8KqDQd8wCAFFUEKhPAoKqf6Lk=; b=jpZppr9cGSbNfSVV1TajqeBT3F1CDo8JyoyZUo/q101Cc/p4PbZ1z+cD+wNlHCZIlvLbli +bb9RBRoJJ0E7jsUlqEQGngZeP9+UUSfIpEGl8wQIZBvHEe3HCSj3OKD7q6TBrbQ6hGOAh baOEJBI2ghXs/mnjaP/6vsyTkFDCj+s= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AFLbBs48; spf=pass (imf29.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715627141; a=rsa-sha256; cv=none; b=36hSr88N3aggNISL7MupPVrJJMaAh6OsYAk3We9eypgyk2FponAP3v/EoE6EU+Ual0VYB8 ChAmjE3ABL8358xy5OXNxYgbAYtqP9wY+QDW5Wak9Aedmtqz6LA2dDObt9aMTJG5B5MQHB HnMR3767UElUZYRugjbcmUpUg5RYbz0= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a59a934ad50so1123858966b.1 for ; Mon, 13 May 2024 12:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715627140; x=1716231940; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CHVX7QXs7ZSa+q8I5S8KqDQd8wCAFFUEKhPAoKqf6Lk=; b=AFLbBs48v6YTIk0z0wvIvyxlVIEQDE68lkWqqzDDcx9tb+yrfLbAG1Ysoqiz1CiMDa Bf6ebeVwmDuTusgw/j2F/0GAMDlidWZwc5QP6Wd2mFUFE1AuxYw5O7ZIWKlJdqYueN6M Ywaz/LWoJK3zZGzLGsxhNLW3e0ddhr3wyfsv4N+9y8FBQhMm8i+iEEVJiqpjmdSZMh+d HFElmV3W+eMJlU5pDxtD+ogK4J+g1p8eUfeObJKWmvmQFFc64Y+OpSmI8v1nEcq5FIY4 wkhsMYB7krgPMC/lvo/rqtYbTFJD2s47i0I/KkkMBd1PFX/xE7VSdP910yd7Jn1WQSWq EX+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715627140; x=1716231940; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CHVX7QXs7ZSa+q8I5S8KqDQd8wCAFFUEKhPAoKqf6Lk=; b=Z44hskF5Fxl8xQ77Y5Qg1hjnjuisO69ymkjhlUYRkm14iBjBKuMhsC9Z85mTWu7MWu OBNP0qjzjWEGKQQWte7QvkYrtFfNOgsaJ0XF5Yp43nIEesbYlgFlZYqxTkXTMaHn0u1E JBe96Om5DI5SZg9I5kzcpkgm7Vl+Q6cCGF+9PiQ2ESNCDB5tL/EJZ5ScTJDBaXBguF1w RkvkBZvPKhZ/ayI+4Ma1/M+wzdflXGGXXqdKaiJAAQ3/3FWor9bzf+tBZxARkTI4Tic9 LnUNqiwBeZQ998QeJyC4I32G14w/2U4XARtLwKAerF6KV/hVgw7Vo/MiuuvcKiXycorO cJSg== X-Forwarded-Encrypted: i=1; AJvYcCV13LuS+QIa6ffeiV08EsS88IFGoK6gMaQJoVWEPqhM63aTVhPyxguu0PrlO1j6aT9qoF2SgBbqAlTkjwaN8RJ66Bc= X-Gm-Message-State: AOJu0YxHDAx3R6aD8IhC8g6ngqN+0IIL/P1fPaboIsRgb0tJsXUI8I04 R+MDQX0cdzZoDumdWHXk8l9fUch9FK21bzGDkFfZvAHDBJXgfmL5/v3yoaVPRZc/eVyLOrmoRAE xbqnT1Xul2R/kRdGZ0tV/uG5cr28= X-Google-Smtp-Source: AGHT+IH4rmR4xsSXCatjltSOvwUNkDDuHMcxrgtq9uAeiRNRjJeeJdSe85j2T7CEAjDXKJvEXbnP/y5oVYem1LsioUw= X-Received: by 2002:a17:907:3f9f:b0:a59:cd46:fe89 with SMTP id a640c23a62f3a-a5a2d665690mr830382166b.59.1715627140010; Mon, 13 May 2024 12:05:40 -0700 (PDT) MIME-Version: 1.0 References: <20240511144436754EiKfJM4xjMSTyCbEExwcL@zte.com.cn> In-Reply-To: <20240511144436754EiKfJM4xjMSTyCbEExwcL@zte.com.cn> From: Yang Shi Date: Mon, 13 May 2024 13:05:28 -0600 Message-ID: Subject: Re: [PATCH linux-next] mm/huge_memory: mark racy access on huge_anon_orders_always To: xu.xin16@zte.com.cn Cc: akpm@linux-foundation.org, david@redhat.com, willy@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ziy@nvidia.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: iu885wrm8s679co76i4jyd1q5mb5xkc1 X-Rspamd-Queue-Id: C3E79120019 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1715627141-771733 X-HE-Meta: U2FsdGVkX18CnYL9ZHpBc/D3BT+Z94BoS6Vnd4zwTest6V2cvo+QwVKwKyYnJHGr3G9+wSbiSCUQhpPZfhzRL5lWYoNvEg9yoPks5ac+CPUaO7txnTIIJS7nlu28tvp6mAYWGABccGDAJh1C648nD9EU8+XeyDWCjdT4OvAOJuPJQHqNjvHUkDv/csQAQHW/SAIEyboP4M5L95XhmUtTmROkISZNwEiuIkvzW/w9MylBDFinn3TfvHraI9L+bZ/Z3l9xF2PjtP7XJbUYZIRyPVrmLtzAPDOO4GziOpRfN2mQUAair+cZ0hBe7pYvSaouPh6kxseuCnINHgSOpWOBZ06tSudYPYyaBU8sSRhO/xl1gq7cFxGJqkmeTDcv85mvWupNRr/pF0mD0rUuNcAcSCWc1jS/JJcENIkdwVP8rJxBuh7sj9/eBPPJgWur6lW+wJW8eDmddFtd8IAODhG5BqMo16JQQbjmFabay7olHjuHjOTYDnfC/yE0NKmTruHzM9xAr1IRwu/r9GU4Asw1S2mjH6LVxAi97vikT3gcbZVyWAhHSEcQxIym6JnBsIKRa3N3T8ei39UwK2pabNAC4aWW6DcuiH5v3qFfBra++6bOi2f3qPEXPX9ElZ98jtj0rNCEfd7J0UdxewLwYhypne6K0ZgBy0aiOsNQDy71btayNS23EFvdnsDmViYGBTLRz/NGUtCrvy2mYZLUBn7cpJ0EcD3+DOdnfrLXRh5JU7NPqo/ZeEWPjO9pXpkV1BCbLHdPYV99EEiubjhS6FHMMF0hHMzBmza0EyNFJJrn+q6Iw8hiheb7UQwdAp8EUBjQw099NRCcV4/FMkm/Fqzqn16WdHjCu1yzwjjDPWuhurhcr8FISh4Nbmif/0QjVQ5dtJfizBDcuWTMaDAJGVj1mnJQJK1IZRKgcb6PjM1rWKEnDrDP/zeSiSrbwCoDb6Fhzsv7DZryu19J/CSOY3C XXFDOIX4 rj3MhCXnFoHfpCV4TGMwhAyO6qnmK7Nxmt6MqkhiLR1IToB63JAjO4QEZA2D80gVzq5mDuqgAOFb/pVpa/BjdRYSQ5sFNQoyb2O6OD1lynRt9GNjgLBZAtORkPJAq5CgjRZG9n2RLI08caoaWKLwWPdgZgloJ59YHZ8XyrmTedFgWtB4a0RNAy/wDOltD7XxndXPWbzXhrQBkX9MxcbnUnyQv2eGxitIiFK6vJq0Dev0/eDrVifNSNvcDkQgMAXRAVjBrZgoUSS6mibsESZpFqReaPOtJ+LQnknot1OrHgvXYw4jAdxa7Ge2vfY9/rlTwinq+bz9AEBCtLKHCdrAL0h2w4JjndZA1hWuK2nKqC56fO3B52kprLBuudk3knMbYaDTCcDRxQ1gwc9gWvvi5jOJ23R1cxiwm8qQx67c6evn80bsdwFxUbWhOdp3uO+rrJm5MGwBYuFyw9XA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000024, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, May 11, 2024 at 12:44=E2=80=AFAM wrote: > > From: Ran Xiaokai > > huge_anon_orders_always and huge_anon_orders_always are accessed > lockless, it is better to use the READ_ONCE() wrapper. > This is not fixing any visible bug, hopefully this can cease some > KCSAN complains in the future. A little bit confused here. Did you see complaints from KCSAN? > Also do that for huge_anon_orders_madvise. > > Signed-off-by: Ran Xiaokai > --- > include/linux/huge_mm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index de0c89105076..6573430ea600 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -122,8 +122,8 @@ static inline bool hugepage_flags_enabled(void) > * So we don't need to look at huge_anon_orders_inherit. > */ > return hugepage_global_enabled() || > - huge_anon_orders_always || > - huge_anon_orders_madvise; > + READ_ONCE(huge_anon_orders_always) || > + READ_ONCE(huge_anon_orders_madvise); > } > > static inline int highest_order(unsigned long orders) > -- > 2.15.2