From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE20DC2BBCA for ; Tue, 25 Jun 2024 20:53:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 509E46B009A; Tue, 25 Jun 2024 16:53:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B8F16B009B; Tue, 25 Jun 2024 16:53:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 359A36B009C; Tue, 25 Jun 2024 16:53:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 165D76B009A for ; Tue, 25 Jun 2024 16:53:52 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8774C1203EF for ; Tue, 25 Jun 2024 20:53:51 +0000 (UTC) X-FDA: 82270612662.01.F4EBB6C Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf13.hostedemail.com (Postfix) with ESMTP id A61BA2001E for ; Tue, 25 Jun 2024 20:53:49 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=D2I1cH3G; spf=pass (imf13.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719348822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z4ZGx+eUj/88bsn4q/UdsOuUZ9dGZXmFOAmGCk7pgPY=; b=xrVWHtF60d9/nCb5kV3/sIaxIe/utOuZueD4PPp/V9SvfP4xCyjpsbXjGTKgJKnfmrnBg8 lOZqaDsj+o2ZCrO+NoSdCrqF1x/FOvEeAdq2zEDlGMDrlMoewbNt5Xge+TqMHAmxFottwD +rEBcynw6TF87Mly04hpGJcc/w5D9OI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=D2I1cH3G; spf=pass (imf13.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719348822; a=rsa-sha256; cv=none; b=rEsCKi5uBxm6lWR93oZIgzedE/zEO31QvILvCGGyxSy7eZlABfOfeDASjR5Paq7n7wsJ4W i0cZb4vHs6bz65OtAGc13GfrVCF+P10uQw2fkgJUKM7euauZMdI9+3K8yBGBsTZZ78Ysbn 9uEiMsC/me+i0OZaE44WCgsniv+KQkM= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-57cbc2a2496so7043869a12.0 for ; Tue, 25 Jun 2024 13:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719348828; x=1719953628; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z4ZGx+eUj/88bsn4q/UdsOuUZ9dGZXmFOAmGCk7pgPY=; b=D2I1cH3GGe6eNg+xND9bwH9lKfJ9tr2ZtqxpJnaS6qXAnFPpuorYh4e0LauU0vz/TZ TgTRYSXqHfvS25ujkZdfAIsCSX9dgxFUDdvL8aqudpEjIUAHF6hy6LMGjk8CYfDaizWb /uPUBnGy/Vl0UyUsa/Rf/mge9pDYsMw5C5fZXYxrKwKCqpZLNkLJTi721CZq173aoy+o 8T8Wc/SCeaYNY/a9KaSe3KJQlKI9hl/OkfBD/NM4ELrUQmxPmaqfRiH0ITjwF0g2f8DP Y6hDWFsXXm9/1XGvlZQL1hDxH8Alfedo0OFwisolQgAs9pgReky6RLGpBBpBxRKJOzVj oMIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719348828; x=1719953628; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z4ZGx+eUj/88bsn4q/UdsOuUZ9dGZXmFOAmGCk7pgPY=; b=lw3vXYmaGFK764fLvobr8zy+eD2QeT1NI4f1AIrovh4KOXciPsXbrCwNqlrjr7PS4s gMJ1wSGi3PiNPJGh2vJbWXmQmhcX7T3VTFZyIf2514+auXRUlzseQVT+CBkvWzMsKwWt S6Uh9gZAvRwKi6wQ+UYdSc53OArItdpitLyZf4rSlf6iTM+OlcB308shy4S8rsQKHonC 4uAr49SRX0d8X8vetYfzAYsnNfadfTBJy7vFRAV0EhDG1CDs57aSi9n3jILSu5tt/O0D FKf7DaPxACoWJIjusDr4qQCF3UP7iaXq/p6QvbFVfmChGm1JpBaieGo5OJa7xVL4Ezqz auPg== X-Forwarded-Encrypted: i=1; AJvYcCXwBwNO7H6J9fZ+pkblj1X978mVvmW+TQ6TGBmBXp+E5ZVaNdykOROd81SK2i+IrD/tnKrgZ6+UJwHwBLp5ZPF2vI0= X-Gm-Message-State: AOJu0YxH8fhGrn9bccMtqlUBK712cV0nk8PazoWGuzGziv7jq7XINJcK M25WlNMAQM6VG05pUgIoEXYY2m5sGuLq5qmg21bExURAbIO58/2QbYSbIitxRu9gU+9S8MvUA/U RtsiNVTPl7ihVTNbdZecvKQmmJ5g= X-Google-Smtp-Source: AGHT+IH5PQs9YzD9mfM0POb5kScQniP/tipBmiBdJrOxOGBmxDIsHGit04FrMCXY53ICfWyLw0tLbXeTFUVpmqdI2fE= X-Received: by 2002:a50:c056:0:b0:57c:5eed:4ebf with SMTP id 4fb4d7f45d1cf-57d4bd79d81mr8081097a12.19.1719348827856; Tue, 25 Jun 2024 13:53:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yang Shi Date: Tue, 25 Jun 2024 13:53:35 -0700 Message-ID: Subject: Re: [linus:master] [mm] efa7df3e3b: kernel_BUG_at_include/linux/page_ref.h To: David Hildenbrand Cc: Oliver Sang , Andrew Morton , Christopher Lameter , Jason Gunthorpe , Matthew Wilcox , Peter Xu , Rik van Riel , Vivek Kasireddy , linux-kernel@vger.kernel.org, linux-mm@kvack.org, lkp@intel.com, oe-lkp@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A61BA2001E X-Stat-Signature: 76jzsrsiw8saia5yscxewppkwe1osyow X-HE-Tag: 1719348829-626737 X-HE-Meta: U2FsdGVkX1+Sv33qjme4zzAAzPPhTir1aIKU68iCqC8txLvK3NwkfShuXW8ToklQBqqKjXfS3v26z54kH2KKjSJc4Ksj37Fx0UCqiJaS5zC8wN5xyZS4pBTqAJyT6tSLvryTdYnb2tvnX7PfKUDl9Haosp+cvi/FcubmxFBDbI0GgeRwSQwuyQcwjR/qT9tMq/CwmzDTniRVZQFpBn6x165oU0I15TnXK9MVr6eUkxmWquyJpRJoZ6j3qUea6UaSy3LZ5SoBDqmTJ1hmA6hnq6DPglwVnfAbxfioYuRiV6GZO0GXBDiyD7edircN5HcRf7ikSBKqjOgSIGPLyhGAMqNzSRKT+yKfI9U51TS6+b2kylgeMLYwRKMe+LQFpMGvdhXpigt+vKBiYk1+oWQgIrnyREstmT0JMlcSh4NJBsufM/KBuqvi5+BVJWuUfF+x476WrM1CE4Ut6yAHoYRcHmUFk6dxqEWW3fGBOCC62FnUiTwUFI3jABe54rfz82ZNH8Ry/O2QHG5hOYcddQwgw28jqFFGSX7ghNj/rmrIaytaq2wPq9XsHG3ubNrayffuSX2X3XmR0tGM+kJgiSNFVwwM2f1r5yO//VwGEtBbpt49Gw47CDN77dbKZxLXRn0PDc+2d27+YP2rPPfNk2w7F2656T/ZayjMpsQYe8ec9NTTdmiJj3CAIRjiYVajVBLcL/bOajXNOX4oIliK673zmvZxU1xUjta+LF33ZlQeSRDqP1c0ITSyU4xCJCJZ5potmu0ntZJLTHwJ0a/N1SfEwFOZ8nucSp3w+6KmYezADc6ryZO1Hsm9Xhhq+VfPezSdL0nx1Yf3rrGVyakJauPCgNXf95QffuEoNTwR0Q3FPCV0OAlLfCDVegSXIPT6uyprDKhqEiXYaggYvZfAEqjMxG/Y1T4Mipqi1RAN8qP3+Umk+WZb2ig7k0rF+uab18IVc5OWE9gsQqHxbVfa3BN HhPL+GOf CJWi12deg6dB07SepHt6g6aOU9hKkFSqw4MlEejuIkTNQoCTDwFmjpEjTOfjuisEIjbRzs4icLLFmKwF8a5MYiuLX0uql7o7gccnG9InCOSDnphfUzqDO+V5dswcxfOzb3hkoUuP9wtUT/CGIcZR88cOKxZO70BhuDMiz5P9ZT9JNelGCDbr2UHACrCA8BMFUCDC9K97Mf142yfdSrYZ7oMogymELwVTfQXg47Www9Q1vtDnzh6lb1g2ZDhCg1baDkgVRVv4BXiKyzWCaZvXR0vJhc2lo1MVJxbxP1Yf92nncOVYBXB1+8s1CyHgUWEYaZjI3ZG3tXbixypfU6FBS7HqpzpCEX9m5nbuIM9nso8ZtwolGWhg+4+x8kHBCKJA9gsGVcoepnR1t4JtRAXyIDTIk/DISAuFMHiPtR4e97evdmYtKWb+T9gtMzuAGuRhJm69b/4brYvrUIaIL21N+zGtVq2Uo0UWt7zdIJhcY2/+s4gyNS+AZ79rsnlTWA4IN1ZmMEGq9F88dIbxP5Qj84wgpRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 1:41=E2=80=AFPM David Hildenbrand wrote: > > On 25.06.24 22:34, Yang Shi wrote: > > On Tue, Jun 11, 2024 at 11:01=E2=80=AFPM Oliver Sang wrote: > >> > >> hi, Yang Shi, > >> > >> On Wed, Jun 05, 2024 at 08:44:37PM -0700, Yang Shi wrote: > >>> Oliver Sang =E4=BA=8E2024=E5=B9=B46=E6=9C=885= =E6=97=A5 =E5=91=A8=E4=B8=8919:16=E5=86=99=E9=81=93=EF=BC=9A > >>> > >>>> hi, Yang Shi, > >>>> > >>>> On Tue, Jun 04, 2024 at 04:53:56PM -0700, Yang Shi wrote: > >>>>> On Mon, Jun 3, 2024 at 9:54=E2=80=AFAM Yang Shi wrote: > >>>>>> > >>>>>> On Mon, Jun 3, 2024 at 7:02=E2=80=AFAM Oliver Sang > >>>> wrote: > >>>>>>> > >>>>>>> hi, Yang Shi, > >>>>>>> > >>>>>>> On Fri, May 31, 2024 at 01:57:06PM -0700, Yang Shi wrote: > >>>>>>>> Hi Oliver, > >>>>>>>> > >>>>>>>> I just came up with a quick patch (just build test) per the > >>>> discussion > >>>>>>>> and attached, can you please to give it a try? Once it is > >>>> verified, I > >>>>>>>> will refine the patch and submit for review. > >>>>>>> > >>>>>>> what's the base of this patch? I tried to apply it upon efa7df3e3= b or > >>>>>>> v6.10-rc2. both failed. > >>>>>> > >>>>>> Its base is mm-unstable. The head commit is 8e06d6b9274d ("mm: add > >>>>>> swappiness=3D arg to memory.reclaim"). Sorry for the confusion, I = should > >>>>>> have mentioned this. > >>>>> > >>>>> I just figured out a bug in the patch. Anyway, we are going to take= a > >>>>> different approach to fix the issue per the discussion. I already s= ent > >>>>> the series to the mailing list. Please refer to > >>>>> > >>>> https://lore.kernel.org/linux-mm/20240604234858.948986-1-yang@os.amp= erecomputing.com/ > >>>> > >>>> got it. seems you will submit v2? should we wait v2 to do the tests? > >>> > >>> > >>> The real fix is patch #1, that doesn=E2=80=99t need v2. So you just n= eed to test > >>> that. > >> > >> we've finished tests and confirmed patch #1 fixed the issue. > >> we also tested upon patch #2, still clean. > > > > Thanks for testing. Sorry for the late reply, just came back from > > vacation. It seems like Andrew didn't take the fix yet. I will resend > > the patch with your tested-by tag. And I will drop the patch #2 since > > it is just a clean up and I didn't receive any review comments. In > > addition, the undergoing hugepd clean up may make this clean up > > easier, so I will put the clean up on the back burner for now. > > Sorry, was expecting a v2 of the second patch. But agreed that posting > the second patch separately is reasonable -- possibly after the hugepd > stuff is gone for good. I can revisit the cleanup once the hugepd stuff is done. > > -- > Cheers, > > David / dhildenb >