From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 920B3C43334 for ; Thu, 2 Jun 2022 23:15:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E03846B0071; Thu, 2 Jun 2022 19:15:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB6626B0073; Thu, 2 Jun 2022 19:15:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C780E6B0074; Thu, 2 Jun 2022 19:15:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B4C3D6B0071 for ; Thu, 2 Jun 2022 19:15:34 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6CDDA21033 for ; Thu, 2 Jun 2022 23:15:34 +0000 (UTC) X-FDA: 79534854588.20.ED8A788 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf30.hostedemail.com (Postfix) with ESMTP id 3869680061 for ; Thu, 2 Jun 2022 23:14:58 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id l7-20020a17090aaa8700b001dd1a5b9965so6000931pjq.2 for ; Thu, 02 Jun 2022 16:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zch35iVZw1YIk5ddcG0/IquuRupfhf/J5JVLRBMigWU=; b=ny8JfmsQW/sex64nA3Qi/USizF8XSO82i4/853Te4SA2TmwR9wwswdRx6htNNy3S96 318+VOLw5CbHbaJ4GTzIYnngzfCcC3aXhowAVnJEioK5cArfXtXTVTFEZXGUPMAdNOvq IooWNpuFYZdw6SY9SuwtONvBj6cmw2iCFwlame39eyRWCAupZtZE+0J7S4ox3C5NrMhX CfXY7IkFSaEj4TWU3G6yJYjstJaH9JerlFIaRbrOgbQxXOJbBLdHtkjKef5+cVfuNe9m cxdneTV5w8jN1N68dVqJhSpuoG/Uqsh9VNe30HBYNGePzJmQGbaoC5SqMzGQOp6ceGyn V8UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zch35iVZw1YIk5ddcG0/IquuRupfhf/J5JVLRBMigWU=; b=jdi/NmXPW4NI3Ui8N4rhGOOimn5Qqy9QacDkrZgOf4qS0FQSE8moXu/r+3KCuwtok6 uCyhZOkZgi7z1HFqaUQCCGJminDM3DSYEPXh2df+oX8BHbz+dF4aYC8xcAp0iEURSJwe kD0e5Sz1OW3EoaTgGsiqZDjsdEBXoqkcQoy4uZMiyGPwcCX0hI98XoJ0KGVjagtlAA54 A6JF5h2scmGDjIIScvXFphHCgrjKnwZtfUIAqexxiqrc6REHnz+F7E/OCD+Ifes4DN2R zAMV/NA0EUVa6Ln8BCvwdf9olHGw+uWNPdSeAcrV86b4ZmRkuZKurYwfHe/Ph0d8Huex xUIA== X-Gm-Message-State: AOAM531oCYkVTqqjUdjZ9xJkJQjlpe3rlD9AJDDzkZumFi4EDQPZAJLu YVxSuDA7EJRGgGtVES39XXy5iy6apvYPzMV3dhI= X-Google-Smtp-Source: ABdhPJyNwt/B+Vb9B98mXzVS9C3h/QZw2x7E+2OaQXDDpSBSixA5OQh8byIT1+UXsr4ekt3UuHfD/6Py/EkNuMF9708= X-Received: by 2002:a17:90a:ce84:b0:1e4:d803:fad with SMTP id g4-20020a17090ace8400b001e4d8030fadmr13165728pju.99.1654211732920; Thu, 02 Jun 2022 16:15:32 -0700 (PDT) MIME-Version: 1.0 References: <20220602182159.248387-1-shy828301@gmail.com> <20220602182159.248387-6-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Thu, 2 Jun 2022 16:15:20 -0700 Message-ID: Subject: Re: [v2 PATCH 5/7] mm: thp: kill transparent_hugepage_active() To: Matthew Wilcox Cc: Vlastimil Babka , "Kirill A. Shutemov" , Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ny8JfmsQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3869680061 X-Stat-Signature: y43kzatkqy81jc15uazgct3rtgd5rexi X-HE-Tag: 1654211698-943224 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 2, 2022 at 2:00 PM Matthew Wilcox wrote: > > On Thu, Jun 02, 2022 at 11:21:57AM -0700, Yang Shi wrote: > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > > index 79d5919beb83..f315c70d5256 100644 > > --- a/include/linux/huge_mm.h > > +++ b/include/linux/huge_mm.h > > @@ -209,7 +209,9 @@ static inline bool file_thp_enabled(struct vm_area_struct *vma) > > !inode_is_open_for_write(inode) && S_ISREG(inode->i_mode); > > } > > > > -bool transparent_hugepage_active(struct vm_area_struct *vma); > > +extern bool hugepage_vma_check(struct vm_area_struct *vma, > > Please remove the 'extern's. They add no value to function > declarations. Yeah, thanks for catching this. >