From: Yang Shi <shy828301@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [v2 PATCH 5/7] mm: thp: kill transparent_hugepage_active()
Date: Thu, 2 Jun 2022 16:15:20 -0700 [thread overview]
Message-ID: <CAHbLzkqfdFmiEymUfp=_mWK_6tRKeMe0pQ6fGAPLi=oL326LtQ@mail.gmail.com> (raw)
In-Reply-To: <Ypkk0pRHwBrI9Cj/@casper.infradead.org>
On Thu, Jun 2, 2022 at 2:00 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Thu, Jun 02, 2022 at 11:21:57AM -0700, Yang Shi wrote:
> > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
> > index 79d5919beb83..f315c70d5256 100644
> > --- a/include/linux/huge_mm.h
> > +++ b/include/linux/huge_mm.h
> > @@ -209,7 +209,9 @@ static inline bool file_thp_enabled(struct vm_area_struct *vma)
> > !inode_is_open_for_write(inode) && S_ISREG(inode->i_mode);
> > }
> >
> > -bool transparent_hugepage_active(struct vm_area_struct *vma);
> > +extern bool hugepage_vma_check(struct vm_area_struct *vma,
>
> Please remove the 'extern's. They add no value to function
> declarations.
Yeah, thanks for catching this.
>
next prev parent reply other threads:[~2022-06-02 23:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 18:21 [mm-unstable v2 PATCH 0/7] Cleanup transhuge_xxx helpers Yang Shi
2022-06-02 18:21 ` [v2 PATCH 1/7] mm: khugepaged: check THP flag in hugepage_vma_check() Yang Shi
2022-06-02 18:21 ` [v2 PATCH 2/7] mm: thp: introduce transhuge_vma_size_ok() helper Yang Shi
2022-06-02 18:21 ` [v2 PATCH 3/7] mm: khugepaged: remove the redundant anon vma check Yang Shi
2022-06-02 18:21 ` [v2 PATCH 4/7] mm: khugepaged: use transhuge_vma_suitable replace open-code Yang Shi
2022-06-02 18:21 ` [v2 PATCH 5/7] mm: thp: kill transparent_hugepage_active() Yang Shi
2022-06-02 21:00 ` Matthew Wilcox
2022-06-02 23:15 ` Yang Shi [this message]
2022-06-02 18:21 ` [v2 PATCH 6/7] mm: thp: kill __transhuge_page_enabled() Yang Shi
2022-06-02 18:21 ` [v2 PATCH 7/7] mm: khugepaged: reorg some khugepaged helpers Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHbLzkqfdFmiEymUfp=_mWK_6tRKeMe0pQ6fGAPLi=oL326LtQ@mail.gmail.com' \
--to=shy828301@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox