From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F222C52D7B for ; Tue, 13 Aug 2024 17:05:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F8066B00A5; Tue, 13 Aug 2024 13:05:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A5D96B00A6; Tue, 13 Aug 2024 13:05:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86DB06B00A7; Tue, 13 Aug 2024 13:05:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 68A3F6B00A5 for ; Tue, 13 Aug 2024 13:05:47 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 146B740A13 for ; Tue, 13 Aug 2024 17:05:47 +0000 (UTC) X-FDA: 82447849134.06.F54FE00 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf12.hostedemail.com (Postfix) with ESMTP id 2D62B40031 for ; Tue, 13 Aug 2024 17:05:44 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hDYy1A0F; spf=pass (imf12.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723568675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jOz+svYSfLxFvq4Zy72aYEHt1zXxUJBN8hR7YMAL2+0=; b=pAUR7zPKMAXwFt4bgpNrqdLZAFDMgAJORmddu29Ao893TCqrh3ZdwZcEbycd/Wv17k5aBr 38rRsF4SPJ8irt+llbtM2ozJOhw8aHZ/+Td3eK5CBQicsKTTdzx8O7qRNjoSTmO7GVn84S qFwBl/HTHvq7AMvIrtYnUFpE+deJRVg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723568675; a=rsa-sha256; cv=none; b=JfufnP41kmi8grkWFtZCPhBj79Kq1I0t27MSh7i17lsPcjMhQXYTSgSra5f6DimH6MQSOp afU8bcNPkrR6l9Hej/dwzTG2RS1Y+hvhoy1wzOInsBFqFxy8nT/JT4h1tAS6WFrNBjw/tP M4PRoif2KS53aZ0qJbBoPghmZFc8ffM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hDYy1A0F; spf=pass (imf12.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a7a9a369055so448786366b.3 for ; Tue, 13 Aug 2024 10:05:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723568743; x=1724173543; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jOz+svYSfLxFvq4Zy72aYEHt1zXxUJBN8hR7YMAL2+0=; b=hDYy1A0F9FcdgO37I9W8vnWu0uWKnLpPDZPgIY07a4gLZKbkU4ikq6LfUZ8pFTNgmf BI5wbMGO2kdBHYZKvpCpJF6cbkAb15T71f2Lhlury04Xjb3xq25QQg/p6HEs/j4s5uIm L+cF9ar6P0vm10HrivbaZygQLCUFJPIcHzW0YYazdzeZbUtp37pF4jrGkT+UyrqFSGRa ZBdpipestnXUjoAKNimCoeoi90TrQvmV5jpeGpQdJRP99V9RLXd+/QS8WRdGPELBaUQS GST8vevkunncXAynr28q9NJ+Cu1AnBW26BvcZzPExJJ//9mzDcYHq3SI30PwiC85bs6j wBmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723568743; x=1724173543; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jOz+svYSfLxFvq4Zy72aYEHt1zXxUJBN8hR7YMAL2+0=; b=XYu8zDAKc18EIRJtzcVl5VbBVXQgLzslN7ntG4sUCgSy7NZokRAJLJ96+S4qHM79ml Ri2EGvoU+KF7ntc2EDEL6smfCyJmJAdu9zuBUt0pbS7mLI5mKX+oc7brAAxa/e8u/ZgB PmFCMzJ1eYH7xDQC/n0bw3PBvAjttU0jk0kNQHttHIhpMKkq8eXQxC2TQmBv3EYjpAVH mf0xmoS0wRtBKIkql6WW2cFVumjN1IilYnerTC59XtWzQdNVd76Cx7WM7mMaOfpvW/7Y 0uTnP6urr1SBHfKsUWmiD7GE5N8jFSfbdGzyBWyq61OMSsMZCUR0Gl+PR0WamnPGd7FO ILFQ== X-Forwarded-Encrypted: i=1; AJvYcCULHSDKUJLrJ4bmOWjIBgdSYrLGiESGx+x3L96aU1gQqRy1pS/G22uw2+QkoXklS8yrNpWRPgbpTmv03o5iWqxGEYo= X-Gm-Message-State: AOJu0Yx47u9h9kQYjn2mJ687Y1AF0PlbcwZwVi1Tt6Ijry9CkSzKcnA/ 7idmWqp4ycZt00LTsLw50CHye3dMaf4g8gItWiaFiRNEFfLlaTHa72BjrUuKu4hFlEphXtEgGw9 i/CSkSU+xX+oQ+V+vlBubpRdgFTY= X-Google-Smtp-Source: AGHT+IGh48Faj6W98ywLsGY4D6XVjmDKjngdRIBi6kpYNkZqiI7S1Wr5wlNq36Mi9HRPG/yqIyiZRI5lPNa70w1HzBI= X-Received: by 2002:a17:907:f782:b0:a7a:9f0f:ab14 with SMTP id a640c23a62f3a-a8366d7786fmr692466b.33.1723568743267; Tue, 13 Aug 2024 10:05:43 -0700 (PDT) MIME-Version: 1.0 References: <20240812-numa_policy-v1-1-1732602b976c@gentwo.org> In-Reply-To: <20240812-numa_policy-v1-1-1732602b976c@gentwo.org> From: Yang Shi Date: Tue, 13 Aug 2024 10:05:31 -0700 Message-ID: Subject: Re: [PATCH] Reenable NUMA policy support in the slab allocator To: cl@gentwo.org Cc: "Matthew Wilcox (Oracle)" , Johannes Weiner , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2D62B40031 X-Stat-Signature: mpiheushhuy631jyx4q36grgsjz46n55 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723568744-738357 X-HE-Meta: U2FsdGVkX1+b1UUUo8pwg0IW9LT0Mt0ioCU6zYKAzGYi97mx/fkBRrmRtgJFPvOMGINg+VWFFg11ZA3R0FVU65QJuvlVp0rt8C5sFTogxQBV3tpJ66I8mKTIYh4WbZ52/I4iiEL1TPl5Jg/tK7NSqqeqVWuCfVqlVZE1uPXyArXmaJqLoPaZP4CYb68ZHC7iUPFFKpU/gsXTqgAUwh+3BHfkCTNwPmxTo3KyTH0HBICvvCTqM89YeEXidd6NQ//QC+cQForOo6mcnLwItkO95ZT6TzQjOztZnXbcXAoqOPWLUg5j5wlOngJZJiboLucdg6P/7sJGJBdxiIHE8gcJFgz1L/yz9V5F00KgT3JG5sO5TyYTlEpSAhC1ZLSCISxf2zeWIlUJZ6z3dU72P0TGMY5mS5Th6rQtgJq39C7f/LvjQnIyWofXs0ggZdb7s9dyUr6M0ZqucRJhGhZvxWQrlQ7hmNIMztYNYIR7JhUUpdJptGzpfBA9pkYVtTyZO8LS5R6aWKuPj1TigWsSDL2AhiVFo+BfBP9QWfD4jzRg0XWiaV2uWTTcbyWtPAKmrHMeNwzbTyf1K6wWlsqHX3SEVePxo0+ZVN+FrLYrWz+JBGkGaMzMURo1rBsq3OeymUs87l4IsGWL9+g4pUoxKpXXwl4ptGUu5T3qjvSp0nzPRl8L6xOJcpDBb5zMPADr1rIwxyyFYRfHEHyMAjzgMWd/rnsuH7Gg5fEw0NQbd2QYEzm4tH15v/IrBpV13oM5L5ODkxIfzaRh7DG4Uee7AIAhjtSxMnsm2qeuG0mwuYULNXPuV1voaLBEfm1iowqcoCB6t3y3FR5eLhkNgo7wjBqteGDESinFxnEdsj10I5Pyl5SuseBBlk2rA3lmGVyPOu6zHNRL69ENfS8RugNwul3rSdhmfAh92xqTK713ZAXQzZvzXOkEr3SzuUQXg7xJGyVUK7OH2kdgu9l0vGuKQE1 kIHzhBtH YAtAmKUsNaSyAH6+XY0X4FU6gVQMOqiVgyVP1W1hgNsBrqHaRTP1OuENkE65pbqwzi5E+EoOCnAtT8NUW4rP7KZwi3nNrutpR/l1sVqSHabtdro8sMZJwPLHR3LZWal4On6SKMMJy8O29QlYNX33U9EW7RKGp0Zfe99377zAkkTCycbIx0dIOLHmlViw3ChdRs20pvp/zvVyOoRvaJdn6OCe/w8710V5rlm19a8TN9e9RR+hXUdI/UlMCc2032Z6oCNmlKrdt+Dv5M8R/mMLfsuNQL2iA0nnNHCBs0NZ59bLVEX7UyOj2MDeezpZ9i26tAt6lpW+7khLyvtXLRwlz3I/bDS8OJsy+NczMkKJdkjj5VoeloITBiMEG2WIvgqvfjnJXaaFGXEsC5PG8PbVUq3s85bHzn3fBYtTaTTSyJeffSda1MU8OFiZCXBUeTNMU/qva6rUxEG+WoLDUvG48GoH15NRRKPgAVzrxQ4WF/joVHBzDmeF9A0yenpSYSJQwYrbo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 12, 2024 at 10:55=E2=80=AFAM Christoph Lameter via B4 Relay wrote: > > From: Christoph Lameter > > Revert commit 8014c46ad991f05b15ffbc0c6ae130bdf911187b > ("slub: use alloc_pages_node() in alloc_slab_page()"). > > The patch disabled the numa policy support in the slab allocator. It > did not consider that alloc_pages() uses memory policies but > alloc_pages_node() does not. > > As a result of this patch slab memory allocations are no longer spread vi= a > interleave policy across all available NUMA nodes on bootup. Instead > all slab memory is allocated close to the boot processor. This leads to > an imbalance of memory accesses on NUMA systems. > > Also applications using MPOL_INTERLEAVE as a memory policy will no longer > spread slab allocations over all nodes in the interleave set but allocate > memory locally. This may also result in unbalanced allocations > on a single node if f.e. a certain process does the memory allocation on > behalf of all the other processes. > > SLUB does not apply memory policies to individual object allocations. > However, it relies on the page allocators support of memory policies > through alloc_pages() to do the NUMA memory allocations on a per > folio or page level. SLUB also applies memory policies when retrieving > partial allocated slab pages from the partial list. > Please add Fixes id. And should it be sent to stable? The patch makes sense to me. Reviewed-by: Yang Shi > Signed-off-by: Christoph Lameter > --- > mm/slub.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index c9d8a2497fd6..4dea3c7df5ad 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2318,7 +2318,11 @@ static inline struct slab *alloc_slab_page(gfp_t f= lags, int node, > struct slab *slab; > unsigned int order =3D oo_order(oo); > > - folio =3D (struct folio *)alloc_pages_node(node, flags, order); > + if (node =3D=3D NUMA_NO_NODE) > + folio =3D (struct folio *)alloc_pages(flags, order); > + else > + folio =3D (struct folio *)__alloc_pages_node(node, flags,= order); > + > if (!folio) > return NULL; > > > --- > base-commit: d74da846046aeec9333e802f5918bd3261fb5509 > change-id: 20240806-numa_policy-5188f44ba0d8 > > Best regards, > -- > Christoph Lameter > > >