From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48AB5C433F5 for ; Mon, 4 Oct 2021 20:13:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D3F7D61409 for ; Mon, 4 Oct 2021 20:13:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D3F7D61409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 27FF394006E; Mon, 4 Oct 2021 16:13:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 208D594000B; Mon, 4 Oct 2021 16:13:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0829994006E; Mon, 4 Oct 2021 16:13:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id E5AF394000B for ; Mon, 4 Oct 2021 16:13:20 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9307618024DDB for ; Mon, 4 Oct 2021 20:13:20 +0000 (UTC) X-FDA: 78659854560.17.EAF6FE5 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf07.hostedemail.com (Postfix) with ESMTP id 5EC8F1001B2F for ; Mon, 4 Oct 2021 20:13:20 +0000 (UTC) Received: by mail-ed1-f48.google.com with SMTP id p13so41471760edw.0 for ; Mon, 04 Oct 2021 13:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9q0PfcjN4ZcxtERnpGgFCs55vRjNc3NnENgrVFHH7xs=; b=ZMMgpWZHQ0vHntjuBhO97brNLUon0w94MU7wkJLo89LWplC8RTnsjCZTGqxLYVFcVx WyHzRnWOSnqQjfgJx8aFEqhpnIABplxdnaAf1yuuUWpuuviirPR5Ds3GzDKW+taK5PsG kR7QeQV1M8PBDTFXKIOil9RO4xHcVNgVMujLkprdkn+Ey95cNp/93RAGiJTxUe4BDCo0 qZ+FOba7wwfZyi8ooguFvEazfDrzN9GnP+87yDjugEBWHOcC/UJzl4K3utiLs0jr2EFt lc9WSuF0Yt4Z9CjRq7P3CDwewMxYDEW3Nm/f6w4xdZBjmBNCK1fumwPZsxrt6UWDM6NR SAtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9q0PfcjN4ZcxtERnpGgFCs55vRjNc3NnENgrVFHH7xs=; b=1nesTqEWXBAyGoEw8sbAT0HQ54M6m7WAnW/VkpXqeon7I1aN8mY2Pe2uCPIpRf2Lfz PdNYA5BDgbDmihzWQERfofg1/U24tMsAY4PJPVpYhuxDyttyPxuLKGH6Kg2jhN4YNfA4 /DiNqmAyTDd8kBC/1XxmA8klUI/VmZdxYzCxwtxmYip4+o7ASsxiosyrtAUuu/60yVxr Bp05hx5XEVaZn57LvUfbiLsJQfi501D/RiSRxO2zjHNc4DBH4oXl1pYP/DX/IUHzYMc6 AM92tqznRCXejjL1YhBFGaRa92DTqytWD0OOqBxgZceMnxNVpdXzTnnKDPj2WdEXNxIV TCzA== X-Gm-Message-State: AOAM533CT8wQEZ3nM4hNkgnFxciF8SoDqFhXxrTxo3S2ngpeABaFy9Wg vidTOHsCOmQ8Z1EjKWs09q6zAM5MP9YVHPyV5mM= X-Google-Smtp-Source: ABdhPJwfnU85LXVfxLQzchmKGmou6ZhKaAOxYoJNmvfOc6u6tutvah//4ik6xntkhMkxLUgJakl9GQMsDtCaGGJys/A= X-Received: by 2002:a17:906:3854:: with SMTP id w20mr18574634ejc.537.1633378398991; Mon, 04 Oct 2021 13:13:18 -0700 (PDT) MIME-Version: 1.0 References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-3-shy828301@gmail.com> <20211004140637.qejvenbkmrulqdno@box.shutemov.name> <20211004194130.6hdzanjl2e2np4we@box.shutemov.name> In-Reply-To: <20211004194130.6hdzanjl2e2np4we@box.shutemov.name> From: Yang Shi Date: Mon, 4 Oct 2021 13:13:07 -0700 Message-ID: Subject: Re: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault To: "Kirill A. Shutemov" Cc: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Peter Xu , Oscar Salvador , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5EC8F1001B2F X-Stat-Signature: pzn9nootdceskd896foq4npzz9mj3yf3 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZMMgpWZH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-HE-Tag: 1633378400-767816 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 4, 2021 at 12:41 PM Kirill A. Shutemov wrote: > > On Mon, Oct 04, 2021 at 11:17:29AM -0700, Yang Shi wrote: > > On Mon, Oct 4, 2021 at 7:06 AM Kirill A. Shutemov wrote: > > > > > > On Thu, Sep 30, 2021 at 02:53:08PM -0700, Yang Shi wrote: > > > > diff --git a/mm/filemap.c b/mm/filemap.c > > > > index dae481293b5d..2acc2b977f66 100644 > > > > --- a/mm/filemap.c > > > > +++ b/mm/filemap.c > > > > @@ -3195,12 +3195,12 @@ static bool filemap_map_pmd(struct vm_fault *vmf, struct page *page) > > > > } > > > > > > > > if (pmd_none(*vmf->pmd) && PageTransHuge(page)) { > > > > - vm_fault_t ret = do_set_pmd(vmf, page); > > > > - if (!ret) { > > > > - /* The page is mapped successfully, reference consumed. */ > > > > - unlock_page(page); > > > > - return true; > > > > - } > > > > + vm_fault_t ret = do_set_pmd(vmf, page); > > > > + if (!ret) { > > > > + /* The page is mapped successfully, reference consumed. */ > > > > + unlock_page(page); > > > > + return true; > > > > + } > > > > } > > > > > > > > if (pmd_none(*vmf->pmd)) { > > > > > > Hm. Is it unrelated whitespace fix? > > > > It is a coding style clean up. I thought it may be overkilling to have > > a separate patch. Do you prefer separate one? > > Maybe. I tried to find what changed here. It's confusing. Yeah, maybe. Anyway I will separate the real big fix and the cleanup into two patches. This may be helpful for backporting too. > > -- > Kirill A. Shutemov