From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1159DC433EF for ; Thu, 9 Sep 2021 03:22:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 964BF61167 for ; Thu, 9 Sep 2021 03:22:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 964BF61167 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DCFB86B0072; Wed, 8 Sep 2021 23:22:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7F326B0073; Wed, 8 Sep 2021 23:22:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6DF1900002; Wed, 8 Sep 2021 23:22:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id B4A8A6B0072 for ; Wed, 8 Sep 2021 23:22:27 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5CE688249980 for ; Thu, 9 Sep 2021 03:22:27 +0000 (UTC) X-FDA: 78566587134.33.D58D120 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf02.hostedemail.com (Postfix) with ESMTP id 1C9247001A05 for ; Thu, 9 Sep 2021 03:22:26 +0000 (UTC) Received: by mail-ed1-f53.google.com with SMTP id u19so637009edb.3 for ; Wed, 08 Sep 2021 20:22:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MpXgtd6llm5EYXYD9SbAG8NLcGpwtyJ1cM/ICnpdcRk=; b=LXleL7MjU+eD7n5fhiebmisBxoLwH6T4J+SGXTcurH8Cpnzy11Sj1ewq/UZORKhMbO 7dvPH1sgJR/ax52NpBRgWBtwyzB8QbRRCtlJGk+Hrm+7WY9iM+eoJdSOlOFPbnXI5taZ RenuY+pl1+M+Nw3fWuMVH+U/lG3SljW3O7uXDNuvRCi1A7a0HhuDyrvgyyX8pKm7vdT2 U2MrH453Ghiku3dCYob6xvPSpNCX9H2a4q8TfAQU14jACDjfsHl2F7mgrvn4P66TO3Gq t3uVhd3icXJHzTB8WUTCPO38xZmdtFIxm9Gehsl0cma4hhXaAbEAh7cTQDCOH9JgD2i+ iXLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MpXgtd6llm5EYXYD9SbAG8NLcGpwtyJ1cM/ICnpdcRk=; b=Fy7CBQxY4Esfstue+Eaz8wkHu6XI4AT/BPt4lb8yJU1VISkSwjZtRbRisw9f+Stjsy gJ4ltiRR/D7x5eYa81YQO/Nebm4NC1bO1tRKz9eDBtLwsnMh3e8YXWw4wGMde40EhrJS zCl14/bm9SkOVTEgoupCmtxnA8htJ3m0hzgGBs/1dDKZwp8GJnNI117hWOc5XXLv+4Tt 3Y9vLmdm3xS7Cfem4/EkL+l85ouVjJE1hD7FPbDMzF7Nq/4R68e1QLoG8ml42oeG1ej2 +uOGJ75xeWQRi59mzTo9EsvgNcDKM6PHqqh8sWBCccIp8l48d9nfVGQOSliPusv28CeT i1yA== X-Gm-Message-State: AOAM532NxA3Tgd1VPtvCJGvcScbmWhFic5i2jfIHbMyz7yhakOZ/lr4K TghI5zXTYt1QwOOgr7RmEqMH/eLDlhZHjLYM8JE= X-Google-Smtp-Source: ABdhPJxmOIW7g932Zn63vmcSMh8fiX+gvGZ0vPE22QhW8N1Ttf+kbFECcZJMtw4VvNrdDijCn9n9+CSgpbgRb1MDhAs= X-Received: by 2002:aa7:ccd6:: with SMTP id y22mr862724edt.363.1631157745832; Wed, 08 Sep 2021 20:22:25 -0700 (PDT) MIME-Version: 1.0 References: <20210909004131.163221-1-naoya.horiguchi@linux.dev> In-Reply-To: <20210909004131.163221-1-naoya.horiguchi@linux.dev> From: Yang Shi Date: Wed, 8 Sep 2021 20:22:14 -0700 Message-ID: Subject: Re: [PATCH v1] mm, hwpoison: add is_free_buddy_page() in HWPoisonHandlable() To: Naoya Horiguchi Cc: Linux MM , Andrew Morton , Tony Luck , Oscar Salvador , Mike Kravetz , Michal Hocko , David Hildenbrand , Naoya Horiguchi , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1C9247001A05 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LXleL7Mj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Stat-Signature: ckjxx5dxc6wcokxh6a9763zxibht1g53 X-HE-Tag: 1631157746-614830 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 8, 2021 at 5:41 PM Naoya Horiguchi wrote: > > From: Naoya Horiguchi > > commit fcc00621d88b ("mm/hwpoison: retry with shake_page() for > unhandlable pages") changes the return value of __get_hwpoison_page() to > retry for transiently unhandlable cases. However, __get_hwpoison_page() > currently fails to properly judge buddy pages as handlable, so hard/soft > offline for buddy pages always fail as "unhandlable page". This is > totally regrettable. > > So let's add is_free_buddy_page() in HWPoisonHandlable(), so that > __get_hwpoison_page() returns different return values between buddy > pages and unhandlable pages as intended. > > Fixes: fcc00621d88b ("mm/hwpoison: retry with shake_page() for unhandlable pages") > Cc: > Signed-off-by: Naoya Horiguchi > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git v5.14-rc7-mmotm-2021-08-23-16-42/mm/memory-failure.c v5.14-rc7-mmotm-2021-08-23-16-42_patched/mm/memory-failure.c > index 60df8fcd0444..3416c55be810 100644 > --- v5.14-rc7-mmotm-2021-08-23-16-42/mm/memory-failure.c > +++ v5.14-rc7-mmotm-2021-08-23-16-42_patched/mm/memory-failure.c > @@ -1126,7 +1126,7 @@ static int page_action(struct page_state *ps, struct page *p, > */ > static inline bool HWPoisonHandlable(struct page *page) > { > - return PageLRU(page) || __PageMovable(page); > + return PageLRU(page) || __PageMovable(page) || is_free_buddy_page(page); It seems to work. Although this may change the return value of get_any_page() to 1 when MF_COUNT_INCREASED is set. This may cause soft offline to mishandle free buddy page, but MF_COUNT_INCREASED is only set when madvise is used, and madvise definitely can't soft offline free buddy page. It did take me a while to figure out this trick. Maybe need some refactor? Anyway this patch looks fine to me. Reviewed-by: Yang Shi > } > > static int __get_hwpoison_page(struct page *page) > -- > 2.25.1 >