From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9759FC2BD09 for ; Fri, 12 Jul 2024 15:31:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0201C6B0089; Fri, 12 Jul 2024 11:31:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F10DD6B008A; Fri, 12 Jul 2024 11:31:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8A656B008C; Fri, 12 Jul 2024 11:31:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B920F6B0089 for ; Fri, 12 Jul 2024 11:31:19 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6D43E160BD4 for ; Fri, 12 Jul 2024 15:31:19 +0000 (UTC) X-FDA: 82331489478.17.D1B1A38 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf12.hostedemail.com (Postfix) with ESMTP id 48A2140016 for ; Fri, 12 Jul 2024 15:31:17 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lJrfPMrE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720798251; a=rsa-sha256; cv=none; b=jU7pk235daU9qAiY3R1HLIXXDejJnHoHA6Uim9rFBINZ8lwV6mSd9ResDerHuvZ3N+KtaB raLUpp8irZPdl9SmdAxMIbkeSAmFVR9cqNxYZhbxc95QCa4SMA/seK7UypM2/ktY+pDvmw 68grTukznT5RvBRbcVXe/sQ2DuHBEZY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lJrfPMrE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720798251; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v8ApIoZLrTCReZSKKI4weCLSWhQdEbq1c8nSmFnk/F8=; b=uUhqA3+QuWxisYZwnR0JYVzjew8RZOa7Sbww1brlL44iae9os557Ia21dAK8ecqUlmSFxC 1qlgj08ERa6iQW6oifduTi8Ck7/UkYd2n6KHQw83pQCva2EfJnF+kOoRZ13D94lvyuzvm+ iFehBwTQZmcysSDIPcc5MiFOS7NVrZY= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a77cbb5e987so274508766b.3 for ; Fri, 12 Jul 2024 08:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720798276; x=1721403076; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v8ApIoZLrTCReZSKKI4weCLSWhQdEbq1c8nSmFnk/F8=; b=lJrfPMrEJ5UcqPHYTnZkOIyiRiX57crybqGzswZQJOUo6RE5FVZCfl46pH2oBQNth6 BBA0ajC8PoNPfzpIz2PQNfAFH1iiKQSx5dWNqtbVpVhw1AODjtscx/QAn+IaU9cOTNud ZApMgvT8HKfdXFpB5TCmAzpYubukIvdLRl1wRUFmpsSFJ0nqO39zdEYyEfYiv6E707QN UARFXGs++oiTrscjhDawZBT+w7lco1MTGQ6Ibls6TDqv8WLOH0RUwS7afMiWDFwrUfT+ 7uYWrmpVjBplm9X2dT0cFDa0hnGqJmvq7BcIT0BDyYerwbo90NSwfhbMCCSkKUiMacC0 ytqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720798276; x=1721403076; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v8ApIoZLrTCReZSKKI4weCLSWhQdEbq1c8nSmFnk/F8=; b=mXARFNKD7DyvTkjKmSLDmd80pnDibVS4heem/JhrPlURic4VBnrt72jD7nTQsAeTma imAi0JWJ67yA933G5c9s0BJoQ0pl1r9En+9QlOCBFC6yhqDsMvj9kZbIwK3GpsDEHt1K mhS3s78d2pwIJsu10Zywm7JR43aGrwAD9M6/g90W7GAtmp7G/j+K+siT9bbIApTwVNtX KinpzV+V86QT1UV3BsC4w92cGPjBxSDl5Ck0dru3882OTabIpVq7MmT/dHMHQJaEw6hr lT60fmUeJOA7zTv7ZiImLOFpvmCa3LAPqKAyGUV1ivsmICKS00rJyjy5tRdhJoTpenfF 19Tw== X-Forwarded-Encrypted: i=1; AJvYcCWwwlPN6jxsmiyGB0jmDNPRevrrFjnBflTSZXeE9AdC5+PdP3ngNjL/NfXNPSWcqIrSvJ3fH5uImS0zpxbcSrfyh2I= X-Gm-Message-State: AOJu0YwLV+3GU1jbFwB2xFjwDRBjDDoNtr411h7Ns42T+9fxt+guJvMr wcXYer18RcOYqqwW9+ilOSwHdgksHgaP9vWf3u1BXoV6tPwsnhYLHAEt1cRU67limXLI4X3Hl6s zbJjR8u570Oj5Dgo1qCeqT5FtLzw= X-Google-Smtp-Source: AGHT+IHW6bgxiPp+ikEfLCczpHOanG7A6v2Xf9yn4cokyZip30mOrT/z7TOmpNN8hw8IzgP7O5CrZttxImjpv233EDU= X-Received: by 2002:a17:906:6804:b0:a75:2781:a5c4 with SMTP id a640c23a62f3a-a780b6b2f3cmr744849366b.29.1720798275357; Fri, 12 Jul 2024 08:31:15 -0700 (PDT) MIME-Version: 1.0 References: <20240118133504.2910955-1-shy828301@gmail.com> <2d7bd8b2b9736d4a7d0a26169978372b5e002a62.camel@debian.org> In-Reply-To: From: Yang Shi Date: Fri, 12 Jul 2024 08:31:02 -0700 Message-ID: Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit To: Yves-Alexis Perez Cc: Matthew Wilcox , jirislaby@kernel.org, surenb@google.com, riel@surriel.com, cl@linux.com, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Salvatore Bonaccorso , Ben Hutchings Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 48A2140016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: oj98qazexck4hek6n3cby6r7aso9mcnt X-HE-Tag: 1720798277-822987 X-HE-Meta: U2FsdGVkX1+iA538PFu1i6Ya7VSrfk8sQq2gcb9UWMZ61xXG6Pj6+PoYdwhRwao3NAxLBM7s9aNkqGO+Iv6TDTncwoHix2wF5mUty9UlqFNCgW/1a2Rf2USbJaumqm3oNZHEiFmRyukiY+oxQZOIMG2UDb7oBwgecuxl4YIXNWRavhdC4/8Zi83kozEJScNuVLKOGSWyxD+iwuvWqNjWGmvPFnsPv5I7hhewGyJTG3sA2x6niFXd4g9qScmpnY1AuraThsM9lYV9w/kmKT+7qi0TEEY4KudXTze2cMlXwl4uCLE1PoudlGQL9TZCVs8QgZO/km1xd49kSDtEAWfni2TfFH9+nIt+9pmVc4vuurntV+8vslQjqDPKqV5Ry2Jv1jJkT2/Tr8d2xnMgNfNceLPkgJo/0T5w2wA/IDz2yZkZM9cv3b6AetgYYZRmIy3OfE88CZFqySm7ENCIZbQZAtBuohY97E9diW8P/lpLG3F33SCz/jwTUhPjywA+eoe/LaKGIu46M6jRtccL49daERg6RYUVd6yt7Dwi90Y2+UDsrH6+8ANEn+p9w+9JRZWq3X74Tz0OwDrWmmssC9BFioTz4qCJKh8pC3ZiCciNOOoNrUlB7QfQEe/ypdT8WPJF/O4w1KDLmLvH8u4OP4PwvUBoeWoHfpy+BVJ/HYOgGZCh1+pIYZBXuiKtau+C0XfzTjZMUWVfHkNfeWe1aqvhRSJb7VJT29sGg0Mmkx5fcFINR0k/j8WvhZxx900VkvHVM4wkR87sV0vR4/Ql0DvxNXlXJr/o4krwL0f8My4iZnENccev1qSwXI5rG1dbLJsmsS7E4gAxaRg7bAT+wibDmkJ9ZC1uM7VXx2nbdHL017EKTwHKl65RQj25G8T4kX/cHYbIu6vQVVfqjX3+922Z3+Bc4WdEq7RJ7yJUbOCyX1wcjlVsL5bqvFJJIxV6/WrN74YDyR1F7w9u6iZ822t raCnurpd PdZqnMam+oZNDgDU+XXp87QsL7Z+almr3eiFxqLIMKiW4TI/S4nkrz5iqPvK5eHSArOrhvZ/61fAVKSEQglO5ZoDRBigB43MVsLvgVZeni/LvL/0Moc7HBEnqwJLZ2Z88A8xBv1xtPcLwBbtrDPyVbVNXV2wXTc+8FjhSbUbFhPMt/j4bGq/fN0IG4QjrV2uzTeLbCr4YPlEEoEnonh15DONtM2Bd6xGyi43PP7OeizXWGTO9JIL5rio18RBfJXeWoy4VrBYMyDP8KaLhUJEsnREJjwO8CswIv9m5NIUZG+wyDX2nbs6bNR6rSeuuGC07KVpchsEbRMHZEwfDxkfbkVeSEa3W9rfPlVW195IQwOe0LDYV/NP/yNs1helA23E0Qf149zSMz4QHjlAcGMIfUgLIUpOtiPFDj4E10stkGl3feYA3sNKvLumxcxZz35sT/heZdz2YpOLh95qRAL5teMVEpOEqd5nrWw1ZxOBL9ISJl0EE9+Gb4bbaqNHbm0EPBu9vMcluRMI4mOhFzt9fHE1dev7Yq2W72u9D X-Bogosity: Ham, tests=bogofilter, spamicity=0.000230, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 12, 2024 at 7:43=E2=80=AFAM Yves-Alexis Perez wrote: > > On Thu, Jul 11, 2024 at 01:53:04PM -0700, Yang Shi wrote: > > On Thu, Jul 11, 2024 at 1:50=E2=80=AFPM Matthew Wilcox wrote: > > > > > > On Thu, Jul 11, 2024 at 01:47:00PM -0700, Yang Shi wrote: > > > > +++ b/mm/huge_memory.c > > > > @@ -857,7 +857,8 @@ static unsigned long > > > > __thp_get_unmapped_area(struct file *filp, > > > > loff_t off_align =3D round_up(off, size); > > > > unsigned long len_pad, ret, off_sub; > > > > > > > > - if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall()) > > > > + if (IS_ENABLED(CONFIG_32BIT) || IS_ENABLED(CONFIG_X86_32) |= | > > > > + in_compat_syscall()) > > > > > > Why not: > > > > > > if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall()) > > > > Nothing specific, just didn't think of it, sigh... > > > > Thanks for the suggestion. Definitely preferable way. > > > And I just did a quick test rebuilding a kernel with > !IS_ENABLED(CONFIG_64BIT) and running on an i386 Debian sid > installation. > > I can confirm it seems to work as intended: > > Before: > root@testvm:~# uname -a > Linux testvm 6.9.8-686-pae #1 SMP PREEMPT_DYNAMIC Debian 6.9.8-1 (2024-07= -07) i686 GNU/Linux > root@testvm:~# for i in {0..9}; do cat /proc/self/maps |grep libc.so |hea= d -n1; done > b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > > > After: > > root@testvm:~# uname -a > Linux testvm 6.9.8+ #1 SMP PREEMPT_DYNAMIC Fri Jul 12 15:23:07 CEST 2024 = i686 GNU/Linux > root@testvm:~# for i in {0..9}; do cat /proc/self/maps |grep libc.so |hea= d -n1; done > b7cf3000-b7d15000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7d7a000-b7d9c000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7d8b000-b7dad000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7d4b000-b7d6d000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7d64000-b7d86000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7d15000-b7d37000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7c9e000-b7cc0000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7d68000-b7d8a000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7cf6000-b7d18000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > b7ce6000-b7d08000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/= libc.so.6 > > So: > Tested-By: Yves-Alexis Perez Thank you so much. Will submit the formal patch soon. > > I didn't try on other 32b architectures though. > > Regards, > -- > Yves-Alexis Perez