From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D070C433FE for ; Wed, 26 Oct 2022 18:11:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C99548E0002; Wed, 26 Oct 2022 14:11:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C22A78E0001; Wed, 26 Oct 2022 14:11:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC2F98E0002; Wed, 26 Oct 2022 14:11:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 972088E0001 for ; Wed, 26 Oct 2022 14:11:12 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7649640F78 for ; Wed, 26 Oct 2022 18:11:12 +0000 (UTC) X-FDA: 80063892384.01.BFD3B5C Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf15.hostedemail.com (Postfix) with ESMTP id 22C9CA0047 for ; Wed, 26 Oct 2022 18:11:11 +0000 (UTC) Received: by mail-pg1-f170.google.com with SMTP id h185so15633777pgc.10 for ; Wed, 26 Oct 2022 11:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=g7Wi8bTCvfeNU3sTUIqYkMJtWG9DEMZ1nSFdktscQLY=; b=i5hnjp0g6IKy9vbZyM/vQYFA7gfnU/DQtDDTINPcYQOo46VEbmSgN/Wcl1aohtlcc7 jCZK+fQUpaZiFuiRQ0CgdxioIhEcpQH4S0PfJ9+aAv8M5SU2rP3faX/Y6rL7jCPTSCO7 i6oTesmeL2kGUpfpKn6/ykcXfoKTUeddy7LSgpA+EOlJiNi8/QAE9roQT9DNgtDvMfk5 9wgARWg0YjUvjWMBbCBlPW2sAW6VrTv4UuOBCOZhxdTZFXSfyTfRkwX+2haPof/r61pu xr9IL5RByxp/LnWkm4J79g1bBvF+yF0IPtY7CpGltf0902RQaIhufw+lli9y1hyJAr9a yioA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g7Wi8bTCvfeNU3sTUIqYkMJtWG9DEMZ1nSFdktscQLY=; b=In+gH8FVJHfBdomS59f1KO8kKRa20MATQ+zmDiXBiu2+DUkv7TeeMRg/UsVsP6EGQg ND1BJlpffuqG9b/GkniPw4fWNzJCDVSKKcvOSGfO2/fC+RaeFNdptKXA8ddLtSkzrjZk BaAIWg2zMFytzHAp+kLWHgsERky63RXBv8XWYZ1wuwQeEL1inJWaDb0e1JAnJiqRry9T v7npC++2LkkkRtJFTTM8s1kypIO2CSse4gUNfm2It7OmaIiY7uA6C1HGaZcUnYhrbb3y 1e8MMikg+C39ALWmly1biDNU7DTVUAPAvB9P+6oHvXFa1i3HHhbY/7/2mEpOCgi8aK1V kVSQ== X-Gm-Message-State: ACrzQf0NKxIXAaxD/WrWBs6A6ntoBKppNxHmLial9tPgmOlOFw7Lwzcb 09aHCeStJWFzr9X5RXrN3AaDRP7Wt5107aqCA5DEC6KP X-Google-Smtp-Source: AMsMyM76wzsg5/k2aM8/sc3UVRubuR/qvSA+/5aaMC1a9DW7CgTvtQ0uvygXw5LLq5oUthGBrGnsMk+3DEIWGCt2zBo= X-Received: by 2002:a65:45c1:0:b0:461:5855:8d86 with SMTP id m1-20020a6545c1000000b0046158558d86mr38036109pgr.436.1666807871181; Wed, 26 Oct 2022 11:11:11 -0700 (PDT) MIME-Version: 1.0 References: <20221026044524.54793-1-gautammenghani201@gmail.com> In-Reply-To: <20221026044524.54793-1-gautammenghani201@gmail.com> From: Yang Shi Date: Wed, 26 Oct 2022 11:10:58 -0700 Message-ID: Subject: Re: [PATCH] mm/khugepaged: Refactor mm_khugepaged_scan_file tracepoint to remove filename from function call To: Gautam Menghani Cc: akpm@linux-foundation.org, rostedt@goodmis.org, mhiramat@kernel.org, zokeefe@google.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=i5hnjp0g; spf=pass (imf15.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666807872; a=rsa-sha256; cv=none; b=hE1PkyG33XXti5w6JEs1Xbo38ICUB5r7/pu/111yVGX2PSv/V5wLVfAcv8w7Ur/GEihxsE 8lJCwkr4PgNWWBQwjr+XB4VrLyVF9TaD/H2umcexUxbp1iRrorSoGGNKxUFW/KvFXiw3Pi kLmhyOtfcu/uU6t7tyAm/ll9MhLpvOg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666807872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g7Wi8bTCvfeNU3sTUIqYkMJtWG9DEMZ1nSFdktscQLY=; b=ONt/6WG4EqSighpwnRoBLeV4KCIRcFXvmuqL2PLvSN+QQgyR4jD4QCDIZqhLrkA0L4wmn/ gcDmdwY6x/xFr2m8lNa8PkxHqk/yD8TE/0hV3G99IWdGYXZBAHwcOkM8Jp0dF4TibPB9kF M7LUEtJtisatXTkJoIAjy7ct7M00N7Q= X-Rspamd-Queue-Id: 22C9CA0047 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=i5hnjp0g; spf=pass (imf15.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam02 X-Rspam-User: X-Stat-Signature: xms3p94no9e59njzjcjfy4zmq5beczhz X-HE-Tag: 1666807871-917000 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 25, 2022 at 9:45 PM Gautam Menghani wrote: > > Refactor the mm_khugepaged_scan_file tracepoint to move filename > dereference to the tracepoint definition, for maintaing consistency with > other tracepoints[1]. > > [1]:lore.kernel.org/lkml/20221024111621.3ba17e2c@gandalf.local.home/ > > Signed-off-by: Gautam Menghani Reviewed-by: Yang Shi > --- > include/trace/events/huge_memory.h | 8 ++++---- > mm/khugepaged.c | 3 +-- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h > index 935af4947917..760455dfa860 100644 > --- a/include/trace/events/huge_memory.h > +++ b/include/trace/events/huge_memory.h > @@ -171,15 +171,15 @@ TRACE_EVENT(mm_collapse_huge_page_swapin, > > TRACE_EVENT(mm_khugepaged_scan_file, > > - TP_PROTO(struct mm_struct *mm, struct page *page, const char *filename, > + TP_PROTO(struct mm_struct *mm, struct page *page, struct file *file, > int present, int swap, int result), > > - TP_ARGS(mm, page, filename, present, swap, result), > + TP_ARGS(mm, page, file, present, swap, result), > > TP_STRUCT__entry( > __field(struct mm_struct *, mm) > __field(unsigned long, pfn) > - __string(filename, filename) > + __string(filename, file->f_path.dentry->d_iname) > __field(int, present) > __field(int, swap) > __field(int, result) > @@ -188,7 +188,7 @@ TRACE_EVENT(mm_khugepaged_scan_file, > TP_fast_assign( > __entry->mm = mm; > __entry->pfn = page ? page_to_pfn(page) : -1; > - __assign_str(filename, filename); > + __assign_str(filename, file->f_path.dentry->d_iname); > __entry->present = present; > __entry->swap = swap; > __entry->result = result; > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 4734315f7940..9808a899f9f7 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2157,8 +2157,7 @@ static int hpage_collapse_scan_file(struct mm_struct *mm, unsigned long addr, > } > } > > - trace_mm_khugepaged_scan_file(mm, page, file->f_path.dentry->d_iname, > - present, swap, result); > + trace_mm_khugepaged_scan_file(mm, page, file, present, swap, result); > return result; > } > #else > -- > 2.34.1 >