From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4535C4345F for ; Fri, 26 Apr 2024 18:41:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 062E46B0082; Fri, 26 Apr 2024 14:41:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 012DA6B0085; Fri, 26 Apr 2024 14:41:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1C976B0087; Fri, 26 Apr 2024 14:41:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C475E6B0082 for ; Fri, 26 Apr 2024 14:41:57 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1FC131C09C4 for ; Fri, 26 Apr 2024 18:41:57 +0000 (UTC) X-FDA: 82052552274.14.7456D03 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf11.hostedemail.com (Postfix) with ESMTP id 4C84840014 for ; Fri, 26 Apr 2024 18:41:55 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XTNaBzBt; spf=pass (imf11.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714156915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JUJqNR/S6ihu0yVmhT6SDnrwYDU6/B9sR5X5jfrhksU=; b=jYqfN7swgRxDXdz4nY9UeU1psPfi3EShBEadCN/MaaJMpE3BPuGbJwOYvLarUC2LmRxHf0 A5GrW9oQ1UDmSnAwMiv6TkSeOlBnFtyvSZuRhsn+izODDAyCKGhLx+JbBW5Lvd+kBorRaJ aBYWIZ1Y+U8z8rk/WcoUNVqj2KWZNcY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714156915; a=rsa-sha256; cv=none; b=KWqe8vcqBZ3JOYvNtesWP4ppjc7vtc4Pu9bCf7mfNbREhU7RdQ5aOHrdf5Mrj52STqM8zB WbdR3o+PNbjiRHD9vMcJp1TgMnlOZWd8wAfY4Jy904e9ad/Ki/Azgipqkw2/f1G1mXL/Z8 Vhzt1PBl29J9Wd7ke5VufjkqeGh1vzI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XTNaBzBt; spf=pass (imf11.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-572669fd9f9so445781a12.0 for ; Fri, 26 Apr 2024 11:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714156914; x=1714761714; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JUJqNR/S6ihu0yVmhT6SDnrwYDU6/B9sR5X5jfrhksU=; b=XTNaBzBteDYembkVdIEva5t79wJQ8TP7eqqBj5dMXQrvw97LY0BdExX7/BDIDwcHxg uG4pBDdEXF2TQn5glvEQ0rc1wUK7m/t6lo8lmW4uQKMrJdDJYZ+97sPs9qArxNFuSQDA +tW0H/dpsRteasAdWUEavx2vBiy5ww5yq6CCNZseWSL7bkSnuOhxfqtG2SlD0HUcpBjb 3Gv4NakFsNU2SEoW80aAC9KO5Gn9T7DfhwAYYnPb6jLwxsiyc8IgkH/SgUT07+5T8aGl /gD4VL/UnEHNvpSkG8bhUPV8cyymQDAmnJRUhnZW0uYb/AzWBJljZikTeG/ht1BS+qD5 yO6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714156914; x=1714761714; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JUJqNR/S6ihu0yVmhT6SDnrwYDU6/B9sR5X5jfrhksU=; b=fA6Ijz4slV2oxHD5uz1gbKYKsDYRY4/iqr0YdUe7scRvTf9SZQYBL+pXZ8v1/V2DNb vQ61wM2+fAap9OxzrLXeFMDY/jTR52if5dsv/hSjhTbgutHwwbaBFb6G0ikML1mInDNn KCXOC7TNhINNlq3GlNJk2vevjnZ6peVshe0alIsBmKaxKJjQoRhwuzSYLhvSWDgvfYGs ceeUHEmzqxTdMjwjqiK/IKh20+U5+jrRxAF6lOQGptejxIRo63QsZi3icnsDOXgLvlZD mb6Z8qiuY1KhLKIEGylmQbZQbcZvVTjYqAM6A0pqne6SmfKMBRome4eyzETFhQNbLuY+ Z/Uw== X-Forwarded-Encrypted: i=1; AJvYcCUilydgHMlM1bOJBjUuRLeFM768kVFIw5u4OgJR8eRm03ghyCh8WKi5IUIm/P6RRitVC/TnGCR6FQnqL1e7C5SD/M0= X-Gm-Message-State: AOJu0YwPyGXV5Mb75b/WoPbHYoQTTYsYy7umPmPbM37h9v1ZGPKxjz6U WkAUpZGPMs4Db5fWmN1y064agtlWzF+3YKe8unjAd+ZktP1/RDIb9Nq+grw8V1vlvwMT/+WvSU2 VGCz12oO55TsAzlx5Y36txEtrN7E= X-Google-Smtp-Source: AGHT+IHL50vkU5e2FRTV9N/UG5c5QHN1n3fJd/D3N0Z5Di6Ohr+hn6EsKibgn039BfBIv8fUWmKCYqA8nAZGi80X6O4= X-Received: by 2002:a50:998a:0:b0:56e:2b0b:58 with SMTP id m10-20020a50998a000000b0056e2b0b0058mr2525093edb.10.1714156913663; Fri, 26 Apr 2024 11:41:53 -0700 (PDT) MIME-Version: 1.0 References: <20240425211136.486184-1-zi.yan@sent.com> <7c233278-1006-4449-81b2-d473b18a66ca@redhat.com> In-Reply-To: <7c233278-1006-4449-81b2-d473b18a66ca@redhat.com> From: Yang Shi Date: Fri, 26 Apr 2024 11:41:42 -0700 Message-ID: Subject: Re: [PATCH v4] mm/rmap: do not add fully unmapped large folio to deferred split list To: David Hildenbrand Cc: Zi Yan , Andrew Morton , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Ryan Roberts , Barry Song <21cnbao@gmail.com>, Lance Yang , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: xo854swktz763rju5og9uwshd8jisyjx X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 4C84840014 X-HE-Tag: 1714156915-794598 X-HE-Meta: U2FsdGVkX19ohMW9Zvdb/WuLkzV0j6e8h/J66fDQiX2VZKIMgNQmeM4OvzQitvuPv+cT4BTaRQwnvpyci6IwVEUwTAHGRXX8oBiBIIsamjR4jYGW0JbonTeliCOt2gwwkUmnqg9sb8Gtn/1wbNgD3Wxpp24FbrYfFh5e/c+a0kMl/hMoGcmvmAbb+3hLtF/LYRNVHuq9La/jy8c4rSlVt3ZhOO0HF7uVgagJIMICleNAXhB0xTZYusD0sOlm07Smb/L5f8korY7vo+EzqyNzGHn/NT6FTBlJ9UK4zLSGuclWmvFsTDdzEJFIQ0Ei9hH24hahlVD4O1CXA2KhBnHGEJAGJacMjzNV18MiI28JZP6No4p6T/bu8MNROpnMtCDX870Dm++gkbSYehrBMy9wb10hD8jDWWw39bmNYrofLFw4EepW2EojB2Bo6UOtbiR6lz/uxCqJzxb7iFYxaA4xg+Ec8qaI6ckPRwUmDOJwCdeagIN6w5ISLWVT/8uY6r1P0FZ9P07gbIeHeKjWNMmiw8FGxPkqBBwpeVTVM4Ca2KKtN7VAVftbSqQp523GeXH6OAGDAy2njFpsUF6D9kdkofT99zY9TDpoQnfIAENuaU+8jG2LTgEuGcszBaBYSA0hn/RSTSAhSa+U1ORycJvf1MP/YKVyC/xkgVHyQxKRoLbSWxwzLSMrheJlmiusVvX82/K5BK8fWEjoe5kkmIkDMTHTVNsxuDe85iB2Xdi5vcktsr/ouxO3jh/FxltkQ8UKKdvGm33+/hE+tMBC5Aa8h9LIDsLwohdK24evetSAxlfWXCGmYDdb6X/TtnoLc3c28sD6YIMcfCKBwKb7WuH+cE0zvdun3Pxo5Oicbnr0I3j3UFg0FHYVPf4wzrzu9Nr2/GRCcFJd0oyaFLBlrRwoeEC23VkFudm7s8CxcStIZt4lPjroOw9eRPUU0Otxrann/DPzIS3EK3jAvSik9aB YtrAEbzG bkUnhfPLZh2KCgw1ooVHXulNnDmXvjWY74ACNqeGa3Fv+GcwDpVQdZkdziY5lojMO+tLmXQ1GZNeyE1tzp8OZfR0Uqmx0beOmOeXPw4UEhkXeC1wMb1w+ogku/qSUcInJqGH4FpzDOQqCJ5k+DYY8Lm5soBIDzC6aFf0My/5VUCVAK+AvdzDbWNj3LWhiWT5B1YrGbpYB82HppMJk+sHk3p4fDCkuodB9fmaMpV0L7ad01OfmszLvpzDHS2Gw+ifsUjGweqDrB4NiuoCiCMSYY29UdFVho/RlczzuSK8ivGdQgHtx5jq4e5rYephdiUFPdEwBSaeB7kHda/8J55gfviTpIbdCn15iQ3izsAPvOurX8OpM5y0r+jHOhw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000575, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 1:26=E2=80=AFAM David Hildenbrand wrote: > > > > @@ -1553,9 +1557,9 @@ static __always_inline void __folio_remove_rmap(s= truct folio *folio, > > * page of the folio is unmapped and at least one pag= e > > * is still mapped. > > */ > > - if (folio_test_large(folio) && folio_test_anon(folio)) > > - if (level =3D=3D RMAP_LEVEL_PTE || nr < nr_pmdm= apped) > > - deferred_split_folio(folio); > > + if (folio_test_large(folio) && folio_test_anon(folio) &= & > > + list_empty(&folio->_deferred_list) && partially_map= ped) > > + deferred_split_folio(folio); > > And now I realize that we can then even drop the folio_test_large(folio) > check here! Good idea. This is more understandable. > > -- > Cheers, > > David / dhildenb >