From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6865FC35274 for ; Thu, 21 Dec 2023 18:11:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D60C16B0089; Thu, 21 Dec 2023 13:11:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D10B06B008A; Thu, 21 Dec 2023 13:11:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD8AE6B008C; Thu, 21 Dec 2023 13:11:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AB98C6B0089 for ; Thu, 21 Dec 2023 13:11:49 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7F1DD1C17E3 for ; Thu, 21 Dec 2023 18:11:49 +0000 (UTC) X-FDA: 81591618738.16.F60E65D Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf08.hostedemail.com (Postfix) with ESMTP id A3B38160002 for ; Thu, 21 Dec 2023 18:11:47 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aRPMZ7ud; spf=pass (imf08.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703182307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LtDW/QlkRmZR7Q6yp8kPCUc87VHLEMLBcKw7Zj/2psY=; b=hRJdmgeadH4RscrxwZEOHDrm2AHzLuJc+LtRpDE2bVaB3Jcd2Lq1eP9FxxTPHhm3m18T/j qi7tjh41gF595PwfchYi4nSmejz0qx0qDyGpMetaGDS5ZsimhWlAt5CIVnmMO0UVfM6CFg u4Uz/gVwcNO2ehATMuBX4YNT/bIYhSg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703182307; a=rsa-sha256; cv=none; b=5bSJhRVTzwSOAvYJxnpWUHKVRqmQCr+YM+HpgZIodEvr1hInZdnCGSKbjhX2vCOWIsUDTQ 442vcf/zoaiziC2ynd+v2LmBRt2OLoBDC2QNjSrqHvbIPkrFr148Ybxzy4y0XKsTj5IlsB VqDKOvC8ATHEunmqtefuKhDstXFe36w= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aRPMZ7ud; spf=pass (imf08.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5cd54e5fbb2so539850a12.2 for ; Thu, 21 Dec 2023 10:11:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703182306; x=1703787106; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LtDW/QlkRmZR7Q6yp8kPCUc87VHLEMLBcKw7Zj/2psY=; b=aRPMZ7udQEfHg0Kp5XQr1MXIZ4p5+CrokQcNrw/JMTe3NGCRC7dtyBvIjUvUmiPNlK RpBZgap3Ly1L7u3IENsWo4rWYTG4oRGGZxFs9ZdNuAdV/KogoDxmwD/+OS9L+E4tyTXr uJGUwZR9ilFm+H4a0PcnoHumjfPkOQ9DXCEWF5dwW0O8wPcdFm8e2U/2cFRTZqSqU1gg G85YEQcCtBdHZ2ELM2g+PV7VUz0chEx8C/su66lkmUar8ib0Kc5G4AWpislDh0cqOLLy KvwsSXDr341kX4jZqmcAB7v0V/C16UtGzSvav+1AXZiiouiu9Q9JnS108kqno8Eclmfl jl+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703182306; x=1703787106; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LtDW/QlkRmZR7Q6yp8kPCUc87VHLEMLBcKw7Zj/2psY=; b=m4FsTL2eMSCFUyAmvdt2G3dmp0obSbhCF4F6YRGhEKQ9K4YEtar+mfEys3TeyQl49j W4zYLasVyeHy3qr2dit/mITTJMRXWcZ4LtuJWPhMJ+B7V35Xf7/Ly7aWX1ObUUdsQOJV KwKGfWG9+EbcH8B1Q2iXNgmHGegtlt3fFBZEggYUTphyUhrOjeb47n+DnAXQpq02GFNB S2bv6+SSqYOdP4I7BYyUJ1jYevfPxNnh45UGtvsKQTTLb/oE4tMZzI09rQDUBdoiI1zJ Ur/Qmw3rkGJQqTXLdzSOfKfVgq9RKX91Mryiox41W9ZaXny1QrIVWyl8pz5kF9auYKHG BF+g== X-Gm-Message-State: AOJu0Yy4IZoXdn2+U8u6wQXz4iBS53uh+bPXxAH2W5dnQtJUYD/XswPh 8phJHbpQxtD4IlGddDAifFyPmSjKKyFeBOsfKNs= X-Google-Smtp-Source: AGHT+IGBsZnK+kq+Pp3Jae9ZTy1bMSpfvs2ar5Sfdzl9Dsr5tp9Y302bbpsYWY8W5uNQbN9GEc4HZzGj0Q4O1gbVayY= X-Received: by 2002:a17:90a:6c06:b0:28b:eb30:edf2 with SMTP id x6-20020a17090a6c0600b0028beb30edf2mr128379pjj.81.1703182306513; Thu, 21 Dec 2023 10:11:46 -0800 (PST) MIME-Version: 1.0 References: <202312192310.56367035-oliver.sang@intel.com> <5753c5cb-62e3-42e6-bf04-b12b4c77b259@intel.com> In-Reply-To: <5753c5cb-62e3-42e6-bf04-b12b4c77b259@intel.com> From: Yang Shi Date: Thu, 21 Dec 2023 10:11:34 -0800 Message-ID: Subject: Re: [linux-next:master] [mm] 1111d46b5c: stress-ng.pthread.ops_per_sec -84.3% regression To: "Yin, Fengwei" Cc: kernel test robot , Rik van Riel , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Matthew Wilcox , Christopher Lameter , ying.huang@intel.com, feng.tang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: i4ukxtmtwhugwfyb5ounw6dxhwsof7ka X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A3B38160002 X-Rspam-User: X-HE-Tag: 1703182307-918937 X-HE-Meta: U2FsdGVkX1+g5h1B0IOgYRJUActnTTUAgIuSa4sjMMvh9UMeeqzvpuDxfyK287xCDcVKmpN/dmVhqd75UEN01vokOelV5Ow5OzHTOMvz6KOgKlUK2j7zQjtmUmZzPJYTpra19ofeyJp9yaiX1jxZo/YcgVwfZaObeTokGkkW9VBOjXsnwDYoLqEHTsEpK/im5s/jyw3GCKv3+uySwVLO8ABjg51O2UHPeto+WZFawocP9AgcejAxgSDmI//F+KBJrDRPPPNfD0Inu/VYoStV8u9dW0nHsdaxFz4keiXyFkxltFqBOtTIAyXGyqVgrVcGZymBhnwN2fAFVm+DRoSMoX+FqT8WvbKh8OJoS0BYuXNYWQMzWA7kaTpe8DRWBvL18er0CqvWZfirefV1yz/il/dB/vORcW/j3c4VU25Ehl/cbrsJoD9Z1mqJsrJrLHmbpoTW9S9bJ/fQSfEY2eCc7Qjz0s/SHn11pqqU0Y3rFf1NSqRern6rXT4qLwJ0NM/QGhzukPbN9UDG8bM5dxakXFAh6jsmM6DhYZmw+kj5ANQ84Rak3VwISHkyBGQWGrUuYA620tvK5GFNaHTHOUfoQvrg8qyyzo4GT8PstdGkjg9S6FaZqO+S11a1+EaGOCoSFn/IjDwiqsLPkYNS1RKHeLSv5LZsBX+yVKZWGJ6Zn2+mg/+YKerEkrNexfgmTzJzBo479M6iOZiNvE6pi+I3H7PdkNLBcogSZQkH+jBrqnkO55MO5gfHG8q2osI3eqFkku55ownxHHJrmZDne8RvexEA7rZ4KK4iiYxa2E1ZyhULJAKJRYzN9uHSc72KTBiMSDGgU2vlGEPSLBAWXAP5wnyzvzoXjJc3d4bhPe3V6SHGU6kDe/qZiDEhZzEwgiFqwxsSkBNyWVPbjDEqD0tdG53gjUCV0dAux/sjd2ERimTQxrYlogU46WdrFICm0e4IoF7fBKwjGxLGPfsUrG1 kZE7Aks8 UMQPLWLZO895QtxBID4+eC/2G8kD9GoAupnhJrFmBxg3IeuJ6DnrZlArnyl2z4/9YmD2rOz1hHHB38cX9qPrCZdI9Ny58lwG89YTlQlUjySi0aFlKUEE31O6C+NVnzqPmJqm6Y99lUelNb2wLHwLjfspqcJRSWUAlSmwQK6qoudCbEN1CfJD6KSKEcUP0k5Q7DWU2nXZ0gSprVjYjyNgleY1lnLyvu0cVSv71FQBXRgh81G8s5vplC0sONB4HiK9t5uIOqaKMDN0VFh/ddzd0vd/RIBbgZCU2KEkE0XztSdmNmU3psO8NbDirPsf97ZNADk0a8E/20WtebfYgjJKlluA3zeXV5tphOtMsI42Fr8F8Fa/BCIkzDKrPQFaPdG0nXA6UZgr63+whYmEFJnnA/trKXJ9mxEWqRar1brvQHw7hR8g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 5:40=E2=80=AFAM Yin, Fengwei wrote: > > > > On 12/21/2023 8:58 AM, Yin Fengwei wrote: > > But what I am not sure was whether it's worthy to do such kind of chang= e > > as the regression only is seen obviously in micro-benchmark. No evidenc= e > > showed the other regressionsin this report is related with madvise. At > > least from the perf statstics. Need to check more on stream/ramspeed. > > Thanks. > > With debugging patch (filter out the stack mapping from THP aligned), > the result of stream can be restored to around 2%: > > commit: > 30749e6fbb3d391a7939ac347e9612afe8c26e94 > 1111d46b5cbad57486e7a3fab75888accac2f072 > 89f60532d82b9ecd39303a74589f76e4758f176f -> 1111d46b5cbad with > debugging patch > > 30749e6fbb3d391a 1111d46b5cbad57486e7a3fab75 89f60532d82b9ecd39303a74589 > ---------------- --------------------------- --------------------------- > 350993 -15.6% 296081 =C2=B1 2% -1.5% 345689 > stream.add_bandwidth_MBps > 349830 -16.1% 293492 =C2=B1 2% -2.3% 341860 = =C2=B1 > 2% stream.add_bandwidth_MBps_harmonicMean > 333973 -20.5% 265439 =C2=B1 3% -1.7% 328403 > stream.copy_bandwidth_MBps > 332930 -21.7% 260548 =C2=B1 3% -2.5% 324711 = =C2=B1 > 2% stream.copy_bandwidth_MBps_harmonicMean > 302788 -16.2% 253817 =C2=B1 2% -1.4% 298421 > stream.scale_bandwidth_MBps > 302157 -17.1% 250577 =C2=B1 2% -2.0% 296054 > stream.scale_bandwidth_MBps_harmonicMean > 339047 -12.1% 298061 -1.4% 334206 > stream.triad_bandwidth_MBps > 338186 -12.4% 296218 -2.0% 331469 > stream.triad_bandwidth_MBps_harmonicMean > > > The regression of ramspeed is still there. Thanks for the debugging patch and the test. If no one has objection to honor MAP_STACK, I'm going to come up with a more formal patch. Even though thp_get_unmapped_area() is not called for MAP_STACK, stack area still may be allocated at 2M aligned address theoretically. And it may be worse with multi-sized THP, for 1M. Do you have any instructions regarding how to run ramspeed? Anyway I may not have time debug it until after holidays. > > > Regards > Yin, Fengwei