From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 975FAC4332F for ; Thu, 3 Nov 2022 17:14:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 300716B0072; Thu, 3 Nov 2022 13:14:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B1A76B0074; Thu, 3 Nov 2022 13:14:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A8746B0072; Thu, 3 Nov 2022 13:14:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0AE576B0072 for ; Thu, 3 Nov 2022 13:14:10 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CCB351204F8 for ; Thu, 3 Nov 2022 17:14:09 +0000 (UTC) X-FDA: 80092779018.12.B8C244D Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf01.hostedemail.com (Postfix) with ESMTP id DEF9040002 for ; Thu, 3 Nov 2022 17:14:07 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id o7so2291960pjj.1 for ; Thu, 03 Nov 2022 10:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=38PbifJ82siOWP93EOR7nWjQvXdjLMHLCirjt79C52Y=; b=nBhmOboQE7UtoVHovVd+g9wJf2OqjOgsAYJ8dO0/Bqta4VQW1Yxv6X5VtZb8gdYx6Y df/AB3UlUgcySW2Mx8iZjVxzuYSy0hd4qF3anpFaS2s2EHvovwQ/tziVoNE6aC8bTLPc rpLEnmZCBnNvb8SC4uyu/IMdM3mdAQ2EVPRMyT8jdVCVhBfc18hAU4JUK2hdIRUHu3ld Yj8DFWhtMoE6esL1DWUfJJgFhTq45luEB/oJ4ujzAZ95OYrA9ReUR3D10TCQPqZqIVeQ wAHrxd9i8NWpCJ8dDgEp2u2OL1+7nYO7VBx8Y/oKVsIOewYdkC7YCzJv5rVhvx80c0hd TL2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=38PbifJ82siOWP93EOR7nWjQvXdjLMHLCirjt79C52Y=; b=rxQA+9k5aj0RSB/TpB5nGFM7CooN6Pjwkkxlu5CwQdnW2jCx0b3Cm4++jNGroE2lar ptLkSiLfTg6HGDGfESlWXN1AyvijFWUxvC+queAX9LJWRlxMUuX2eYoHjXfYsoPkfAAS 0XjUdkj2gmA5iw4GDt2KkfoLhpiiXvu9VqVvxRkqWHvhFJ5lA8aLpZF2eIO+FSxdDoaW VKWxStjj9g9S1vkwawf8VG0CDsXcJiUIg9DomzCunlhm2MnSSbmW97vPd91hxYXT3p34 wesd6kGSDNU6SI5AunimkV3kFOTCtThsi2BTHzQ32z95LqxGWxk31v1gQ5HAPP9FVqsM 6WvQ== X-Gm-Message-State: ACrzQf1eSut6mFufMl5ZlbVTFi0H6zNmZbBiYAqwTZe5Upu5tLb0pt5/ LRthstjBIk2mktzXI3lpq9NdO8UjA4iFFS/pwrs= X-Google-Smtp-Source: AMsMyM5SFGmJQcKgV8VOyIegxXexsNHSW5jZFAzrpn8N1iAPMuHPcnEq83AZESGEVpJCuxBG58eMBvq5pNDn0CiK3mI= X-Received: by 2002:a17:903:41ca:b0:186:a68e:c06d with SMTP id u10-20020a17090341ca00b00186a68ec06dmr30249533ple.61.1667495646749; Thu, 03 Nov 2022 10:14:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yang Shi Date: Thu, 3 Nov 2022 10:13:54 -0700 Message-ID: Subject: Re: [PATCH] mm: don't warn if the node is offlined To: Michal Hocko Cc: "Zach O'Keefe" , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Davidoff , Bob Liu Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667495647; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=38PbifJ82siOWP93EOR7nWjQvXdjLMHLCirjt79C52Y=; b=Q11Yk+k8i/Lm5Vi1yBjIKkEqLjsLehu1vjbKLpHl+RcOPfkl4RggVihnViJgnA/mWK6/6t UKu5xZPxhJw4/qEGKRdHpJMIqpAU92sz20YMyHtXGDvLQLUcw51i9/6E11yp6bl0tuGd6i lJm/fbLOVsE3+Udx0jlFDcTlMKWpuAs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nBhmOboQ; spf=pass (imf01.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667495647; a=rsa-sha256; cv=none; b=0v57zVnvk3oFvdv8pCYAwC4mIHvX6R/S9KoybDXZcrgQYPELKg7bTm42x2/gXkDiPl9+pg jMI0cqMFPry2cA9LG29/xpLKvXZrZbC+OcNtvO0Nr48umaU7eporR9gnRLg9ifg29JjoYQ +aYKpIWkT5KrQnBZ6RiH7CbXmDSaCQA= Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nBhmOboQ; spf=pass (imf01.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: u86bdc7unt4w9tismim9rrtfdmy5em6u X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DEF9040002 X-HE-Tag: 1667495647-239431 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 3, 2022 at 12:54 AM Michal Hocko wrote: > > On Wed 02-11-22 13:08:08, Yang Shi wrote: > [...] > > So I think we narrowed down to two options: > > 1. Preserve the interleave behavior but bail out if the target node is > > not online (it is also racy, but doesn't hurt) > > I do not think there is merit in the interleave patch is dubious to say > the least. > > > 2. Remove the node balance code entirely > > Yes, removing the balancing makes sense but I would still hope that we > do not fail too easily if the range is populated on multiple nodes > equally. In practice it will likely not matter much I guess but setting > up all nodes with top score is just easy to achieve. OK, thanks. I will come up with a patch to allow fallback between the nodes, it should be largely based on the change suggested by you. > -- > Michal Hocko > SUSE Labs